Skip to contentSkip to conversation

packagegroup-meta-oe: drop ptest groups

PATCH In review Alexander Kanavin 3 participants 7 messages Dec 2, 2018 – Dec 3, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 packagegroup-meta-oe: drop ptest groups

packagegroup.bbclass adds ptest packages automatically, so there is no need to maintain manual lists

---
 .../packagegroups/packagegroup-meta-oe.bb      | 18 ------------------
 1 file changed, 18 deletions(-)
meta-oe/recipes-core/packagegroups/packagegroup-meta-oe.bb +0 -18
index 2a23a6170..3a3e47897 100644
@@ -21,7 +21,6 @@ PACKAGES = ' \
     packagegroup-meta-oe-test \
     ${@bb.utils.contains("DISTRO_FEATURES", "x11", "packagegroup-meta-oe-gnome", "", d)} \
     ${@bb.utils.contains("DISTRO_FEATURES", "x11", "packagegroup-meta-oe-graphics", "", d)} \
-    ${@bb.utils.contains("DISTRO_FEATURES", "ptest", "packagegroup-meta-oe-ptest", "", d)} \
 '
 
 RDEPENDS_packagegroup-meta-oe = "\
@@ -41,7 +40,6 @@ RDEPENDS_packagegroup-meta-oe = "\
     packagegroup-meta-oe-test \
     ${@bb.utils.contains("DISTRO_FEATURES", "x11", "packagegroup-meta-oe-gnome", "", d)} \
     ${@bb.utils.contains("DISTRO_FEATURES", "x11", "packagegroup-meta-oe-graphics", "", d)} \
-    ${@bb.utils.contains("DISTRO_FEATURES", "ptest", "packagegroup-meta-oe-ptest", "", d)} \
 "
 
 RDEPENDS_packagegroup-meta-oe-benchmarks = "\
@@ -231,19 +229,3 @@ RDEPENDS_packagegroup-meta-oe-test ="\
     catch2 cppunit cunit cxxtest evtest fb-test \
     fwts gtest pm-qa stress-ng testfloat \
     "
-
-RDEPENDS_packagegroup-meta-oe-ptest = "\
-    zeromq-ptest \
-    leveldb-ptest \
-    psqlodbc-ptest \
-    lua-ptest \
-    protobuf-ptest \
-    rsyslog-ptest \
-    oprofile-ptest \
-    libteam-ptest \
-    uthash-ptest \
-    mcelog-ptest \
-    libee-ptest \
-    numactl-ptest \
-    poco-ptest \
-    "
Signature · 1 line
2.17.1
#1 lore raw
Quoted 1 line · Alexander Kanavin

packagegroup.bbclass adds ptest packages automatically, so there is no need to maintain manual lists

My understanding all ptests are included in the auto mode. I wanted to isolate the ones for meta-oe to get a quicker test run.

Am I misunderstanding ptest?

- armin

Quoted 46 lines
---
 .../packagegroups/packagegroup-meta-oe.bb      | 18 ------------------
 1 file changed, 18 deletions(-)
meta-oe/recipes-core/packagegroups/packagegroup-meta-oe.bb +0 -18
index 2a23a6170..3a3e47897 100644
@@ -21,7 +21,6 @@ PACKAGES = ' \
     packagegroup-meta-oe-test \
     ${@bb.utils.contains("DISTRO_FEATURES", "x11", "packagegroup-meta-oe-gnome", "", d)} \
     ${@bb.utils.contains("DISTRO_FEATURES", "x11", "packagegroup-meta-oe-graphics", "", d)} \
-    ${@bb.utils.contains("DISTRO_FEATURES", "ptest", "packagegroup-meta-oe-ptest", "", d)} \
 '
 
 RDEPENDS_packagegroup-meta-oe = "\
@@ -41,7 +40,6 @@ RDEPENDS_packagegroup-meta-oe = "\
     packagegroup-meta-oe-test \
     ${@bb.utils.contains("DISTRO_FEATURES", "x11", "packagegroup-meta-oe-gnome", "", d)} \
     ${@bb.utils.contains("DISTRO_FEATURES", "x11", "packagegroup-meta-oe-graphics", "", d)} \
-    ${@bb.utils.contains("DISTRO_FEATURES", "ptest", "packagegroup-meta-oe-ptest", "", d)} \
 "
 
 RDEPENDS_packagegroup-meta-oe-benchmarks = "\
@@ -231,19 +229,3 @@ RDEPENDS_packagegroup-meta-oe-test ="\
     catch2 cppunit cunit cxxtest evtest fb-test \
     fwts gtest pm-qa stress-ng testfloat \
     "
-
-RDEPENDS_packagegroup-meta-oe-ptest = "\
-    zeromq-ptest \
-    leveldb-ptest \
-    psqlodbc-ptest \
-    lua-ptest \
-    protobuf-ptest \
-    rsyslog-ptest \
-    oprofile-ptest \
-    libteam-ptest \
-    uthash-ptest \
-    mcelog-ptest \
-    libee-ptest \
-    numactl-ptest \
-    poco-ptest \
-    "
#2 lore raw
Quoted 4 lines · On Sun, 2 Dec 2018 at 15:57, akuster808 <[email protected]> wrote:

My understanding all ptests are included in the auto mode. I wanted to isolate the ones for meta-oe to get a quicker test run.

Am I misunderstanding ptest?

The problem appears when ptest is in DISTRO_FEATURES (e.g. poky default). Bitbake then throws an error due to duplicate entries in packagegroups (-ptest stuff included twice - once via explicit definition in the recipe and then again from packagegroups.bbclass):

ERROR: packagegroup-meta-oe-1.0-r0 do_package: QA Issue:
packagegroup-meta-oe-ptest is listed in PACKAGES multiple times, this
leads to packaging errors. [packages-list]
ERROR: packagegroup-meta-oe-1.0-r0 do_package: Fatal QA errors found,
failing task.
ERROR: packagegroup-meta-oe-1.0-r0 do_package: Function failed: do_package
ERROR: Logfile of failure stored in:
/home/alexander/development/poky/build/tmp/work/all-poky-linux/packagegroup-meta-oe/1.0-r0/temp/log.do_package.89890
ERROR: Task (/home/alexander/development/meta-openembedded/meta-oe/recipes-core/packagegroups/packagegroup-meta-oe.bb:do_package) failed with exit code '1'

I don't think you can cherry-pick ptests at the moment.

Alex

#3 lore raw
Quoted 21 lines · Alexander Kanavin
Quoted 4 lines

My understanding all ptests are included in the auto mode. I wanted to isolate the ones for meta-oe to get a quicker test run.

Am I misunderstanding ptest?

The problem appears when ptest is in DISTRO_FEATURES (e.g. poky default). Bitbake then throws an error due to duplicate entries in packagegroups (-ptest stuff included twice - once via explicit definition in the recipe and then again from packagegroups.bbclass):

ERROR: packagegroup-meta-oe-1.0-r0 do_package: QA Issue:
packagegroup-meta-oe-ptest is listed in PACKAGES multiple times, this
leads to packaging errors. [packages-list]
ERROR: packagegroup-meta-oe-1.0-r0 do_package: Fatal QA errors found,
failing task.
ERROR: packagegroup-meta-oe-1.0-r0 do_package: Function failed: do_package
ERROR: Logfile of failure stored in:
/home/alexander/development/poky/build/tmp/work/all-poky-linux/packagegroup-meta-oe/1.0-r0/temp/log.do_package.89890
ERROR: Task (/home/alexander/development/meta-openembedded/meta-oe/recipes-core/packagegroups/packagegroup-meta-oe.bb:do_package) failed with exit code '1'

Quoted 1 line

I don't think you can cherry-pick ptests at the moment.

However, maybe renaming the ptest group will work. Let me try that.

Alex

#4 lore raw
Quoted 23 lines · Alexander Kanavin
Quoted 21 lines · Alexander Kanavin
Quoted 4 lines

My understanding all ptests are included in the auto mode. I wanted to isolate the ones for meta-oe to get a quicker test run.

Am I misunderstanding ptest?

The problem appears when ptest is in DISTRO_FEATURES (e.g. poky default). Bitbake then throws an error due to duplicate entries in packagegroups (-ptest stuff included twice - once via explicit definition in the recipe and then again from packagegroups.bbclass):

ERROR: packagegroup-meta-oe-1.0-r0 do_package: QA Issue:
packagegroup-meta-oe-ptest is listed in PACKAGES multiple times, this
leads to packaging errors. [packages-list]
ERROR: packagegroup-meta-oe-1.0-r0 do_package: Fatal QA errors found,
failing task.
ERROR: packagegroup-meta-oe-1.0-r0 do_package: Function failed: do_package
ERROR: Logfile of failure stored in:
/home/alexander/development/poky/build/tmp/work/all-poky-linux/packagegroup-meta-oe/1.0-r0/temp/log.do_package.89890
ERROR: Task (/home/alexander/development/meta-openembedded/meta-oe/recipes-core/packagegroups/packagegroup-meta-oe.bb:do_package) failed with exit code '1'

Quoted 4 lines
Quoted 1 line

I don't think you can cherry-pick ptests at the moment.

However, maybe renaming the ptest group will work. Let me try that.

while you are at it, send all the four patches in a single series, current version seems to have conflicts.

Quoted 6 lines

Alex
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#5 lore raw
Quoted 5 lines · Khem Raj
Quoted 2 lines

However, maybe renaming the ptest group will work. Let me try that.

while you are at it, send all the four patches in a single series, current version seems to have conflicts.

Sorry for the confusion - drop the first two patches, and take the last two only.

Alex

#6 lore raw

No problem, thanks!

Taking
https://patchwork.openembedded.org/patch/156806/
https://patchwork.openembedded.org/patch/156807/

Quoted 13 lines · Alexander Kanavin
Quoted 5 lines · Khem Raj
Quoted 2 lines

However, maybe renaming the ptest group will work. Let me try that.

while you are at it, send all the four patches in a single series, current version seems to have conflicts.

Sorry for the confusion - drop the first two patches, and take the last two only.

Alex