Skip to contentSkip to conversation

dt-bindings: clock: add clock id for renesas adg clocks

PATCH Superseded [email protected] 2 participants 2 messages Dec 3, 2018

Subsystems (2)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 5/6 dt-bindings: clock: add clock id for renesas adg clocks

From: Jiada Wang <[email protected]>

This patch adds clock ID for renesas adg clocks

---
 include/dt-bindings/clock/renesas-adg.h | 11 +++++++++++
 1 file changed, 11 insertions(+)
 create mode 100644 include/dt-bindings/clock/renesas-adg.h
include/dt-bindings/clock/renesas-adg.h new file +11 -0
new file mode 100644
index 000000000000..fe30c186cef7
@@ -0,0 +1,11 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Copyright (C) 2018 Mentor Graphics inc.
+ */
+#ifndef __DT_BINDINGS_RENESAS_ADG_H__
+#define __DT_BINDINGS_RENESAS_ADG_H__
+
+#define ADG_FIX				0
+#define ADG_AVB				1
+
+#endif /* __DT_BINDINGS_RENESAS_ADG_H__ */
Signature · 1 line
2.17.0
#1 lore raw

Hi Jiada,

Quoted 18 lines · On 12/03/2018 01:24 PM, [email protected] wrote:

From: Jiada Wang <[email protected]>

This patch adds clock ID for renesas adg clocks

---
 include/dt-bindings/clock/renesas-adg.h | 11 +++++++++++
 1 file changed, 11 insertions(+)
 create mode 100644 include/dt-bindings/clock/renesas-adg.h
include/dt-bindings/clock/renesas-adg.h new file +1 -0
new file mode 100644
index 000000000000..fe30c186cef7
@@ -0,0 +1,11 @@
+/* SPDX-License-Identifier: GPL-2.0 */

include/dt-bindings/clock/renesas-adg.h line 11

Quoted 10 lines
include/dt-bindings/clock/renesas-adg.h new file +10 -0
+/*
+ * Copyright (C) 2018 Mentor Graphics inc.
+ */
+#ifndef __DT_BINDINGS_RENESAS_ADG_H__
+#define __DT_BINDINGS_RENESAS_ADG_H__
+
+#define ADG_FIX				0
+#define ADG_AVB				1
+
+#endif /* __DT_BINDINGS_RENESAS_ADG_H__ */

instead of adding these trivial definitions in a new header file with no potential for further extension, I would like to ask you to write a proper device tree bindings documentation section and describe the clock ids as a list of acceptable values for a cell.

--
Best wishes,
Vladimir