Skip to contentSkip to conversation

i2c: Add a length check to the SMBus write handling

PATCH Applied [email protected] 2 participants 2 messages Dec 3, 2018

lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 i2c: Add a length check to the SMBus write handling

From: Corey Minyard <[email protected]>

Avoid an overflow.

Signed-off-by Corey Minyard <[email protected]>
Reviewed-by Peter Maydell <[email protected]>
Reviewed-by Philippe Mathieu-Daudé <[email protected]>
Tested-by Philippe Mathieu-Daudé <[email protected]>
Cc QEMU Stable <[email protected]>
---
 hw/i2c/smbus.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
hw/i2c/smbus.c +5 -1
index 6ff77c582f..30028bfcc2 100644
@@ -193,7 +193,11 @@ static int smbus_i2c_send(I2CSlave *s, uint8_t data)
     switch (dev->mode) {
     case SMBUS_WRITE_DATA:
         DPRINTF("Write data %02x\n", data);
-        dev->data_buf[dev->data_len++] = data;
+        if (dev->data_len >= sizeof(dev->data_buf)) {
+            BADF("Too many bytes sent\n");
+        } else {
+            dev->data_buf[dev->data_len++] = data;
+        }
         break;
     default:
         BADF("Unexpected write in state %d\n", dev->mode);
Signature · 1 line
2.17.1