Skip to contentSkip to conversation

drm/msm/a6xx: Use new kernel API free function for gpu state

PATCH New Jordan Crouse 1 participant 1 message Dec 3, 2018

Subsystems (4)
DRM drivers Arm Qualcomm mailing list DRM driver for Qualcomm display hardware DRM driver for Qualcomm Adreno GPUs
lore
Share & tools
lore

Jordan Crouse

author
#0 lore raw

PATCH 1/1 drm/msm/a6xx: Use new kernel API free function for gpu state

dadb36b7ec42 ("drm/msm: Add a common function to free kernel buffer objects") missed freeing the crashdumper state for a6xx.

Signed-off-by Jordan Crouse <[email protected]>
---
 drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)
drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c +1 -10
index df6308e7ea67..716595b664dd 100644
@@ -149,15 +149,6 @@ static int a6xx_crashdumper_run(struct msm_gpu *gpu,
 	return ret;
 }
 
-static void a6xx_crashdumper_free(struct msm_gpu *gpu,
-		struct a6xx_crashdumper *dumper)
-{
-	msm_gem_unpin_iova(dumper->bo, gpu->aspace);
-	msm_gem_put_vaddr(dumper->bo);
-
-	drm_gem_object_unreference(dumper->bo);
-}
-
 /* read a value from the GX debug bus */
 static int debugbus_read(struct msm_gpu *gpu, u32 block, u32 offset,
 		u32 *data)

@@ -900,7 +891,7 @@ struct msm_gpu_state *a6xx_gpu_state_get(struct msm_gpu *gpu)
 		a6xx_get_clusters(gpu, a6xx_state, &dumper);
 		a6xx_get_dbgahb_clusters(gpu, a6xx_state, &dumper);
 
-		a6xx_crashdumper_free(gpu, &dumper);
+		msm_gem_kernel_put(dumper.bo, gpu->aspace, true);
 	}
 
 	a6xx_get_debugbus(gpu, a6xx_state);
Signature · 6 lines
2.18.0

_______________________________________________
Freedreno mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/freedreno