exynos5: allow bigger BL2 (u-boot.bin)

PATCH New Guillaume GARDET 4 participants 15 messages Nov 19, 2018 – Dec 27, 2018

Subsystems (2)

Arm (32-bit) Arm Samsung Exynos

lore

Share & tools

lore

Guillaume GARDET

author

2018-11-19 16:45 UTC #0 lore raw

PATCH 1/1 exynos5: allow bigger BL2 (u-boot.bin)

This patch allows SPL to load a bigger BL2 (u-boot.bin).
This is needed for and has been tested on Arndale board, as u-boot.bin is now bigger than 512K with GCC8.

Signed-off-by Guillaume GARDET <[email protected]>

Cc Minkyu Kang <[email protected]>

Cc Tom Rini <[email protected]>

---
 include/configs/exynos5-common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

include/configs/exynos5-common.h +1 -1

index cd2a9046af..7da4be5ca8 100644
@@ -89,7 +89,7 @@
 /* Configuration of BL1, BL2, ENV Blocks on mmc */
 #define CONFIG_RES_BLOCK_SIZE	(512)
 #define CONFIG_BL1_SIZE	(16 << 10) /*16 K reserved for BL1*/
-#define CONFIG_BL2_SIZE	(512UL << 10UL) /* 512 KB */
+#define CONFIG_BL2_SIZE	(512UL << 11UL) /* 1 MB */
 #define CONFIG_ENV_SIZE	(16 << 10) /* 16 KB */
 
 #define CONFIG_BL1_OFFSET	(CONFIG_RES_BLOCK_SIZE + CONFIG_SEC_FW_SIZE)

Signature · 1 line

2.19.1

Tom Rini

2018-11-19 16:46 UTC #1 lore raw

PATCH 1/1 exynos5: allow bigger BL2 (u-boot.bin)

Quoted 11 lines · Guillaume GARDET

This patch allows SPL to load a bigger BL2 (u-boot.bin).
This is needed for and has been tested on Arndale board, as u-boot.bin is now bigger than 512K with GCC8.
Signed-off-by Guillaume GARDET <[email protected]>
Cc Minkyu Kang <[email protected]>
Cc Tom Rini <[email protected]>
---
 include/configs/exynos5-common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Are these platforms using thumb2 to build? Were it not for some early Cortex-A platforms with thumb2 errata I'd be strongly inclined to do a global switch to making that option default.

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181119/41215b46/attachment.sig>

Guillaume GARDET

author

2018-11-19 16:56 UTC #2 lore raw

----- Tom Rini <[email protected]> a écrit :

Quoted 14 lines · Guillaume GARDET

Quoted 5 lines
This patch allows SPL to load a bigger BL2 (u-boot.bin).
This is needed for and has been tested on Arndale board, as u-boot.bin is now bigger than 512K with GCC8.
Quoted 7 lines
Signed-off-by Guillaume GARDET <[email protected]>
Cc Minkyu Kang <[email protected]>
Cc Tom Rini <[email protected]>
---
 include/configs/exynos5-common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Quoted 3 lines

Are these platforms using thumb2 to build? Were it not for some early Cortex-A platforms with thumb2 errata I'd be strongly inclined to do a global switch to making that option default.

No, they are not using thumb2:
# CONFIG_SYS_THUMB_BUILD is not set
# CONFIG_SPL_SYS_THUMB_BUILD is not set

Guillaume

Quoted 3 lines

Signature · 2 lines
-- 
Tom

Tom Rini

2018-11-19 16:57 UTC #3 lore raw

Quoted 16 lines · Guillaume GARDET

----- Tom Rini <[email protected]> a écrit :
Quoted 14 lines · Guillaume GARDET
Quoted 12 lines
This patch allows SPL to load a bigger BL2 (u-boot.bin).
This is needed for and has been tested on Arndale board, as u-boot.bin is now bigger than 512K with GCC8.
Signed-off-by Guillaume GARDET <[email protected]>
Cc Minkyu Kang <[email protected]>
Cc Tom Rini <[email protected]>
---
 include/configs/exynos5-common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Quoted 7 lines

Quoted 3 lines
Are these platforms using thumb2 to build? Were it not for some early Cortex-A platforms with thumb2 errata I'd be strongly inclined to do a global switch to making that option default.
No, they are not using thumb2:
# CONFIG_SYS_THUMB_BUILD is not set
# CONFIG_SPL_SYS_THUMB_BUILD is not set

I would suggest switching that on instead then. I'm always wary of changing stuff on the flash layout.

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181119/b5acf675/attachment.sig>

Guillaume GARDET

author

2018-11-19 17:03 UTC #4 lore raw

----- Tom Rini <[email protected]> a écrit :

Quoted 21 lines · Guillaume GARDET

Quoted 20 lines
----- Tom Rini <[email protected]> a écrit :
Quoted 17 lines · Guillaume GARDET
Quoted 5 lines
This patch allows SPL to load a bigger BL2 (u-boot.bin).
This is needed for and has been tested on Arndale board, as u-boot.bin is now bigger than 512K with GCC8.
Quoted 7 lines
Signed-off-by Guillaume GARDET <[email protected]>
Cc Minkyu Kang <[email protected]>
Cc Tom Rini <[email protected]>
---
 include/configs/exynos5-common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Are these platforms using thumb2 to build? Were it not for some early Cortex-A platforms with thumb2 errata I'd be strongly inclined to do a global switch to making that option default.

Quoted 6 lines

Quoted 3 lines
No, they are not using thumb2:
# CONFIG_SYS_THUMB_BUILD is not set
# CONFIG_SPL_SYS_THUMB_BUILD is not set
I would suggest switching that on instead then. I'm always wary of changing stuff on the flash layout.

I tested thumb2 for SPL and u-boot.bin on arndale and it does boot properly. u-boot.bin is 397KB with thumb2, which is OK.

Should I make the switch for Arndale board only, or on a bigger range?

Guillaume

Quoted 3 lines

Signature · 2 lines
-- 
Tom

Tom Rini

2018-11-19 17:18 UTC #5 lore raw

Quoted 26 lines · Guillaume GARDET

----- Tom Rini <[email protected]> a écrit :
Quoted 25 lines · Guillaume GARDET
Quoted 23 lines
----- Tom Rini <[email protected]> a écrit :
Quoted 14 lines · Guillaume GARDET
Quoted 5 lines
This patch allows SPL to load a bigger BL2 (u-boot.bin).
This is needed for and has been tested on Arndale board, as u-boot.bin is now bigger than 512K with GCC8.
Quoted 7 lines
Signed-off-by Guillaume GARDET <[email protected]>
Cc Minkyu Kang <[email protected]>
Cc Tom Rini <[email protected]>
---
 include/configs/exynos5-common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 3 lines
Are these platforms using thumb2 to build? Were it not for some early Cortex-A platforms with thumb2 errata I'd be strongly inclined to do a global switch to making that option default.
No, they are not using thumb2:
# CONFIG_SYS_THUMB_BUILD is not set
# CONFIG_SPL_SYS_THUMB_BUILD is not set

Quoted 7 lines

Quoted 2 lines
I would suggest switching that on instead then. I'm always wary of changing stuff on the flash layout.
I tested thumb2 for SPL and u-boot.bin on arndale and it does boot properly. u-boot.bin is 397KB with thumb2, which is OK.
Should I make the switch for Arndale board only, or on a bigger range?

I'd go ahead and switch all exynos platforms. My recollection is it's really only very old / early Cortex-A platforms with issues and I'm pretty sure we either have the appropriate errata enabled or they've all been discarded at this point in time.

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181119/2d89500b/attachment.sig>

Guillaume GARDET

author

2018-11-20 13:15 UTC #6 lore raw

PATCH 1/1 exynos: imply SYS_THUMB_BUILD

This patch allows smaller binaries.
This is needed for and has been tested on Arndale board, as u-boot.bin is now bigger than the 512K load limit, with GCC8, without thumb mode.

Signed-off-by Guillaume GARDET <[email protected]>

Cc Albert Aribaud <[email protected]>

Cc Minkyu Kang <[email protected]>

Cc Tom Rini <[email protected]>

---
 arch/arm/Kconfig | 1 +
 1 file changed, 1 insertion(+)

arch/arm/Kconfig +1 -0

index f5d4d39683..1ccd53fd0b 100644
@@ -607,6 +607,7 @@ config ARCH_EXYNOS
 	select DM_SPI
 	select DM_SPI_FLASH
 	select SPI
+	imply SYS_THUMB_BUILD
 	imply CMD_DM
 	imply FAT_WRITE

Signature · 1 line

2.19.1

Lukasz Majewski

2018-11-26 23:32 UTC #7 lore raw

PATCH 1/1 exynos: imply SYS_THUMB_BUILD

Hi Guillaume,

Quoted 5 lines

This patch allows smaller binaries.
This is needed for and has been tested on Arndale board, as u-boot.bin is now bigger than the 512K load limit, with GCC8, without thumb mode.

Acked-by Lukasz Majewski <[email protected]>

Quoted 14 lines

Signed-off-by Guillaume GARDET <[email protected]>
Cc Albert Aribaud <[email protected]>
Cc Minkyu Kang <[email protected]>
Cc Tom Rini <[email protected]>
---
 arch/arm/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/Kconfig +0 -0
index f5d4d39683..1ccd53fd0b 100644

arch/arm/Kconfig config ARCH_EXYNOS · line 613

Quoted 7 lines

arch/arm/Kconfig +1 -0

@@ -607,6 +607,7 @@ config ARCH_EXYNOS
 	select DM_SPI
 	select DM_SPI_FLASH
 	select SPI
+	imply SYS_THUMB_BUILD
 	imply CMD_DM
 	imply FAT_WRITE

Best regards,

Lukasz Majewski

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181127/6be480c3/attachment.sig>

Guillaume GARDET

author

2018-12-03 19:57 UTC #8 lore raw

[U-Boot] Re : Re: [PATCH] exynos: imply SYS_THUMB_BUILD

Hi,

not sure through which tree it should go and who should take care of it?

Guillaume

----- Lukasz Majewski <[email protected]> a écrit :

Quoted 44 lines

Hi Guillaume,
Quoted 5 lines
This patch allows smaller binaries.
This is needed for and has been tested on Arndale board, as u-boot.bin is now bigger than the 512K load limit, with GCC8, without thumb mode.
Acked-by Lukasz Majewski <[email protected]>
Quoted 14 lines
Signed-off-by Guillaume GARDET <[email protected]>
Cc Albert Aribaud <[email protected]>
Cc Minkyu Kang <[email protected]>
Cc Tom Rini <[email protected]>
---
 arch/arm/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/Kconfig +0 -0
index f5d4d39683..1ccd53fd0b 100644
arch/arm/Kconfig config ARCH_EXYNOS · line 613
Quoted 7 lines
arch/arm/Kconfig +1 -0
@@ -607,6 +607,7 @@ config ARCH_EXYNOS
 	select DM_SPI
 	select DM_SPI_FLASH
 	select SPI
+	imply SYS_THUMB_BUILD
 	imply CMD_DM
 	imply FAT_WRITE
 
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de

Tom Rini

2018-12-03 20:23 UTC #9 lore raw

[U-Boot] Re : Re: [PATCH] exynos: imply SYS_THUMB_BUILD

Quoted 4 lines · Guillaume GARDET

Hi,
not sure through which tree it should go and who should take care of it?

I will likely pick this up "soon" if I don't seen an overall Samsung PR, thanks!

Quoted 49 lines

Guillaume
----- Lukasz Majewski <[email protected]> a écrit :
Quoted 44 lines
Hi Guillaume,
Quoted 5 lines
This patch allows smaller binaries.
This is needed for and has been tested on Arndale board, as u-boot.bin is now bigger than the 512K load limit, with GCC8, without thumb mode.
Acked-by Lukasz Majewski <[email protected]>
Quoted 14 lines
Signed-off-by Guillaume GARDET <[email protected]>
Cc Albert Aribaud <[email protected]>
Cc Minkyu Kang <[email protected]>
Cc Tom Rini <[email protected]>
---
 arch/arm/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/Kconfig +0 -0
index f5d4d39683..1ccd53fd0b 100644
arch/arm/Kconfig config ARCH_EXYNOS · line 613
Quoted 7 lines
arch/arm/Kconfig +1 -0
@@ -607,6 +607,7 @@ config ARCH_EXYNOS
 	select DM_SPI
 	select DM_SPI_FLASH
 	select SPI
+	imply SYS_THUMB_BUILD
 	imply CMD_DM
 	imply FAT_WRITE
 
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181203/72c8a2ac/attachment.sig>

Minkyu Kang

Acked-by

2018-12-04 04:47 UTC #10 lore raw

[U-Boot] Re : Re: [PATCH] exynos: imply SYS_THUMB_BUILD

Dear Tom,

Quoted 10 lines · Tom Rini

Quoted 4 lines · Guillaume GARDET
Hi,
not sure through which tree it should go and who should take care of it?
I will likely pick this up "soon" if I don't seen an overall Samsung PR, thanks!

It's OK to take this patch by you.

Acked-by Minkyu Kang <[email protected]>

Thanks,
Minkyu Kang.

Guillaume Gardet

author

2018-12-21 13:57 UTC #11 lore raw

[U-Boot] Re : Re: [PATCH] exynos: imply SYS_THUMB_BUILD

Hi Tom,

Le 04/12/2018 à 05:47, Minkyu Kang a écrit :

Quoted 7 lines

Dear Tom,
Quoted 4 lines · Tom Rini
Quoted 2 lines · Guillaume GARDET
Hi,

Quoted 7 lines

Quoted 4 lines
Quoted 1 line
not sure through which tree it should go and who should take care of it?
I will likely pick this up "soon" if I don't seen an overall Samsung PR, thanks!
It's OK to take this patch by you.
Acked-by Minkyu Kang <[email protected]>

It seems you missed it for -rc2. Could you take it before the release, please?

Thanks,

Guillaume

Quoted 4 lines

Thanks,
Minkyu Kang.

Minkyu Kang

2018-12-27 00:47 UTC #12 lore raw

[U-Boot] Re : Re: [PATCH] exynos: imply SYS_THUMB_BUILD

Hi,

Quoted 14 lines · Guillaume Gardet

Hi Tom,
Le 04/12/2018 à 05:47, Minkyu Kang a écrit :
Quoted 11 lines
Dear Tom,
Quoted 8 lines · Tom Rini
Quoted 3 lines · Guillaume GARDET
Hi,
not sure through which tree it should go and who should take care of it?
I will likely pick this up "soon" if I don't seen an overall Samsung PR, thanks!

Quoted 7 lines

Quoted 3 lines
It's OK to take this patch by you.
Acked-by Minkyu Kang <[email protected]>
It seems you missed it for -rc2. Could you take it before the release, please?

applied to u-boot-samsung.

Thanks,
Minkyu Kang.

Lukasz Majewski

2018-12-03 22:07 UTC #13 lore raw

PATCH 1/1 exynos: imply SYS_THUMB_BUILD

In reply to Guillaume GARDET

Hi Guillaume,

Quoted 4 lines

Hi,
not sure through which tree it should go and who should take care of it?

Please rebase on top of u-boot/master branch.

Then Minkyu will take the patch to his tree.

Quoted 50 lines

Guillaume
----- Lukasz Majewski <[email protected]> a écrit :
Quoted 45 lines
Hi Guillaume,
Quoted 5 lines
This patch allows smaller binaries.
This is needed for and has been tested on Arndale board, as u-boot.bin is now bigger than the 512K load limit, with GCC8, without thumb mode.
Acked-by Lukasz Majewski <[email protected]>
Quoted 14 lines
Signed-off-by Guillaume GARDET <[email protected]>
Cc Albert Aribaud <[email protected]>
Cc Minkyu Kang <[email protected]>
Cc Tom Rini <[email protected]>
---
 arch/arm/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/Kconfig +0 -0
index f5d4d39683..1ccd53fd0b 100644
arch/arm/Kconfig config ARCH_EXYNOS · line 613
Quoted 7 lines
arch/arm/Kconfig +1 -0
@@ -607,6 +607,7 @@ config ARCH_EXYNOS
 	select DM_SPI
 	select DM_SPI_FLASH
 	select SPI
+	imply SYS_THUMB_BUILD
 	imply CMD_DM
 	imply FAT_WRITE
 
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang
Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email:
lukma at denx.de

Best regards,

Lukasz Majewski

Guillaume GARDET

author

2018-12-04 07:57 UTC #14 lore raw

[U-Boot] Re : Re: [PATCH] exynos: imply SYS_THUMB_BUILD

----- Lukasz Majewski <[email protected]> a écrit :

Quoted 8 lines

Hi Guillaume,
Quoted 4 lines
Hi,
not sure through which tree it should go and who should take care of it?
Please rebase on top of u-boot/master branch.

No need, it applies just fine.

Quoted 2 lines

Then Minkyu will take the patch to his tree.

Tom should take it (see Minkyu e-mail).

Thanks,
Guillaume

Quoted 64 lines

Quoted 51 lines
Guillaume
----- Lukasz Majewski <[email protected]> a écrit :
Quoted 45 lines
Hi Guillaume,
Quoted 5 lines
This patch allows smaller binaries.
This is needed for and has been tested on Arndale board, as u-boot.bin is now bigger than the 512K load limit, with GCC8, without thumb mode.
Acked-by Lukasz Majewski <[email protected]>
Quoted 14 lines
Signed-off-by Guillaume GARDET <[email protected]>
Cc Albert Aribaud <[email protected]>
Cc Minkyu Kang <[email protected]>
Cc Tom Rini <[email protected]>
---
 arch/arm/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/Kconfig +0 -0
index f5d4d39683..1ccd53fd0b 100644
arch/arm/Kconfig config ARCH_EXYNOS · line 613
Quoted 7 lines
arch/arm/Kconfig +1 -0
@@ -607,6 +607,7 @@ config ARCH_EXYNOS
 	select DM_SPI
 	select DM_SPI_FLASH
 	select SPI
+	imply SYS_THUMB_BUILD
 	imply CMD_DM
 	imply FAT_WRITE
 
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang
Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email:
lukma at denx.de
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de