Skip to contentSkip to conversation

tools/libxl: fix boot of HVM domain with Xenstore-stubdom

PATCH In review Juergen Gross 2 participants 2 messages Dec 4, 2018 – Dec 6, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tools/libxl: fix boot of HVM domain with Xenstore-stubdom

The Xenstore domid isn't set for HVM domains. This will result in failure when booting a HVM domain on a system with Xenstore not running in dom0.

Same applies for console domid, so set both.

This is broken since commit a2d9a6fa1fcd ("tools/libxenctrl: use new xenforeignmemory API to seed grant table").

---
 tools/libxl/libxl_dom.c | 2 ++
 1 file changed, 2 insertions(+)
tools/libxl/libxl_dom.c +2 -0
index 598af71562..6160991af3 100644
@@ -1289,6 +1289,8 @@ int libxl__build_hvm(libxl__gc *gc, uint32_t domid,
     dom->vga_hole_size = device_model ? LIBXL_VGA_HOLE_SIZE : 0;
     dom->device_model = device_model;
     dom->max_vcpus = info->max_vcpus;
+    dom->console_domid = state->console_domid;
+    dom->xenstore_domid = state->store_domid;
 
     rc = libxl__domain_device_construct_rdm(gc, d_config,
                                             info->u.hvm.rdm_mem_boundary_memkb*1024,
Signature · 7 lines
2.16.4


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Juergen Gross

The Xenstore domid isn't set for HVM domains. This will result in failure when booting a HVM domain on a system with Xenstore not running in dom0.

Same applies for console domid, so set both.

This is broken since commit a2d9a6fa1fcd ("tools/libxenctrl: use new xenforeignmemory API to seed grant table").

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel