drm/i915: Dial down workaround debug messages

PATCH In review Tvrtko Ursulin 3 participants 5 messages Dec 4, 2018 – Dec 5, 2018

Subsystems (2)

DRM drivers Intel i915

lore

Share & tools

lore

Tvrtko Ursulin

author

2018-12-04 17:15 UTC #0 lore raw

PATCH 1/1 drm/i915: Dial down workaround debug messages

From: Tvrtko Ursulin <[email protected]>

For selftests like live_hangcheck, which does thousands of reset per second, it is too verbose to log every time we re-apply the workarounds.

Remove those messages since, coupled with the dedicated selftest, it is sufficient to only log the number of recorded workarounds at init time.

Signed-off-by Tvrtko Ursulin <[email protected]>

---
 drivers/gpu/drm/i915/intel_workarounds.c | 4 ----
 1 file changed, 4 deletions(-)

drivers/gpu/drm/i915/intel_workarounds.c +0 -4

index 4f41e326f3f3..6bcac78a9c36 100644
@@ -955,8 +955,6 @@ wa_list_apply(struct drm_i915_private *dev_priv, const struct i915_wa_list *wal)
 
 	intel_uncore_forcewake_put__locked(dev_priv, fw);
 	spin_unlock_irqrestore(&dev_priv->uncore.lock, flags);
-
-	DRM_DEBUG_DRIVER("Applied %u %s workarounds\n", wal->count, wal->name);
 }
 
 void intel_gt_apply_workarounds(struct drm_i915_private *dev_priv)

@@ -1126,8 +1124,6 @@ void intel_engine_apply_whitelist(struct intel_engine_cs *engine)
 	for (; i < RING_MAX_NONPRIV_SLOTS; i++)
 		I915_WRITE(RING_FORCE_TO_NONPRIV(base, i),
 			   i915_mmio_reg_offset(RING_NOPID(base)));
-
-	DRM_DEBUG_DRIVER("Applied %u %s workarounds\n", wal->count, wal->name);
 }
 
 static void rcs_engine_wa_init(struct intel_engine_cs *engine)

Signature · 6 lines

2.19.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Chris Wilson

Reviewed-by on v1 1/1

2018-12-04 17:20 UTC #1 lore raw

Quoting Tvrtko Ursulin (2018-12-04 17:15:30)

Quoted 10 lines

From: Tvrtko Ursulin <[email protected]>
For selftests like live_hangcheck, which does thousands of reset per second, it is too verbose to log every time we re-apply the workarounds.
Remove those messages since, coupled with the dedicated selftest, it is sufficient to only log the number of recorded workarounds at init time.
Signed-off-by Tvrtko Ursulin <[email protected]>
Suggested-by Chris Wilson <[email protected]>

Ta,

Reviewed-by Chris Wilson <[email protected]>

-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Patchwork

2018-12-04 18:35 UTC #2 lore raw

✓ Fi.CI.BAT: success for drm/i915: Dial down workaround debug messages

In reply to Tvrtko Ursulin

== Series Details ==

Series: drm/i915: Dial down workaround debug messages
URL : https://patchwork.freedesktop.org/series/53490/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5260 -> Patchwork_11011
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/53490/revisions/1/mbox/

Known issues
------------

Here are the changes found in Patchwork_11011 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_mmap_gtt@basic-small-copy:
- fi-glk-dsi: PASS -> INCOMPLETE [fdo#103359] / [k.org#198133]

* igt@i915_selftest@live_hangcheck:
- fi-cfl-8109u: PASS -> INCOMPLETE [fdo#106070]

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- fi-blb-e6850: NOTRUN -> INCOMPLETE [fdo#107718]

#### Possible fixes ####

* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: INCOMPLETE [fdo#107718] -> PASS

* igt@gem_exec_suspend@basic-s4-devices:
- fi-ivb-3520m: FAIL [fdo#108880] -> PASS

[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#106070]: https://bugs.freedesktop.org/show_bug.cgi?id=106070
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108880]: https://bugs.freedesktop.org/show_bug.cgi?id=108880
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133

Participating hosts (50 -> 45)
------------------------------

Missing (5): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600

Build changes
-------------

* Linux: CI_DRM_5260 -> Patchwork_11011

CI_DRM_5260: e1c9e326ad6f018c4eb8c534b37e8556b18d9997 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4740: dd8de0efa64e50bc06c2882a0028d98ad870e752 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_11011: 3266e74687f7e1c393556f62e498bb4b416bece4 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

3266e74687f7 drm/i915: Dial down workaround debug messages

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_11011/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Chris Wilson

2018-12-04 18:59 UTC #3 lore raw

Re: ✓ Fi.CI.BAT: success for drm/i915: Dial down workaround debug messages

Quoting Patchwork (2018-12-04 18:35:08)

Quoted 11 lines

== Series Details ==
Series: drm/i915: Dial down workaround debug messages
URL : https://patchwork.freedesktop.org/series/53490/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5260 -> Patchwork_11011
====================================================

Quoted 6 lines

Summary
-------
**SUCCESS**
No regressions found.

Applied before Tomi notices and complains. Thanks, -Chris
_______________________________________________
Intel-gfx mailing list [email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Patchwork

2018-12-05 05:42 UTC #4 lore raw

✓ Fi.CI.IGT: success for drm/i915: Dial down workaround debug messages

In reply to Tvrtko Ursulin

== Series Details ==

Series: drm/i915: Dial down workaround debug messages
URL : https://patchwork.freedesktop.org/series/53490/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5260_full -> Patchwork_11011_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Known issues
------------

Here are the changes found in Patchwork_11011_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_cpu_reloc@full:
- shard-skl: PASS -> TIMEOUT [fdo#108248]

* igt@gem_ctx_switch@basic-all-heavy:
- shard-apl: PASS -> INCOMPLETE [fdo#103927]

* igt@kms_available_modes_crc@available_mode_test_crc:
- shard-apl: PASS -> FAIL [fdo#106641]

* igt@kms_busy@extended-modeset-hang-newfb-render-a:
- shard-skl: PASS -> DMESG-WARN [fdo#107956]

* igt@kms_cursor_crc@cursor-256x256-sliding:
- shard-skl: PASS -> FAIL [fdo#103232]

* igt@kms_cursor_crc@cursor-64x64-random:
- {shard-iclb}: NOTRUN -> FAIL [fdo#103232] +1

* igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-untiled:
- shard-skl: PASS -> FAIL [fdo#103184]

* igt@kms_fbcon_fbt@fbc-suspend:
- shard-skl: PASS -> FAIL [fdo#103833] / [fdo#105682]

* igt@kms_flip@flip-vs-expired-vblank:
- shard-skl: PASS -> FAIL [fdo#105363]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render:
- {shard-iclb}: PASS -> DMESG-FAIL [fdo#107724]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
- {shard-iclb}: PASS -> FAIL [fdo#103167] +4
- shard-apl: PASS -> FAIL [fdo#103167] +1

* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: PASS -> FAIL [fdo#107815] / [fdo#108145]

* igt@kms_plane_multiple@atomic-pipe-c-tiling-x:
- {shard-iclb}: PASS -> FAIL [fdo#103166] +1

* igt@kms_plane_multiple@atomic-pipe-c-tiling-y:
- shard-apl: PASS -> FAIL [fdo#103166]

* {igt@kms_rotation_crc@multiplane-rotation-cropping-top}:
- {shard-iclb}: PASS -> DMESG-WARN [fdo#107724] +2

* igt@kms_setmode@basic:
- shard-apl: PASS -> FAIL [fdo#99912]

* igt@pm_rpm@pm-caching:
- shard-skl: PASS -> INCOMPLETE [fdo#107807]

* igt@pm_rpm@universal-planes:
- {shard-iclb}: PASS -> DMESG-WARN [fdo#108654] / [fdo#108756]

* {igt@runner@aborted}:
- {shard-iclb}: NOTRUN -> FAIL [fdo#108654] / [fdo#108756] / [fdo#108928]

#### Possible fixes ####

* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
- shard-kbl: DMESG-WARN [fdo#107956] -> PASS

* igt@kms_color@pipe-b-degamma:
- shard-apl: FAIL [fdo#104782] -> PASS

* igt@kms_cursor_crc@cursor-128x128-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS

* igt@kms_cursor_crc@cursor-64x64-dpms:
- shard-apl: FAIL [fdo#103232] -> PASS +1

* igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-xtiled:
- shard-skl: FAIL [fdo#103184] -> PASS

* igt@kms_flip_tiling@flip-to-x-tiled:
- {shard-iclb}: FAIL [fdo#108134] -> PASS

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-apl: FAIL [fdo#103167] -> PASS

* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-blt:
- {shard-iclb}: FAIL [fdo#103167] -> PASS +2

* {igt@kms_plane@pixel-format-pipe-c-planes-source-clamping}:
- shard-apl: FAIL -> PASS

* igt@kms_plane@plane-position-covered-pipe-a-planes:
- shard-apl: FAIL [fdo#103166] -> PASS +1
- {shard-iclb}: FAIL [fdo#103166] -> PASS +1

* igt@kms_plane@plane-position-covered-pipe-b-planes:
- shard-glk: FAIL [fdo#103166] -> PASS +2

* igt@kms_psr@no_drrs:
- {shard-iclb}: FAIL [fdo#108341] -> PASS

* {igt@kms_rotation_crc@multiplane-rotation-cropping-top}:
- shard-kbl: DMESG-WARN [fdo#105604] -> PASS

* igt@kms_setmode@basic:
- shard-hsw: FAIL [fdo#99912] -> PASS

* igt@pm_rpm@gem-pread:
- {shard-iclb}: DMESG-WARN [fdo#108654] -> PASS

#### Warnings ####

* igt@i915_selftest@live_contexts:
- {shard-iclb}: DMESG-FAIL [fdo#108569] -> INCOMPLETE [fdo#108315]

* igt@kms_cursor_crc@cursor-64x21-onscreen:
- {shard-iclb}: FAIL [fdo#103232] -> DMESG-WARN [fdo#107724] / [fdo#108336]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff:
- {shard-iclb}: FAIL [fdo#103167] -> DMESG-FAIL [fdo#107724]

* igt@pm_backlight@fade_with_suspend:
- {shard-iclb}: FAIL [fdo#107847] -> DMESG-FAIL [fdo#107724]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

Participating hosts (7 -> 7)
------------------------------

No changes in participating hosts

Build changes
-------------

* Linux: CI_DRM_5260 -> Patchwork_11011

== Logs ==