Skip to contentSkip to conversation

net/e1000: xstat RXERRC statictic register added.

PATCH In review Leonid Myravjev 2 participants 2 messages Dec 5, 2018 – Dec 13, 2018 Network drivers

lore
Share & tools
lore

Leonid Myravjev

author
#0 lore raw

PATCH 1/1 net/e1000: xstat RXERRC statictic register added.

Signed-off-by Leonid Myravjev <[email protected]>
---
 drivers/net/e1000/igb_ethdev.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/e1000/igb_ethdev.c +1 -0
index d9d29d22f..ebc242cd9 100644
@@ -458,6 +458,7 @@ struct rte_igb_xstats_name_off {
 static const struct rte_igb_xstats_name_off rte_igb_stats_strings[] = {
 	{"rx_crc_errors", offsetof(struct e1000_hw_stats, crcerrs)},
 	{"rx_align_errors", offsetof(struct e1000_hw_stats, algnerrc)},
+	{"rx_rx_errors", offsetof(struct e1000_hw_stats, rxerrc)},
 	{"rx_symbol_errors", offsetof(struct e1000_hw_stats, symerrs)},
 	{"rx_missed_packets", offsetof(struct e1000_hw_stats, mpc)},
 	{"tx_single_collision_packets", offsetof(struct e1000_hw_stats, scc)},
Signature · 1 line
2.17.1
#1 lore raw
Quoted 19 lines

-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of Leonid Myravjev
Sent: Wednesday, December 5, 2018 8:35 PM
To: Lu, Wenzhuo <[email protected]>
Cc: [email protected]; Leonid Myravjev <[email protected]>
Subject: [dpdk-dev] [PATCH] net/e1000: xstat RXERRC statictic register added.

Signed-off-by Leonid Myravjev <[email protected]>
---
 drivers/net/e1000/igb_ethdev.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/e1000/igb_ethdev.c +0 -0
index d9d29d22f..ebc242cd9 100644

drivers/net/e1000/igb_ethdev.c struct rte_igb_xstats_name_off { static const struct · line 461

Quoted 4 lines
drivers/net/e1000/igb_ethdev.c +1 -0
@@ -458,6 +458,7 @@ struct rte_igb_xstats_name_off {  static const struct
 rte_igb_xstats_name_off rte_igb_stats_strings[] = {
 	{"rx_crc_errors", offsetof(struct e1000_hw_stats, crcerrs)},
 	{"rx_align_errors", offsetof(struct e1000_hw_stats, algnerrc)},
+	{"rx_rx_errors", offsetof(struct e1000_hw_stats, rxerrc)},

I have no objection for this change, I just feel add all missing field (that be read from register in igb_read_stats_registers) in this array makes the patch complete. Would do you think?

Quoted 5 lines
drivers/net/e1000/igb_ethdev.c +0 -1
 	{"rx_symbol_errors", offsetof(struct e1000_hw_stats, symerrs)},
 	{"rx_missed_packets", offsetof(struct e1000_hw_stats, mpc)},
 	{"tx_single_collision_packets", offsetof(struct e1000_hw_stats, scc)},
--

2.17.1