Skip to contentSkip to conversation

cpufreq: ia64: Remove unused header files

PATCH Applied Yangtao Li 2 participants 2 messages Dec 5, 2018 – Dec 17, 2018 CPU frequency scaling framework

lore
Share & tools
lore

Yangtao Li

author
#0 lore raw

PATCH v2 1/1 cpufreq: ia64: Remove unused header files

seq_file.h does not need to be included, so remove it. Moreover deleted a line of meaningless return and some useless blank lines. In a function whose return type is void, returning on the last line is not required.

---
changes in v2:
-revert modify of MODULE_
-delete some blank lines

---
 drivers/cpufreq/ia64-acpi-cpufreq.c | 5 -----
 1 file changed, 5 deletions(-)
drivers/cpufreq/ia64-acpi-cpufreq.c +0 -5
index dd5440d3372d..80c5bf590acb 100644
@@ -16,7 +16,6 @@
 #include <linux/init.h>
 #include <linux/cpufreq.h>
 #include <linux/proc_fs.h>
-#include <linux/seq_file.h>
 #include <asm/io.h>
 #include <linux/uaccess.h>
 #include <asm/pal.h>
@@ -28,7 +27,6 @@ MODULE_AUTHOR("Venkatesh Pallipadi");
 MODULE_DESCRIPTION("ACPI Processor P-States Driver");
 MODULE_LICENSE("GPL");
 
-
 struct cpufreq_acpi_io {
 	struct acpi_processor_performance	acpi_data;
 	unsigned int				resume;
@@ -348,10 +346,7 @@ acpi_cpufreq_exit (void)
 	pr_debug("acpi_cpufreq_exit\n");
 
 	cpufreq_unregister_driver(&acpi_cpufreq_driver);
-	return;
 }
 
-
 late_initcall(acpi_cpufreq_init);
 module_exit(acpi_cpufreq_exit);
-
Signature · 1 line
2.17.0
#1 lore raw
Quoted 36 lines · CET Yangtao Li

seq_file.h does not need to be included, so remove it. Moreover deleted a line of meaningless return and some useless blank lines. In a function whose return type is void, returning on the last line is not required.

---
changes in v2:

(quoted diff) +0 -3
-revert modify of MODULE_
-delete some blank lines
---
 drivers/cpufreq/ia64-acpi-cpufreq.c | 5 -----
 1 file changed, 5 deletions(-)
drivers/cpufreq/ia64-acpi-cpufreq.c +0 -2
index dd5440d3372d..80c5bf590acb 100644
@@ -16,7 +16,6 @@
 #include <linux/init.h>
 #include <linux/cpufreq.h>
 #include <linux/proc_fs.h>
-#include <linux/seq_file.h>
 #include <asm/io.h>
 #include <linux/uaccess.h>
 #include <asm/pal.h>
@@ -28,7 +27,6 @@ MODULE_AUTHOR("Venkatesh Pallipadi");
 MODULE_DESCRIPTION("ACPI Processor P-States Driver");
 MODULE_LICENSE("GPL");
 
-
 struct cpufreq_acpi_io {
 	struct acpi_processor_performance	acpi_data;
 	unsigned int				resume;

drivers/cpufreq/ia64-acpi-cpufreq.c acpi_cpufreq_exit (void) · line 357

Quoted 10 lines
drivers/cpufreq/ia64-acpi-cpufreq.c +0 -3
@@ -348,10 +346,7 @@ acpi_cpufreq_exit (void)
 	pr_debug("acpi_cpufreq_exit\n");
 
 	cpufreq_unregister_driver(&acpi_cpufreq_driver);
-	return;
 }
 
-
 late_initcall(acpi_cpufreq_init);
 module_exit(acpi_cpufreq_exit);
-

Applied, thanks!