drm/i915/icl: Document Wa_1606682166

PATCH In review Tvrtko Ursulin 2 participants 4 messages Dec 5, 2018 – Dec 6, 2018

Subsystems (2)

DRM drivers Intel i915

lore

Share & tools

lore

Tvrtko Ursulin

author

2018-12-05 19:04 UTC #0 lore raw

PATCH 1/1 drm/i915/icl: Document Wa_1606682166

From: Tvrtko Ursulin <[email protected]>

Commit 71ffd49cc9b9 ("drm/i915/icl:Add Wa_1606682166") added the workaround but did not put it in comment, which looks like should be the usual process for these things. Add the missing comment.

Signed-off-by Tvrtko Ursulin <[email protected]>

Cc Radhakrishna Sripada <[email protected]>

Cc Anuj Phogat <[email protected]>

Cc Mika Kuoppala <[email protected]>

---
 drivers/gpu/drm/i915/intel_workarounds.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

drivers/gpu/drm/i915/intel_workarounds.c +4 -1

index 4f678c502daf..7c4c5e655d94 100644
@@ -1178,7 +1178,10 @@ static void rcs_engine_wa_init(struct intel_engine_cs *engine)
 			    PMFLUSH_GAPL3UNBLOCK |
 			    PMFLUSHDONE_LNEBLK);
 
-		/* Wa_1406609255:icl (pre-prod) */
+		/*
+		 * Wa_1406609255:icl (pre-prod): GEN7_DISABLE_DEMAND_PREFETCH
+		 * Wa_1606682166:icl: GEN7_DISABLE_SAMPLER_PREFETCH
+		 */
 		if (IS_ICL_REVID(i915, ICL_REVID_A0, ICL_REVID_B0))
 			wa_write_or(wal,
 				    GEN7_SARCHKMD,

Signature · 6 lines

2.19.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Tvrtko Ursulin

author

2018-12-05 19:06 UTC #1 lore raw

Quoted 21 lines · Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>
Commit 71ffd49cc9b9 ("drm/i915/icl:Add Wa_1606682166") added the workaround but did not put it in comment, which looks like should be the usual process for these things. Add the missing comment.
Signed-off-by Tvrtko Ursulin <[email protected]>
Cc Radhakrishna Sripada <[email protected]>
Cc Anuj Phogat <[email protected]>
Cc Mika Kuoppala <[email protected]>
---
  drivers/gpu/drm/i915/intel_workarounds.c | 5 ++++-
  1 file changed, 4 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_workarounds.c +0 -0
index 4f678c502daf..7c4c5e655d94 100644
@@ -1178,7 +1178,10 @@ static void rcs_engine_wa_init(struct intel_engine_cs *engine)
  			    PMFLUSH_GAPL3UNBLOCK |

drivers/gpu/drm/i915/intel_workarounds.c static void rcs_engine_wa_init(struct intel_engine_cs *engine) · line 1187

Quoted 10 lines

drivers/gpu/drm/i915/intel_workarounds.c +4 -1

  			    PMFLUSHDONE_LNEBLK);
 
-		/* Wa_1406609255:icl (pre-prod) */
+		/*
+		 * Wa_1406609255:icl (pre-prod): GEN7_DISABLE_DEMAND_PREFETCH
+		 * Wa_1606682166:icl: GEN7_DISABLE_SAMPLER_PREFETCH
+		 */
  		if (IS_ICL_REVID(i915, ICL_REVID_A0, ICL_REVID_B0))
  			wa_write_or(wal,
  				    GEN7_SARCHKMD,

Actually who knows how to check if this second Wa/ applies to the same steppings?

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Patchwork

2018-12-05 19:55 UTC #2 lore raw

✓ Fi.CI.BAT: success for drm/i915/icl: Document Wa_1606682166

In reply to Tvrtko Ursulin

== Series Details ==

Series: drm/i915/icl: Document Wa_1606682166
URL : https://patchwork.freedesktop.org/series/53584/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5266 -> Patchwork_11022
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/53584/revisions/1/mbox/

Known issues
------------

Here are the changes found in Patchwork_11022 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_module_load@reload:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]

* igt@kms_chamelium@common-hpd-after-suspend:
- fi-icl-u2: NOTRUN -> DMESG-FAIL [fdo#103375] / [fdo#107732] / [fdo#108070] / [fdo#108924]

* {igt@runner@aborted}:
- fi-icl-u2: NOTRUN -> FAIL [fdo#108070]
- {fi-icl-y}: NOTRUN -> FAIL [fdo#108070]

#### Possible fixes ####

* igt@gem_exec_suspend@basic-s4-devices:
- fi-ivb-3520m: FAIL [fdo#108880] -> PASS

* igt@i915_selftest@live_hangcheck:
- fi-bwr-2160: DMESG-FAIL [fdo#108735] -> PASS

#### Warnings ####

* igt@i915_selftest@live_contexts:
- {fi-icl-u3}: DMESG-FAIL [fdo#108569] -> INCOMPLETE [fdo#108315]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

Participating hosts (47 -> 45)
------------------------------

Additional (2): fi-icl-y fi-icl-u2
Missing (4): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u

Build changes
-------------

* Linux: CI_DRM_5266 -> Patchwork_11022

CI_DRM_5266: 529899779ce289fe64cd2249da1eb9bcea6a423f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4741: 5c8f89f67c7b32014bc22421e48f3c0cf4e5ca3a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_11022: 5d8ad47d217efb0cd2822c8307fb5f4c2b8ee7fa @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

5d8ad47d217e drm/i915/icl: Document Wa_1606682166

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_11022/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Patchwork

2018-12-06 02:06 UTC #3 lore raw

✓ Fi.CI.IGT: success for drm/i915/icl: Document Wa_1606682166

In reply to Tvrtko Ursulin

== Series Details ==

Series: drm/i915/icl: Document Wa_1606682166
URL : https://patchwork.freedesktop.org/series/53584/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5266_full -> Patchwork_11022_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Known issues
------------

Here are the changes found in Patchwork_11022_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_schedule@pi-ringfull-blt:
- {shard-iclb}: NOTRUN -> FAIL [fdo#103158]

* igt@gem_exec_schedule@pi-ringfull-render:
- shard-skl: NOTRUN -> FAIL [fdo#103158]

* igt@gem_softpin@noreloc-s3:
- shard-skl: PASS -> INCOMPLETE [fdo#104108] / [fdo#107773]

* igt@kms_ccs@pipe-c-crc-sprite-planes-basic:
- {shard-iclb}: NOTRUN -> FAIL [fdo#107725]

* igt@kms_chv_cursor_fail@pipe-b-128x128-right-edge:
- {shard-iclb}: PASS -> DMESG-WARN [fdo#107724] / [fdo#108336]

* igt@kms_cursor_crc@cursor-128x128-dpms:
- shard-apl: PASS -> FAIL [fdo#103232]

* igt@kms_cursor_crc@cursor-256x256-random:
- shard-glk: PASS -> FAIL [fdo#103232] +2

* igt@kms_cursor_crc@cursor-256x85-sliding:
- shard-skl: NOTRUN -> FAIL [fdo#103232] +1

* igt@kms_cursor_crc@cursor-64x64-onscreen:
- {shard-iclb}: NOTRUN -> FAIL [fdo#103232] +6

* igt@kms_cursor_crc@cursor-size-change:
- shard-skl: PASS -> FAIL [fdo#103232]

* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-glk: PASS -> FAIL [fdo#105363]

* igt@kms_flip@flip-vs-expired-vblank:
- shard-skl: PASS -> FAIL [fdo#105363]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc:
- shard-glk: PASS -> FAIL [fdo#103167] +2
- shard-apl: PASS -> FAIL [fdo#103167] +1

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
- {shard-iclb}: PASS -> FAIL [fdo#103167] +2

* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-wc:
- shard-skl: NOTRUN -> FAIL [fdo#103167] +2

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-blt:
- {shard-iclb}: PASS -> DMESG-FAIL [fdo#107724]

* igt@kms_frontbuffer_tracking@fbcpsr-stridechange:
- shard-skl: NOTRUN -> FAIL [fdo#105683]

* igt@kms_plane@pixel-format-pipe-a-planes:
- {shard-iclb}: NOTRUN -> FAIL [fdo#103166]

* {igt@kms_plane@pixel-format-pipe-a-planes-source-clamping}:
- shard-skl: NOTRUN -> DMESG-WARN [fdo#106885]
- shard-glk: PASS -> FAIL [fdo#108948]

* {igt@kms_plane@pixel-format-pipe-c-planes-source-clamping}:
- shard-apl: PASS -> FAIL [fdo#108948]

* igt@kms_plane@plane-position-covered-pipe-c-planes:
- {shard-iclb}: PASS -> FAIL [fdo#103166]

* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-skl: NOTRUN -> FAIL [fdo#107815] / [fdo#108145] +1

* igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
- shard-skl: NOTRUN -> FAIL [fdo#108145]

* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: PASS -> FAIL [fdo#107815]

* igt@kms_plane_scaling@pipe-b-scaler-with-rotation:
- {shard-iclb}: NOTRUN -> DMESG-WARN [fdo#107724]

* igt@kms_plane_scaling@pipe-c-scaler-with-pixel-format:
- {shard-iclb}: PASS -> DMESG-WARN [fdo#107724] +1

* {igt@kms_rotation_crc@multiplane-rotation-cropping-top}:
- shard-kbl: PASS -> DMESG-FAIL [fdo#108950]

* igt@kms_rotation_crc@primary-rotation-180:
- shard-skl: PASS -> FAIL [fdo#103925] / [fdo#107815]

* igt@kms_setmode@basic:
- shard-kbl: PASS -> FAIL [fdo#99912]

* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-hsw: PASS -> FAIL [fdo#104894]

* igt@pm_rpm@i2c:
- {shard-iclb}: PASS -> INCOMPLETE [fdo#108840]

#### Possible fixes ####

* igt@i915_suspend@debugfs-reader:
- shard-skl: INCOMPLETE [fdo#104108] -> PASS

* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
- shard-kbl: DMESG-WARN [fdo#107956] -> PASS

* igt@kms_color@pipe-b-legacy-gamma:
- shard-apl: FAIL [fdo#104782] -> PASS +1

* igt@kms_cursor_crc@cursor-128x128-onscreen:
- shard-apl: FAIL [fdo#103232] -> PASS

* igt@kms_cursor_crc@cursor-64x64-sliding:
- shard-glk: FAIL [fdo#103232] -> PASS +2

* igt@kms_cursor_legacy@long-nonblocking-modeset-vs-cursor-atomic:
- {shard-iclb}: INCOMPLETE -> PASS

* igt@kms_draw_crc@draw-method-xrgb8888-mmap-gtt-ytiled:
- {shard-iclb}: WARN [fdo#108336] -> PASS

* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-skl: FAIL [fdo#105363] -> PASS

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-apl: FAIL [fdo#103167] -> PASS

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt:
- shard-skl: FAIL [fdo#103167] -> PASS

* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-move:
- shard-glk: FAIL [fdo#103167] -> PASS +3

* igt@kms_frontbuffer_tracking@fbc-2p-rte:
- shard-glk: FAIL [fdo#103167] / [fdo#105682] -> PASS

* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-pwrite:
- {shard-iclb}: DMESG-FAIL [fdo#107724] -> PASS +10

* igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-mmap-gtt:
- shard-skl: FAIL [fdo#103167] / [fdo#105682] -> PASS

* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-pwrite:
- {shard-iclb}: DMESG-WARN [fdo#107724] / [fdo#108336] -> PASS +13

* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-fullscreen:
- {shard-iclb}: FAIL [fdo#103167] -> PASS +3

* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
- shard-skl: FAIL [fdo#103191] / [fdo#107362] -> PASS

* {igt@kms_plane@pixel-format-pipe-c-planes-source-clamping}:
- shard-glk: FAIL [fdo#108948] -> PASS

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS

* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: FAIL [fdo#107815] / [fdo#108145] -> PASS

* igt@kms_plane_multiple@atomic-pipe-b-tiling-x:
- shard-glk: FAIL [fdo#103166] -> PASS

* igt@pm_backlight@basic-brightness:
- {shard-iclb}: DMESG-WARN [fdo#107724] -> PASS +25

* igt@pm_rpm@gem-execbuf-stress-pc8:
- {shard-iclb}: INCOMPLETE [fdo#107713] / [fdo#108840] -> SKIP
- shard-skl: INCOMPLETE [fdo#107807] -> SKIP

* igt@pm_rpm@modeset-lpsp:
- {shard-iclb}: DMESG-WARN [fdo#108654] -> PASS

#### Warnings ####

* igt@i915_suspend@shrink:
- shard-skl: INCOMPLETE [fdo#106886] -> DMESG-WARN [fdo#108784]

* igt@kms_ccs@pipe-a-crc-primary-basic:
- {shard-iclb}: DMESG-WARN [fdo#107724] / [fdo#108336] -> FAIL [fdo#107725]

* igt@kms_cursor_crc@cursor-64x21-sliding:
- {shard-iclb}: FAIL [fdo#103232] -> DMESG-WARN [fdo#107724] / [fdo#108336]

* igt@kms_cursor_crc@cursor-64x64-sliding:
- {shard-iclb}: DMESG-WARN [fdo#107724] / [fdo#108336] -> FAIL [fdo#103232]

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-fullscreen:
- {shard-iclb}: DMESG-FAIL [fdo#107724] -> FAIL [fdo#103167]

* igt@kms_plane@pixel-format-pipe-b-planes:
- {shard-iclb}: FAIL [fdo#103166] -> DMESG-WARN [fdo#107724] / [fdo#108336]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

Participating hosts (7 -> 7)
------------------------------

No changes in participating hosts

Build changes
-------------

* Linux: CI_DRM_5266 -> Patchwork_11022

== Logs ==