Skip to contentSkip to conversation

pinctrl: Use of_node_name_eq for node name comparisons

PATCH In review Rob Herring 4 participants 4 messages Dec 5, 2018 – Dec 14, 2018

Subsystems (4)
GPIO Arm Samsung Exynos Pin control Pin controller - Samsung
lore
Share & tools
lore

Rob Herring

author
#0 lore raw

PATCH 1/1 pinctrl: Use of_node_name_eq for node name comparisons

Convert string compares of DT node names to use of_node_name_eq helper instead. This removes direct access to the node name pointer.

Cc Tomasz Figa <[email protected]>
Cc Krzysztof Kozlowski <[email protected]>
Cc Sylwester Nawrocki <[email protected]>
Cc Linus Walleij <[email protected]>
Cc [email protected]
Cc [email protected]
Cc [email protected]
Signed-off-by Rob Herring <[email protected]>
---
 drivers/pinctrl/samsung/pinctrl-samsung.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/samsung/pinctrl-samsung.c +1 -1
index ee6ee2338606..de0477bb469d 100644
@@ -1071,7 +1071,7 @@ samsung_pinctrl_get_soc_data(struct samsung_pinctrl_drv_data *d,
 			continue;
 		bank = d->pin_banks;
 		for (i = 0; i < d->nr_banks; ++i, ++bank) {
-			if (!strcmp(bank->name, np->name)) {
+			if (of_node_name_eq(np, bank->name)) {
 				bank->of_node = np;
 				break;
 			}
Signature · 1 line
2.19.1
Reviewed-by on v1 1/1
#1 lore raw

2018年12月5日(水) 11:51 Rob Herring <[email protected]>:

Quoted 30 lines

Convert string compares of DT node names to use of_node_name_eq helper instead. This removes direct access to the node name pointer.

Cc Tomasz Figa <[email protected]>
Cc Krzysztof Kozlowski <[email protected]>
Cc Sylwester Nawrocki <[email protected]>
Cc Linus Walleij <[email protected]>
Cc [email protected]
Cc [email protected]
Cc [email protected]
Signed-off-by Rob Herring <[email protected]>
---
 drivers/pinctrl/samsung/pinctrl-samsung.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/samsung/pinctrl-samsung.c +1 -2
index ee6ee2338606..de0477bb469d 100644
@@ -1071,7 +1071,7 @@ samsung_pinctrl_get_soc_data(struct samsung_pinctrl_drv_data *d,
                        continue;
                bank = d->pin_banks;
                for (i = 0; i < d->nr_banks; ++i, ++bank) {
-                       if (!strcmp(bank->name, np->name)) {
+                       if (of_node_name_eq(np, bank->name)) {
                                bank->of_node = np;
                                break;
                        }
--
Quoted 2 lines

2.19.1

Reviewed-by Tomasz Figa <[email protected]>

Best regards,
Tomasz

maintainer Reviewed-by on v1 1/1
#2 lore raw
In reply to Rob Herring
Quoted 12 lines · Rob Herring

Convert string compares of DT node names to use of_node_name_eq helper instead. This removes direct access to the node name pointer.

Cc Tomasz Figa <[email protected]>
Cc Krzysztof Kozlowski <[email protected]>
Cc Sylwester Nawrocki <[email protected]>
Cc Linus Walleij <[email protected]>
Cc [email protected]
Cc [email protected]
Cc [email protected]
Signed-off-by Rob Herring <[email protected]>
Quoted 3 lines
---
 drivers/pinctrl/samsung/pinctrl-samsung.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by Krzysztof Kozlowski <[email protected]>

Linus,
I do not have anything queued in pinctrl samsung for next release, so maybe you could apply this directly?

Best regards,
Krzysztof

#3 lore raw
In reply to Rob Herring
Quoted 11 lines · Rob Herring

Convert string compares of DT node names to use of_node_name_eq helper instead. This removes direct access to the node name pointer.

Cc Tomasz Figa <[email protected]>
Cc Krzysztof Kozlowski <[email protected]>
Cc Sylwester Nawrocki <[email protected]>
Cc Linus Walleij <[email protected]>
Cc [email protected]
Cc [email protected]
Cc [email protected]
Signed-off-by Rob Herring <[email protected]>

Patch applied!

Yours,
Linus Walleij