video/backlight: Use of_node_name_eq for node name comparisons
Subsystems (2)
PATCH 1/1 video/backlight: Use of_node_name_eq for node name comparisons
Convert string compares of DT node names to use of_node_name_eq helper instead. This removes direct access to the node name pointer.
For instances using of_node_cmp, this has the side effect of now using case sensitive comparisons. This should not matter for any FDT based system which this is.
--- drivers/video/backlight/88pm860x_bl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/backlight/88pm860x_bl.c +1 -1
@@ -174,7 +174,7 @@ static int pm860x_backlight_dt_init(struct platform_device *pdev,return -ENODEV ; }for_each_child_of_node (nproot, np) { -if (!of_node_cmp (np->name, name)) { +if (of_node_name_eq (np, name)) {of_property_read_u32 (np,"marvell,88pm860x-iset" , &iset); data->iset =PM8606_WLED_CURRENT (iset);
Signature · 6 lines
2.19.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 7 lines · Rob Herring
Convert string compares of DT node names to use
of_node_name_eqhelper instead. This removes direct access to the node name pointer.For instances using
of_node_cmp, this has the side effect of now using case sensitive comparisons. This should not matter for any FDT based system which this is.
Quoted 7 lines
Cc Lee Jones <[email protected]>Cc Daniel Thompson <[email protected]>Cc Jingoo Han <[email protected]>Cc Bartlomiej Zolnierkiewicz <[email protected]>Signed-off-by Rob Herring <[email protected]>
[this is FAO Lee J. rather than recommending you take it via you tree]
Quoted 20 lines
--- drivers/video/backlight/88pm860x_bl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/video/backlight/88pm860x_bl.c +1
-1@@ -174,7 +174,7 @@ static int pm860x_backlight_dt_init(struct platform_device *pdev,return -ENODEV ; }for_each_child_of_node (nproot, np) { -if (!of_node_cmp (np->name, name)) { +if (of_node_name_eq (np, name)) {of_property_read_u32 (np,"marvell,88pm860x-iset" , &iset); data->iset =PM8606_WLED_CURRENT (iset);Signature · 1 line
2.19.1
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Lee Jones
AppliedQuoted 16 lines · Daniel Thompson
Quoted 7 lines · Rob Herring
Convert string compares of DT node names to use
of_node_name_eqhelper instead. This removes direct access to the node name pointer.For instances using
of_node_cmp, this has the side effect of now using case sensitive comparisons. This should not matter for any FDT based system which this is.Quoted 7 lines
Cc Lee Jones <[email protected]>Cc Daniel Thompson <[email protected]>Cc Jingoo Han <[email protected]>Cc Bartlomiej Zolnierkiewicz <[email protected]>Signed-off-by Rob Herring <[email protected]>
Quoted 3 lines
Acked-by Daniel Thompson <[email protected]>[this is FAO Lee J. rather than recommending you take it via you tree]
Rob knows better than that. ;)
Applied, thanks.
Signature · 8 lines
Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel