drm: imx: Use of_node_name_eq for node name comparisons
Subsystems (3)
PATCH 1/1 drm: imx: Use of_node_name_eq for node name comparisons
Convert string compares of DT node names to use of_node_name_eq helper instead. This removes direct access to the node name pointer.
For instances using of_node_cmp, this has the side effect of now using case sensitive comparisons. This should not matter for any FDT based system which this is.
--- drivers/gpu/drm/imx/imx-drm-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/imx/imx-drm-core.c +1 -1
@@ -198,7 +198,7 @@ static int compare_of(struct device *dev, void *data) }/* Special case for LDB, one device for two channels */ -if (of_node_cmp (np->name,"lvds-channel" ) ==0 ) { +if (of_node_name_eq (np,"lvds-channel" )) { np =of_get_parent (np);of_node_put (np); }
Signature · 6 lines
2.19.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 8 lines · Rob Herring
Convert string compares of DT node names to use
of_node_name_eqhelper instead. This removes direct access to the node name pointer.For instances using
of_node_cmp, this has the side effect of now using case sensitive comparisons. This should not matter for any FDT based system which this is.
Quoted 7 lines
Cc Philipp Zabel <[email protected]>Cc David Airlie <[email protected]>Signed-off-by Rob Herring <[email protected]>--- drivers/gpu/drm/imx/imx-drm-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Philipp, can I get an ack on this? I can commit it.
Rob
Philipp Zabel
Acked-byHi Rob,
Quoted 17 lines · Rob Herring
Quoted 8 lines · Rob Herring
Convert string compares of DT node names to use
of_node_name_eqhelper instead. This removes direct access to the node name pointer.For instances using
of_node_cmp, this has the side effect of now using case sensitive comparisons. This should not matter for any FDT based system which this is.Quoted 7 lines
Cc Philipp Zabel <[email protected]>Cc David Airlie <[email protected]>Signed-off-by Rob Herring <[email protected]>--- drivers/gpu/drm/imx/imx-drm-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 1 line
Philipp, can I get an ack on this? I can commit it.
Thank you,
regards
Philipp
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel