Skip to contentSkip to conversation

Input: restore EV_ABS ABS_RESERVED

PATCH In review Peter Hutterer 5 participants 7 messages Dec 5, 2018 – Dec 10, 2018

Subsystems (2)
HID Input drivers
lore
Share & tools
lore

Peter Hutterer

author
#0 lore raw

PATCH 1/1 Input: restore EV_ABS ABS_RESERVED

ABS_RESERVED was added in d9ca1c990a7 and accidentally removed as part of ffe0e7cf290f5c9 when the high-resolution scrolling code was removed.

Signed-off-by Peter Hutterer <[email protected]>
---
 include/uapi/linux/input-event-codes.h | 9 +++++++++
 1 file changed, 9 insertions(+)
include/uapi/linux/input-event-codes.h +9 -0
index 3eb5a4c3d60a..ae366b87426a 100644
@@ -752,6 +752,15 @@
 
 #define ABS_MISC		0x28
 
+/*
+ * 0x2e is reserved and should not be used in input drivers.
+ * It was used by HID as ABS_MISC+6 and userspace needs to detect if
+ * the next ABS_* event is correct or is just ABS_MISC + n.
+ * We define here ABS_RESERVED so userspace can rely on it and detect
+ * the situation described above.
+ */
+#define ABS_RESERVED		0x2e
+
 #define ABS_MT_SLOT		0x2f	/* MT slot being modified */
 #define ABS_MT_TOUCH_MAJOR	0x30	/* Major axis of touching ellipse */
 #define ABS_MT_TOUCH_MINOR	0x31	/* Minor axis (omit if circular) */
Signature · 1 line
2.19.2
Acked-by
#2 lore raw
Quoted 8 lines · Martin Kepplinger
Quoted 4 lines · Peter Hutterer

ABS_RESERVED was added in d9ca1c990a7 and accidentally removed as part of ffe0e7cf290f5c9 when the high-resolution scrolling code was removed.

Signed-off-by Peter Hutterer <[email protected]>
Reviewed-by Martin Kepplinger <[email protected]>
Acked-by Benjamin Tissoires <[email protected]>

Dmitry, I do not think this one will conflict with the high res wheel patches, so I think it should be safe to take it through your tree. If you think it'll be an issue, I can also take it through the HID one.

Cheers,
Benjamin

author
#3 lore raw
Quoted 9 lines · Benjamin Tissoires
Quoted 7 lines · Martin Kepplinger
Quoted 4 lines · Peter Hutterer

ABS_RESERVED was added in d9ca1c990a7 and accidentally removed as part of ffe0e7cf290f5c9 when the high-resolution scrolling code was removed.

Signed-off-by Peter Hutterer <[email protected]>
Quoted 7 lines
Quoted 1 line
Reviewed-by Martin Kepplinger <[email protected]>
Acked-by Benjamin Tissoires <[email protected]>

Dmitry, I do not think this one will conflict with the high res wheel patches, so I think it should be safe to take it through your tree. If you think it'll be an issue, I can also take it through the HID one.

fwiw, patch was made on top of v4.20-rc5, so it shouldn't conflict.

Cheers,
Peter

maintainer Acked-by
#4 lore raw
Quoted 12 lines · Peter Hutterer
Quoted 11 lines · Benjamin Tissoires
Quoted 8 lines · Martin Kepplinger
Quoted 4 lines · Peter Hutterer

ABS_RESERVED was added in d9ca1c990a7 and accidentally removed as part of ffe0e7cf290f5c9 when the high-resolution scrolling code was removed.

Signed-off-by Peter Hutterer <[email protected]>
Reviewed-by Martin Kepplinger <[email protected]>
Quoted 7 lines
Quoted 5 lines
Acked-by Benjamin Tissoires <[email protected]>

Dmitry, I do not think this one will conflict with the high res wheel patches, so I think it should be safe to take it through your tree. If you think it'll be an issue, I can also take it through the HID one.

fwiw, patch was made on top of v4.20-rc5, so it shouldn't conflict.

My tree is behind that ;) so I would actually prefer if Benjamin/Jiri would take it through their tree with my:

Acked-by Dmitry Torokhov <[email protected]>

Thanks.

Signature · 1 line
Dmitry
#5 lore raw
Quoted 20 lines · Dmitry Torokhov
Quoted 18 lines · Peter Hutterer
Quoted 16 lines · Benjamin Tissoires
Quoted 8 lines · Martin Kepplinger
Quoted 4 lines · Peter Hutterer

ABS_RESERVED was added in d9ca1c990a7 and accidentally removed as part of ffe0e7cf290f5c9 when the high-resolution scrolling code was removed.

Signed-off-by Peter Hutterer <[email protected]>
Reviewed-by Martin Kepplinger <[email protected]>
Acked-by Benjamin Tissoires <[email protected]>

Dmitry, I do not think this one will conflict with the high res wheel patches, so I think it should be safe to take it through your tree. If you think it'll be an issue, I can also take it through the HID one.

Quoted 7 lines
Quoted 1 line

fwiw, patch was made on top of v4.20-rc5, so it shouldn't conflict.

My tree is behind that ;) so I would actually prefer if Benjamin/Jiri would take it through their tree with my:

Acked-by Dmitry Torokhov <[email protected]>

OK, thanks Dmitry.

Jiri, I have pushed this in for-4.20/upstream-fixes.

I think the branch has enough now to justify a PR towards Linus. I believe https://patchwork.kernel.org/patch/10693337/ would be a good material too, but OTOH, this only happens when the device fails at probing, so maybe not so urgent.

Cheers,
Benjamin

Quoted 4 lines

Thanks.

--
Dmitry

maintainer
#6 lore raw
Quoted 5 lines · Benjamin Tissoires

OK, thanks Dmitry.

Jiri, I have pushed this in for-4.20/upstream-fixes.

I think the branch has enough now to justify a PR towards Linus.

Agreed. I will be sending it today. Thanks,

Signature · 2 lines
Jiri Kosina
SUSE Labs