Skip to contentSkip to conversation

dm: Tidy up 'dm tree' output when there are many devices

PATCH New Simon Glass 3 participants 3 messages Dec 6, 2018 – Dec 28, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dm: Tidy up 'dm tree' output when there are many devices

At present the 'Index' column assumes there is only one digit. But on some devices (e.g. snow) there are a lot of regulators and GPIO banks. Adjust the output to allow for two digits without messing up the display.

Also capatalise the heading to match.

Fixes 5197dafc42 (dm: core: Widen the dump tree to show more of the

driver's name.)

---

 drivers/core/dump.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/core/dump.c +2 -2
index 04217cbde87..8fbfd93fb5e 100644
@@ -16,7 +16,7 @@ static void show_devices(struct udevice *dev, int depth, int last_flag)
 	struct udevice *child;
 
 	/* print the first 20 characters to not break the tree-format. */
-	printf(" %-10.10s  %d  [ %c ]   %-20.20s  ", dev->uclass->uc_drv->name,
+	printf(" %-10.10s  %2d  [ %c ]   %-20.20s  ", dev->uclass->uc_drv->name,
 	       dev_get_uclass_index(dev, NULL),
 	       dev->flags & DM_FLAG_ACTIVATED ? '+' : ' ', dev->driver->name);
 
@@ -49,7 +49,7 @@ void dm_dump_all(void)
 
 	root = dm_root();
 	if (root) {
-		printf(" Class    index  Probed  Driver                Name\n");
+		printf(" Class     Index  Probed  Driver                Name\n");
 		printf("-----------------------------------------------------------\n");
 		show_devices(root, -1, 0);
 	}
Signature · 1 line
2.20.0.rc1.387.gf8505762e3-goog
#1 lore raw

PATCH 1/1 dm: Tidy up 'dm tree' output when there are many devices

Quoted 10 lines · Simon Glass

At present the 'Index' column assumes there is only one digit. But on some devices (e.g. snow) there are a lot of regulators and GPIO banks. Adjust the output to allow for two digits without messing up the display.

Also capatalise the heading to match.

Fixes 5197dafc42 (dm: core: Widen the dump tree to show more of the

driver's name.)

Best regards,
Liviu

Quoted 30 lines

---

 drivers/core/dump.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/core/dump.c +2 -2
index 04217cbde87..8fbfd93fb5e 100644
@@ -16,7 +16,7 @@ static void show_devices(struct udevice *dev, int depth, int last_flag)
 	struct udevice *child;
 
 	/* print the first 20 characters to not break the tree-format. */
-	printf(" %-10.10s  %d  [ %c ]   %-20.20s  ", dev->uclass->uc_drv->name,
+	printf(" %-10.10s  %2d  [ %c ]   %-20.20s  ", dev->uclass->uc_drv->name,
 	       dev_get_uclass_index(dev, NULL),
 	       dev->flags & DM_FLAG_ACTIVATED ? '+' : ' ', dev->driver->name);
 
@@ -49,7 +49,7 @@ void dm_dump_all(void)
 
 	root = dm_root();
 	if (root) {
-		printf(" Class    index  Probed  Driver                Name\n");
+		printf(" Class     Index  Probed  Driver                Name\n");
 		printf("-----------------------------------------------------------\n");
 		show_devices(root, -1, 0);
 	}
Signature · 1 line
2.20.0.rc1.387.gf8505762e3-goog
Signature · 8 lines
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯
#2 lore raw

PATCH 1/1 dm: Tidy up 'dm tree' output when there are many devices

Quoted 10 lines · Simon Glass

At present the 'Index' column assumes there is only one digit. But on some devices (e.g. snow) there are a lot of regulators and GPIO banks. Adjust the output to allow for two digits without messing up the display.

Also capatalise the heading to match.

Fixes 5197dafc42 (dm: core: Widen the dump tree to show more of the

driver's name.)

Best regards,
Liviu

Quoted 5 lines

---

 drivers/core/dump.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Applied to u-boot-dm/master, thanks!