Skip to contentSkip to conversation

mfd: cros_ec: Add commands to control codec

PATCH Superseded Cheng-Yi Chiang 3 participants 6 messages Dec 6, 2018 – Dec 22, 2018

Subsystems (2)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 mfd: cros_ec: Add commands to control codec

Add EC host commands to control codec on EC.

---
V2 fixed the wrong ancestor issue so the patch can be applied cleanly on mfd tree. Codec driver that uses these commands will be sent separately. Thanks!

 include/linux/mfd/cros_ec_commands.h | 94 ++++++++++++++++++++++++++++
 1 file changed, 94 insertions(+)
include/linux/mfd/cros_ec_commands.h +94 -0
index 9a9631f0559e2..fc91082d4c357 100644
@@ -2790,6 +2790,100 @@ struct ec_response_battery_vendor_param {
 	uint32_t value;
 } __packed;
 
+/*****************************************************************************/
+/* Commands for I2S recording on audio codec. */
+
+#define EC_CMD_CODEC_I2S 0x00BC
+
+enum ec_codec_i2s_subcmd {
+	EC_CODEC_SET_SAMPLE_DEPTH = 0x0,
+	EC_CODEC_SET_GAIN = 0x1,
+	EC_CODEC_GET_GAIN = 0x2,
+	EC_CODEC_I2S_ENABLE = 0x3,
+	EC_CODEC_I2S_SET_CONFIG = 0x4,
+	EC_CODEC_I2S_SET_TDM_CONFIG = 0x5,
+	EC_CODEC_I2S_SET_BCLK = 0x6,
+};
+
+enum ec_sample_depth_value {
+	EC_CODEC_SAMPLE_DEPTH_16 = 0,
+	EC_CODEC_SAMPLE_DEPTH_24 = 1,
+};
+
+enum ec_i2s_config {
+	EC_DAI_FMT_I2S = 0,
+	EC_DAI_FMT_RIGHT_J = 1,
+	EC_DAI_FMT_LEFT_J = 2,
+	EC_DAI_FMT_PCM_A = 3,
+	EC_DAI_FMT_PCM_B = 4,
+	EC_DAI_FMT_PCM_TDM = 5,
+};
+
+struct ec_param_codec_i2s {
+	/*
+	 * enum ec_codec_i2s_subcmd
+	 */
+	uint8_t cmd;
+	union {
+		/*
+		 * EC_CODEC_SET_SAMPLE_DEPTH
+		 * Value should be one of ec_sample_depth_value.
+		 */
+		uint8_t depth;
+
+		/*
+		 * EC_CODEC_SET_GAIN
+		 * Value should be 0~43 for both channels.
+		 */
+		struct ec_param_codec_i2s_set_gain {
+			uint8_t left;
+			uint8_t right;
+		} __packed gain;
+
+		/*
+		 * EC_CODEC_I2S_ENABLE
+		 * 1 to enable, 0 to disable.
+		 */
+		uint8_t i2s_enable;
+
+		/*
+		 * EC_CODEC_I2S_SET_COFNIG
+		 * Value should be one of ec_i2s_config.
+		 */
+		uint8_t i2s_config;
+
+		/*
+		 * EC_CODEC_I2S_SET_TDM_CONFIG
+		 * Value should be one of ec_i2s_config.
+		 */
+		struct ec_param_codec_i2s_tdm {
+			/*
+			 * 0 to 496
+			 */
+			int16_t ch0_delay;
+			/*
+			 * -1 to 496
+			 */
+			int16_t ch1_delay;
+			uint8_t adjacent_to_ch0;
+			uint8_t adjacent_to_ch1;
+		} __packed tdm_param;
+
+		/*
+		 * EC_CODEC_I2S_SET_BCLK
+		 */
+		uint32_t bclk;
+	};
+} __packed;
+
+/*
+ * For subcommand EC_CODEC_GET_GAIN.
+ */
+struct ec_response_codec_gain {
+	uint8_t left;
+	uint8_t right;
+} __packed;
+
 /*****************************************************************************/
 /* System commands */
 
Signature · 1 line
2.20.0.rc1.387.gf8505762e3-goog
#1 lore raw
Quoted 10 lines · Cheng-Yi Chiang

Add EC host commands to control codec on EC.

---
V2 fixed the wrong ancestor issue so the patch can be applied cleanly on mfd tree. Codec driver that uses these commands will be sent separately. Thanks!

 include/linux/mfd/cros_ec_commands.h | 94 ++++++++++++++++++++++++++++
 1 file changed, 94 insertions(+)

Would be good to have this reviewed by some more Chrome people.

Signature · 4 lines
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#2 lore raw
Quoted 10 lines · Lee Jones
Quoted 8 lines · Cheng-Yi Chiang

Add EC host commands to control codec on EC.

---
V2 fixed the wrong ancestor issue so the patch can be applied cleanly on mfd tree. Codec driver that uses these commands will be sent separately. Thanks!

Quoted 4 lines
Quoted 2 lines
 include/linux/mfd/cros_ec_commands.h | 94 ++++++++++++++++++++++++++++
 1 file changed, 94 insertions(+)

Would be good to have this reviewed by some more Chrome people.

See this for reference:

https://lore.kernel.org/patchwork/patch/1024985/

Signature · 4 lines
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#3 lore raw

+Benson, Guenter, Scott

Quoted 13 lines · Lee Jones
Quoted 10 lines · Lee Jones
Quoted 8 lines · Cheng-Yi Chiang

Add EC host commands to control codec on EC.

---
V2 fixed the wrong ancestor issue so the patch can be applied cleanly on mfd tree. Codec driver that uses these commands will be sent separately. Thanks!

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
 include/linux/mfd/cros_ec_commands.h | 94 ++++++++++++++++++++++++++++
 1 file changed, 94 insertions(+)

Would be good to have this reviewed by some more Chrome people.

See this for reference:

https://lore.kernel.org/patchwork/patch/1024985/

Hi Benson and Guenter,
Could you please review this patch ?
The corresponding implementation at EC side by Scott is at
https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1356185

Thanks a lot!

Quoted 6 lines

--
Lee Jones [李琼斯]
Linaro Services Technical Lead

Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#4 lore raw
Quoted 19 lines · Cheng-yi Chiang

+Benson, Guenter, Scott

Quoted 16 lines · Lee Jones
Quoted 13 lines · Lee Jones
Quoted 10 lines · Cheng-Yi Chiang

Add EC host commands to control codec on EC.

---
V2 fixed the wrong ancestor issue so the patch can be applied cleanly on mfd tree. Codec driver that uses these commands will be sent separately. Thanks!

 include/linux/mfd/cros_ec_commands.h | 94 ++++++++++++++++++++++++++++
 1 file changed, 94 insertions(+)
Quoted 8 lines
Quoted 5 lines
Quoted 1 line

Would be good to have this reviewed by some more Chrome people.

See this for reference:

https://lore.kernel.org/patchwork/patch/1024985/

Hi Benson and Guenter,
Could you please review this patch ?

You haven't sent them the patch.

Please resubmit as a [RESEND] and add them as recipients.

Quoted 6 lines

The corresponding implementation at EC side by Scott is at
https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1356185

Thanks a lot!

Quoted 1 line
Signature · 4 lines
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#5 lore raw
Quoted 26 lines · Lee Jones
Quoted 23 lines · Cheng-yi Chiang

+Benson, Guenter, Scott

Quoted 20 lines · Lee Jones
Quoted 10 lines · Lee Jones
Quoted 8 lines · Cheng-Yi Chiang

Add EC host commands to control codec on EC.

---
V2 fixed the wrong ancestor issue so the patch can be applied cleanly on mfd tree. Codec driver that uses these commands will be sent separately. Thanks!

Quoted 4 lines
Quoted 2 lines
 include/linux/mfd/cros_ec_commands.h | 94 ++++++++++++++++++++++++++++
 1 file changed, 94 insertions(+)

Would be good to have this reviewed by some more Chrome people.

See this for reference:

Quoted 9 lines
Quoted 4 lines
Quoted 1 line

https://lore.kernel.org/patchwork/patch/1024985/

Hi Benson and Guenter,
Could you please review this patch ?

You haven't sent them the patch.

Please resubmit as a [RESEND] and add them as recipients.

I was asked separately from one of our engineers if it would be acceptable to synchronize cros_ec_commands.h with the version from the EC source. I think that might make more sense than a piece-by-piece approach.

Thanks,
Guenter