riscv: remove unused variable in ftrace
PATCH 1/1 riscv: remove unused variable in ftrace
Noticed while building kernel-4.20.0-0.rc5.git2.1.fc30 for Fedora 30/RISCV.
[..]
BUILDSTDERR: arch/riscv/kernel/ftrace.c: In function 'prepare_ftrace_return': BUILDSTDERR: arch/riscv/kernel/ftrace.c:135:6: warning: unused variable 'err' [-Wunused-variable] BUILDSTDERR: int err; BUILDSTDERR: ^~~
[..]
Signed-off-by David Abdurachmanov <[email protected]>
--- arch/riscv/kernel/ftrace.c | 1 - 1 file changed, 1 deletion(-)
arch/riscv/kernel/ftrace.c +0 -1
@@ -132,7 +132,6 @@ void prepare_ftrace_return(unsigned long *parent, unsigned long self_addr, {unsigned long return_hooker = (unsigned long )&return_to_handler;unsigned long old; -int err;if (unlikely (atomic_read (¤t->tracing_graph_pause)))return ;
Signature · 1 line
2.19.2
Quoted 4 lines · David Abdurachmanov
Noticed while building kernel-4.20.0-0.rc5.git2.1.fc30 for Fedora 30/RISCV.
Quoted 8 lines
[..]
BUILDSTDERR: arch/riscv/kernel/ftrace.c: In function 'prepare_ftrace_return': BUILDSTDERR: arch/riscv/kernel/ftrace.c:135:6: warning: unused variable 'err' [-Wunused-variable] BUILDSTDERR: int err; BUILDSTDERR: ^~~[..]
Signed-off-by David Abdurachmanov <[email protected]>
Please add a:
Fixes e949b6db51dc1 ("riscv/function_graph: Simplify with
function_graph_enter()")
Reviewed-by Olof Johansson <[email protected]>
Quoted 11 lines · On Thu, 6 Dec 2018 11:20:31 -0800 Olof Johansson <[email protected]> wrote:
Quoted 9 lines · David Abdurachmanov
Noticed while building kernel-4.20.0-0.rc5.git2.1.fc30 for Fedora 30/RISCV.
[..]
BUILDSTDERR: arch/riscv/kernel/ftrace.c: In function 'prepare_ftrace_return': BUILDSTDERR: arch/riscv/kernel/ftrace.c:135:6: warning: unused variable 'err' [-Wunused-variable] BUILDSTDERR: int err; BUILDSTDERR: ^~~
Bah. I could have sworn I checked for all the error messages when I did my cross-compiling of the architectures. I fixed this issue in other places, not sure how I missed riscv.
Thanks for fixing it.
-- Steve
Quoted 8 lines
Quoted 3 lines
[..]
Signed-off-by David Abdurachmanov <[email protected]>Please add a:
Fixes e949b6db51dc1 ("riscv/function_graph: Simplify with
function_graph_enter()")Reviewed-by Olof Johansson <[email protected]>