scripts/atomic: change 'fold' to 'grep'
PATCH 1/1 scripts/atomic: change 'fold' to 'grep'
Some distibutions and build systems doesn't include 'fold' from coreutils default.
.../scripts/atomic/atomic-tbl.sh: line 183: fold: command not found
Rework to use 'grep' instead of 'fold' to use a dependency that is already used a lot in the kernel.
--- scripts/atomic/atomic-tbl.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/atomic/atomic-tbl.sh +1 -1
@@ -180,7 +180,7 @@ gen_proto_variants() #gen_proto(meta, ...) gen_proto() { local meta="$1"; shift - for m in $(echo "${meta}" | fold -w1); do + for m in $(echo "${meta}" | grep -o .); do gen_proto_variants "${m}" "$@" done }
Signature · 1 line
2.19.2
[+ Ingo and Mark]
Quoted 20 lines · Anders Roxell
Some distibutions and build systems doesn't include 'fold' from coreutils default.
.../scripts/atomic/atomic-tbl.sh: line 183: fold: command not foundRework to use 'grep' instead of 'fold' to use a dependency that is already used a lot in the kernel.
Reported-by Naresh Kamboju <[email protected]>Suggested-by Will Deacon <[email protected]>Signed-off-by Anders Roxell <[email protected]>--- scripts/atomic/atomic-tbl.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)scripts/atomic/atomic-tbl.sh +0
-0
scripts/atomic/atomic-tbl.sh gen_proto_variants() · line 185
Quoted 7 lines
scripts/atomic/atomic-tbl.sh +1
-1@@ -180,7 +180,7 @@ gen_proto_variants() #gen_proto(meta, ...) gen_proto() { local meta="$1"; shift - for m in $(echo "${meta}" | fold -w1); do + for m in $(echo "${meta}" | grep -o .); do gen_proto_variants "${m}" "$@" done
Ingo -- please can you take this one via -tip?
Cheers,
Will
Quoted 33 lines · Will Deacon
[+ Ingo and Mark]
Quoted 20 lines · Anders Roxell
Some distibutions and build systems doesn't include 'fold' from coreutils default.
.../scripts/atomic/atomic-tbl.sh: line 183: fold: command not foundRework to use 'grep' instead of 'fold' to use a dependency that is already used a lot in the kernel.
Reported-by Naresh Kamboju <[email protected]>Suggested-by Will Deacon <[email protected]>Signed-off-by Anders Roxell <[email protected]>--- scripts/atomic/atomic-tbl.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)scripts/atomic/atomic-tbl.sh +0
-0scripts/atomic/atomic-tbl.sh gen_proto_variants() · line 185
Quoted 7 lines
scripts/atomic/atomic-tbl.sh +1
-1@@ -180,7 +180,7 @@ gen_proto_variants() #gen_proto(meta, ...) gen_proto() { local meta="$1"; shift - for m in $(echo "${meta}" | fold -w1); do + for m in $(echo "${meta}" | grep -o .); do gen_proto_variants "${m}" "$@" doneAcked-by Will Deacon <[email protected]>
Quoted 1 line
Ingo -- please can you take this one via -tip?
I'm still waiting for a reply to my previous concerns expressed in:
Re: [tip:locking/core] locking/atomics: Check generated headers are up-to-date <[email protected]>
Will remove it from linux-next if there's no good resolution for this cycle.
Thanks,
Ingo
Mark Rutland
reviewerHi Ingo,
Quoted 38 lines · Ingo Molnar
Quoted 33 lines · Will Deacon
[+ Ingo and Mark]
Quoted 20 lines · Anders Roxell
Some distibutions and build systems doesn't include 'fold' from coreutils default.
.../scripts/atomic/atomic-tbl.sh: line 183: fold: command not foundRework to use 'grep' instead of 'fold' to use a dependency that is already used a lot in the kernel.
Reported-by Naresh Kamboju <[email protected]>Suggested-by Will Deacon <[email protected]>Signed-off-by Anders Roxell <[email protected]>--- scripts/atomic/atomic-tbl.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)scripts/atomic/atomic-tbl.sh +0
-0scripts/atomic/atomic-tbl.sh gen_proto_variants() · line 185
Quoted 7 lines
scripts/atomic/atomic-tbl.sh +1
-1@@ -180,7 +180,7 @@ gen_proto_variants() #gen_proto(meta, ...) gen_proto() { local meta="$1"; shift - for m in $(echo "${meta}" | fold -w1); do + for m in $(echo "${meta}" | grep -o .); do gen_proto_variants "${m}" "$@" doneAcked-by Will Deacon <[email protected]>Quoted 1 line
Ingo -- please can you take this one via -tip?
Quoted 7 lines
I'm still waiting for a reply to my previous concerns expressed in:
Re: [tip:locking/core] locking/atomics: Check generated headers are up-to-date <[email protected]>
Will remove it from linux-next if there's no good resolution for this cycle.
I've just sent a couple of patches for that; please see:
https://lkml.kernel.org/r/[email protected]
Thanks,
Mark.