pcie: portdrv: Fix Unnecessary space before function pointer arguments
PATCH 1/1 pcie: portdrv: Fix Unnecessary space before function pointer arguments
Made spacing more consistent in the code for function pointer declarations based on checkpatch.pl
Signed-off-by Benjamin Young <[email protected]>
--- drivers/pci/pcie/portdrv.h | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
drivers/pci/pcie/portdrv.h +8 -8
@@ -71,19 +71,19 @@ static inline void *get_service_data(struct pcie_device *dev)struct pcie_port_service_driver {const char *name; -int (*probe) (struct pcie_device *dev); -void (*remove) (struct pcie_device *dev); -int (*suspend) (struct pcie_device *dev); -int (*resume_noirq) (struct pcie_device *dev); -int (*resume) (struct pcie_device *dev); -int (*runtime_suspend) (struct pcie_device *dev); -int (*runtime_resume) (struct pcie_device *dev); +int (*probe)(struct pcie_device *dev); +void (*remove)(struct pcie_device *dev); +int (*suspend)(struct pcie_device *dev); +int (*resume_noirq)(struct pcie_device *dev); +int (*resume)(struct pcie_device *dev); +int (*runtime_suspend)(struct pcie_device *dev); +int (*runtime_resume)(struct pcie_device *dev);/* Device driver may resume normal operations */ void (*error_resume)(struct pci_dev *dev);/* Link Reset Capability - AER service driver specific */ -pci_ers_result_t (*reset_link) (struct pci_dev *dev); +pci_ers_result_t (*reset_link)(struct pci_dev *dev);int port_type;/* Type of the port this driver can handle */ u32 service;/* Port service this device represents */
Signature · 1 line
2.5.0
Bjorn Helgaas
AppliedQuoted 4 lines · Benjamin Young
Made spacing more consistent in the code for function pointer declarations based on checkpatch.pl
Signed-off-by Benjamin Young <[email protected]>
Applied to pci/misc for v4.21, thanks!
I also made similar changes to include/linux/pci.h. For trivial changes like this I like to fix similar issues in all of PCI at the same time.
Quoted 39 lines
--- drivers/pci/pcie/portdrv.h | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)drivers/pci/pcie/portdrv.h +8
-8@@ -71,19 +71,19 @@ static inline void *get_service_data(struct pcie_device *dev)struct pcie_port_service_driver {const char *name; -int (*probe) (struct pcie_device *dev); -void (*remove) (struct pcie_device *dev); -int (*suspend) (struct pcie_device *dev); -int (*resume_noirq) (struct pcie_device *dev); -int (*resume) (struct pcie_device *dev); -int (*runtime_suspend) (struct pcie_device *dev); -int (*runtime_resume) (struct pcie_device *dev); +int (*probe)(struct pcie_device *dev); +void (*remove)(struct pcie_device *dev); +int (*suspend)(struct pcie_device *dev); +int (*resume_noirq)(struct pcie_device *dev); +int (*resume)(struct pcie_device *dev); +int (*runtime_suspend)(struct pcie_device *dev); +int (*runtime_resume)(struct pcie_device *dev);/* Device driver may resume normal operations */ void (*error_resume)(struct pci_dev *dev);/* Link Reset Capability - AER service driver specific */ -pci_ers_result_t (*reset_link) (struct pci_dev *dev); +pci_ers_result_t (*reset_link)(struct pci_dev *dev);int port_type;/* Type of the port this driver can handle */ u32 service;/* Port service this device represents */ Signature · 1 line
2.5.0
Thanks, I will do that next time :)
Quoted 51 lines · Bjorn Helgaas
Quoted 4 lines · Benjamin Young
Made spacing more consistent in the code for function pointer declarations based on checkpatch.pl
Signed-off-by Benjamin Young <[email protected]>Applied to pci/misc for v4.21, thanks!
I also made similar changes to
include/linux/pci.h. For trivial changes like this I like to fix similar issues in all of PCI at the same time.Quoted 39 lines
--- drivers/pci/pcie/portdrv.h | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)drivers/pci/pcie/portdrv.h +8
-9@@ -71,19 +71,19 @@ static inline void *get_service_data(struct pcie_device *dev)struct pcie_port_service_driver {const char *name; -int (*probe) (struct pcie_device *dev); -void (*remove) (struct pcie_device *dev); -int (*suspend) (struct pcie_device *dev); -int (*resume_noirq) (struct pcie_device *dev); -int (*resume) (struct pcie_device *dev); -int (*runtime_suspend) (struct pcie_device *dev); -int (*runtime_resume) (struct pcie_device *dev); +int (*probe)(struct pcie_device *dev); +void (*remove)(struct pcie_device *dev); +int (*suspend)(struct pcie_device *dev); +int (*resume_noirq)(struct pcie_device *dev); +int (*resume)(struct pcie_device *dev); +int (*runtime_suspend)(struct pcie_device *dev); +int (*runtime_resume)(struct pcie_device *dev);/* Device driver may resume normal operations */ void (*error_resume)(struct pci_dev *dev);/* Link Reset Capability - AER service driver specific */ -pci_ers_result_t (*reset_link) (struct pci_dev *dev); +pci_ers_result_t (*reset_link)(struct pci_dev *dev);int port_type;/* Type of the port this driver can handle */ u32 service;/* Port service this device represents */ --2.5.0