Skip to contentSkip to conversation

eudev: fix build with kernel < 4.8

PATCH New Fabrice Fontaine 3 participants 3 messages Dec 5, 2018 – Dec 6, 2018

lore
Share & tools
lore

Fabrice Fontaine

author
#0 lore raw

PATCH 1/1 eudev: fix build with kernel < 4.8

KEY_ALS_TOGGLE has been added in kernel 4.8 with
https://github.com/torvalds/linux/commit/9ee27487127461b5cf71670b708ed5b2b8da568c

So add it to missing.h to fix build with kernel older than 4.8

Fixes:
- http://autobuild.buildroot.org/results/0c0aff02df91cdb869efa01e397f7ccc0d9f69af

Signed-off-by Fabrice Fontaine <[email protected]>
---
 .../eudev/0002-missing.h-add-KEY_ALS_TOGGLE.patch  | 34 ++++++++++++++++++++++
 1 file changed, 34 insertions(+)
 create mode 100644 package/eudev/0002-missing.h-add-KEY_ALS_TOGGLE.patch
package/eudev/0002-missing.h-add-KEY_ALS_TOGGLE.patch new file +34 -0
new file mode 100644
index 0000000000..93d3f6d696
@@ -0,0 +1,34 @@
+From cad87bd3d8aa9046af0872e8c22f4a3c8fafdc78 Mon Sep 17 00:00:00 2001
+From: Fabrice Fontaine <[email protected]>
+Date: Tue, 4 Dec 2018 22:38:37 +0100
+Subject: [PATCH] missing.h: add KEY_ALS_TOGGLE
+
+KEY_ALS_TOGGLE has been added in kernel 4.8 with
+https://github.com/torvalds/linux/commit/9ee27487127461b5cf71670b708ed5b2b8da568c
+
+So add it to missing.h to fix build with kernel older than 4.8
+
+Fixes:
+ - http://autobuild.buildroot.org/results/0c0aff02df91cdb869efa01e397f7ccc0d9f69af
+
+Signed-off-by: Fabrice Fontaine <[email protected]>
+[Upstream status: https://github.com/gentoo/eudev/pull/162]
+---
+ src/shared/missing.h | 4 ++++
+ 1 file changed, 4 insertions(+)
+
+diff --git a/src/shared/missing.h b/src/shared/missing.h
+index bebbb42be..b5b2e1194 100644
+--- a/src/shared/missing.h
++++ b/src/shared/missing.h
+@@ -179,3 +179,7 @@ static inline int name_to_handle_at(int fd, const char *name, struct file_handle
+ #ifndef INPUT_PROP_MAX
+ #define INPUT_PROP_MAX 0x1f
+ #endif
++
++#ifndef KEY_ALS_TOGGLE
++#define KEY_ALS_TOGGLE 0x7a
++#endif
+-- 
+2.14.1
+
Signature · 1 line
2.14.1
#1 lore raw

PATCH 1/1 eudev: fix build with kernel < 4.8

Fabrice,

Quoted 21 lines · Fabrice Fontaine

KEY_ALS_TOGGLE has been added in kernel 4.8 with
https://github.com/torvalds/linux/commit/9ee27487127461b5cf71670b708ed5b2b8da568c

So add it to missing.h to fix build with kernel older than 4.8

Fixes:
- http://autobuild.buildroot.org/results/0c0aff02df91cdb869efa01e397f7ccc0d9f69af

Signed-off-by Fabrice Fontaine <[email protected]>
---
 .../eudev/0002-missing.h-add-KEY_ALS_TOGGLE.patch  | 34 ++++++++++++++++++++++
 1 file changed, 34 insertions(+)
 create mode 100644 package/eudev/0002-missing.h-add-KEY_ALS_TOGGLE.patch
package/eudev/0002-missing.h-add-KEY_ALS_TOGGLE.patch new file +0 -0
new file mode 100644
index 0000000000..93d3f6d696

package/eudev/0002-missing.h-add-KEY_ALS_TOGGLE.patch line 10

Quoted 10 lines
package/eudev/0002-missing.h-add-KEY_ALS_TOGGLE.patch new file +10 -0
@@ -0,0 +1,34 @@
+From cad87bd3d8aa9046af0872e8c22f4a3c8fafdc78 Mon Sep 17 00:00:00 2001
+From: Fabrice Fontaine <[email protected]>
+Date: Tue, 4 Dec 2018 22:38:37 +0100
+Subject: [PATCH] missing.h: add KEY_ALS_TOGGLE
+
+KEY_ALS_TOGGLE has been added in kernel 4.8 with
+https://github.com/torvalds/linux/commit/9ee27487127461b5cf71670b708ed5b2b8da568c
+
+So add it to missing.h to fix build with kernel older than 4.8
+

Maybe good to add a link to your pull request in this patch's description (nice when they merge fast :-) )
https://github.com/gentoo/eudev/pull/162

Reviewed-by Matthew Weber <[email protected]>

Matt

Applied
#2 lore raw

PATCH 1/1 eudev: fix build with kernel < 4.8

In reply to Fabrice Fontaine

Hello,

Quoted 5 lines · Fabrice Fontaine

KEY_ALS_TOGGLE has been added in kernel 4.8 with
https://github.com/torvalds/linux/commit/9ee27487127461b5cf71670b708ed5b2b8da568c

So add it to missing.h to fix build with kernel older than 4.8

Quoted 8 lines

Fixes:
- http://autobuild.buildroot.org/results/0c0aff02df91cdb869efa01e397f7ccc0d9f69af

Signed-off-by Fabrice Fontaine <[email protected]>
---
 .../eudev/0002-missing.h-add-KEY_ALS_TOGGLE.patch  | 34 ++++++++++++++++++++++
 1 file changed, 34 insertions(+)
 create mode 100644 package/eudev/0002-missing.h-add-KEY_ALS_TOGGLE.patch

Applied to master after updating the upstream status in the patch, now that it has been merged upstream. Thanks a lot!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com