Skip to contentSkip to conversation

package/libiscsi: fix build due to warnings

PATCH New Yann E. MORIN 3 participants 8 messages Dec 4, 2018 – Dec 16, 2018

lore
Share & tools
lore

Yann E. MORIN

author
#0 lore raw

PATCH 1/1 package/libiscsi: fix build due to warnings

Fixes:

    http://autobuild.buildroot.org/results/55b/55bf50fc7dcd465b71b5757434887dd3d0b25abc/
    http://autobuild.buildroot.org/results/98d/98dcfe5c9fc3babd5c8d3116d5128d437715c44e/
Signed-off-by "Yann E. MORIN" <[email protected]>
---
 package/libiscsi/libiscsi.mk | 2 ++
 1 file changed, 2 insertions(+)
package/libiscsi/libiscsi.mk +2 -0
index 6c8600829c..c492865c51 100644
@@ -11,6 +11,8 @@ LIBISCSI_LICENSE_FILES = COPYING LICENCE-GPL-2.txt LICENCE-LGPL-2.1.txt
 LIBISCSI_INSTALL_STAGING = YES
 LIBISCSI_AUTORECONF = YES
 
+LIBISCSI_CONF_OPTS = --disable-werror
+
 # We need to create the m4 directory to make autoreconf work properly.
 define LIBISCSI_CREATE_M4_DIR
 	mkdir -p $(@D)/m4
Signature · 1 line
2.14.1
author
#1 lore raw

PATCH 1/1 package/libiscsi: do not built the manpages

The pre-rendered, bundled ones are still installed, though, but they get removed in target-finalize anyway.

Signed-off-by "Yann E. MORIN" <[email protected]>
---
 package/libiscsi/libiscsi.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/libiscsi/libiscsi.mk +1 -1
index c492865c51..a34069d7bf 100644
@@ -11,7 +11,7 @@ LIBISCSI_LICENSE_FILES = COPYING LICENCE-GPL-2.txt LICENCE-LGPL-2.1.txt
 LIBISCSI_INSTALL_STAGING = YES
 LIBISCSI_AUTORECONF = YES
 
-LIBISCSI_CONF_OPTS = --disable-werror
+LIBISCSI_CONF_OPTS = --disable-werror --disable-manpages
 
 # We need to create the m4 directory to make autoreconf work properly.
 define LIBISCSI_CREATE_M4_DIR
Signature · 1 line
2.14.1
author
#2 lore raw

PATCH 1/1 package/libiscsi: add optional dependency to cunit

libiscsi uses cunit for its test suite, and autodetexcts its presence.

Usually, we just try to disable tests altogether, but there is no way to do so. So, ensure proper ordering.

Note: there is an ac_cv_have_cunit variable, but it is not a true ac_cv* cache variable, and the value provided on the command line or environment is properly ignored.

Signed-off-by "Yann E. MORIN" <[email protected]>

---
Note: for the interesting parties, I've sent a bunch of enhacements to the configure script upstream:
https://github.com/sahlberg/libiscsi/pull/283

---
 package/libiscsi/libiscsi.mk | 4 ++++
 1 file changed, 4 insertions(+)
package/libiscsi/libiscsi.mk +4 -0
index a34069d7bf..2b26a1427c 100644
@@ -11,6 +11,10 @@ LIBISCSI_LICENSE_FILES = COPYING LICENCE-GPL-2.txt LICENCE-LGPL-2.1.txt
 LIBISCSI_INSTALL_STAGING = YES
 LIBISCSI_AUTORECONF = YES
 
+ifeq ($(BR2_PACKAGE_CUNIT),y)
+LIBISCSI_DEPENDENCIES += cunit
+endif
+
 LIBISCSI_CONF_OPTS = --disable-werror --disable-manpages
 
 # We need to create the m4 directory to make autoreconf work properly.
Signature · 1 line
2.14.1
Applied
#3 lore raw

PATCH 1/1 package/libiscsi: add optional dependency to cunit

Hello,

Quoted 11 lines · Yann E. MORIN

libiscsi uses cunit for its test suite, and autodetexcts its presence.

Usually, we just try to disable tests altogether, but there is no way to do so. So, ensure proper ordering.

Note: there is an ac_cv_have_cunit variable, but it is not a true ac_cv* cache variable, and the value provided on the command line or environment is properly ignored.

Signed-off-by "Yann E. MORIN" <[email protected]>
Quoted 7 lines

---
Note: for the interesting parties, I've sent a bunch of enhacements to the configure script upstream:
https://github.com/sahlberg/libiscsi/pull/283

---
 package/libiscsi/libiscsi.mk | 4 ++++
 1 file changed, 4 insertions(+)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Applied
#4 lore raw

PATCH 1/1 package/libiscsi: do not built the manpages

In reply to Yann E. MORIN

Hello,

Quoted 7 lines · Yann E. MORIN

The pre-rendered, bundled ones are still installed, though, but they get removed in target-finalize anyway.

Signed-off-by "Yann E. MORIN" <[email protected]>
---
 package/libiscsi/libiscsi.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Applied
#6 lore raw

PATCH 1/1 package/libiscsi: fix build due to warnings

In reply to Yann E. MORIN

Hello,

Quoted 8 lines · Yann E. MORIN

Fixes:

    http://autobuild.buildroot.org/results/55b/55bf50fc7dcd465b71b5757434887dd3d0b25abc/
    http://autobuild.buildroot.org/results/98d/98dcfe5c9fc3babd5c8d3116d5128d437715c44e/
Signed-off-by "Yann E. MORIN" <[email protected]>
---
 package/libiscsi/libiscsi.mk | 2 ++
 1 file changed, 2 insertions(+)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#7 lore raw

PATCH 1/1 package/libiscsi: fix build due to warnings

In reply to Yann E. MORIN
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

Fixes:

    http://autobuild.buildroot.org/results/55b/55bf50fc7dcd465b71b5757434887dd3d0b25abc/
    http://autobuild.buildroot.org/results/98d/98dcfe5c9fc3babd5c8d3116d5128d437715c44e/
Signed-off-by "Yann E. MORIN" <[email protected]>

Committed to 2018.02.x, 2018.08.x and 2018.11.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard