Remove CLK_IS_BASIC usage from clk drivers
Subsystems (6)
Stephen Boyd
maintainercover Remove CLK_IS_BASIC usage from clk drivers
A collection of patches to remove CLK_IS_BASIC from drivers that don't look to have any need for it. There are some files outside of drivers/clk/ that aren't include here because I'll send those patches to respective maintainers.
Stephen Boyd (8):
clk: renesas: Remove usage of CLK_IS_BASIC
clk: st: Remove usage of CLK_IS_BASIC
clk: axm5516: Remove usage of CLK_IS_BASIC
clk: h8300: Remove usage of CLK_IS_BASIC
clk: hisilicon: Remove usage of CLK_IS_BASIC
clk: versatile: sp810: Remove usage of CLK_IS_BASIC
clk: samsung: s3c2410: Remove usage of CLK_IS_BASIC
clk: Loongson1: Remove usage of CLK_IS_BASIC
drivers/clk/clk-axm5516.c | 2 -- drivers/clk/h8300/clk-h8s2678.c | 2 +- drivers/clk/hisilicon/clk-hi3620.c | 2 +- drivers/clk/hisilicon/clk-hisi-phase.c | 2 +- drivers/clk/hisilicon/clk-hix5hd2.c | 2 +- drivers/clk/hisilicon/clkgate-separated.c | 2 +- drivers/clk/loongson1/clk.c | 8 +++++--- drivers/clk/renesas/clk-div6.c | 2 +- drivers/clk/renesas/clk-mstp.c | 2 +- drivers/clk/renesas/r9a06g032-clocks.c | 8 ++++---- drivers/clk/renesas/rcar-gen3-cpg.c | 2 +- drivers/clk/renesas/renesas-cpg-mssr.c | 2 +- drivers/clk/samsung/clk-s3c2410-dclk.c | 2 +- drivers/clk/st/clk-flexgen.c | 2 +- drivers/clk/st/clkgen-fsyn.c | 4 ++-- drivers/clk/st/clkgen-pll.c | 2 +- drivers/clk/versatile/clk-sp810.c | 2 +- 17 files changed, 24 insertions(+), 24 deletions(-)
Signature · 1 line
Sent by a computer through tubes
Stephen Boyd
maintainerPATCH 1/8 clk: renesas: Remove usage of CLK_IS_BASIC
This flag doesn't look to be used by any code, just set in various clk init structures and then never tested again. Remove it from these drivers as it doesn't provide any benefit.
--- drivers/clk/renesas/clk-div6.c | 2 +- drivers/clk/renesas/clk-mstp.c | 2 +- drivers/clk/renesas/r9a06g032-clocks.c | 8 ++++---- drivers/clk/renesas/rcar-gen3-cpg.c | 2 +- drivers/clk/renesas/renesas-cpg-mssr.c | 2 +- 5 files changed, 8 insertions(+), 8 deletions(-)
drivers/clk/renesas/clk-div6.c +1 -1
@@ -274,7 +274,7 @@ struct clk * __init cpg_div6_register(const char *name,/* Register the clock. */ init.name = name; init.ops = &cpg_div6_clock_ops; - init.flags =CLK_IS_BASIC ; + init.flags =0 ; init.parent_names = parent_names; init.num_parents = valid_parents;
drivers/clk/renesas/clk-mstp.c +1 -1
@@ -158,7 +158,7 @@ static struct clk * __init cpg_mstp_clock_register(const char *name, init.name = name; init.ops = &cpg_mstp_clock_ops; - init.flags =CLK_IS_BASIC |CLK_SET_RATE_PARENT ; + init.flags =CLK_SET_RATE_PARENT ;/* INTC-SYS is the module clock of the GIC, and must not be disabled */ if (!strcmp (name,"intc-sys" )) {pr_debug ("MSTP %s setting CLK_IS_CRITICAL\n" , name);
drivers/clk/renesas/r9a06g032-clocks.c +4 -4
@@ -424,7 +424,7 @@ r9a06g032_register_gate(struct r9a06g032_priv *clocks, init.name = desc->name; init.ops = &r9a06g032_clk_gate_ops; - init.flags =CLK_IS_BASIC |CLK_SET_RATE_PARENT ; + init.flags =CLK_SET_RATE_PARENT ; init.parent_names = parent_name ? &parent_name :NULL ; init.num_parents = parent_name ?1 :0 ;
@@ -595,7 +595,7 @@ r9a06g032_register_div(struct r9a06g032_priv *clocks, init.name = desc->name; init.ops = &r9a06g032_clk_div_ops; - init.flags =CLK_IS_BASIC |CLK_SET_RATE_PARENT ; + init.flags =CLK_SET_RATE_PARENT ; init.parent_names = parent_name ? &parent_name :NULL ; init.num_parents = parent_name ?1 :0 ;
@@ -683,7 +683,7 @@ r9a06g032_register_bitsel(struct r9a06g032_priv *clocks, init.name = desc->name; init.ops = &clk_bitselect_ops; - init.flags =CLK_IS_BASIC |CLK_SET_RATE_PARENT ; + init.flags =CLK_SET_RATE_PARENT ; init.parent_names = names; init.num_parents =2 ;
@@ -777,7 +777,7 @@ r9a06g032_register_dualgate(struct r9a06g032_priv *clocks, init.name = desc->name; init.ops = &r9a06g032_clk_dualgate_ops; - init.flags =CLK_IS_BASIC |CLK_SET_RATE_PARENT ; + init.flags =CLK_SET_RATE_PARENT ; init.parent_names = &parent_name; init.num_parents =1 ; g->hw.init = &init;
drivers/clk/renesas/rcar-gen3-cpg.c +1 -1
@@ -368,7 +368,7 @@ static struct clk * __init cpg_sd_clk_register(const struct cpg_core_clk *core, init.name = core->name; init.ops = &cpg_sd_clock_ops; - init.flags =CLK_IS_BASIC |CLK_SET_RATE_PARENT ; + init.flags =CLK_SET_RATE_PARENT ; init.parent_names = &parent_name; init.num_parents =1 ;
drivers/clk/renesas/renesas-cpg-mssr.c +1 -1
@@ -412,7 +412,7 @@ static void __init cpg_mssr_register_mod_clk(const struct mssr_mod_clk *mod, init.name = mod->name; init.ops = &cpg_mstp_clock_ops; - init.flags =CLK_IS_BASIC |CLK_SET_RATE_PARENT ; + init.flags =CLK_SET_RATE_PARENT ;for (i =0 ; i < info->num_crit_mod_clks; i++)if (id == info->crit_mod_clks[i]) { dev_dbg(dev, "MSTP %s setting CLK_IS_CRITICAL\n",
Signature · 1 line
Sent by a computer through tubes
Re: [PATCH 1/8] clk: renesas: Remove usage of CLK_IS_BASIC
Hi Stephen,
Quoted 7 lines · Stephen Boyd
This flag doesn't look to be used by any code, just set in various clk init structures and then never tested again. Remove it from these drivers as it doesn't provide any benefit.
Cc Geert Uytterhoeven <[email protected]>Cc <[email protected]>Signed-off-by Stephen Boyd <[email protected]>
Thanks!
I assume you want to apply this yourself, with the rest of the series?
Gr{oetje,eeting}s,
Geert
Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Stephen Boyd
maintainerRe: [PATCH 1/8] clk: renesas: Remove usage of CLK_IS_BASIC
Quoting Geert Uytterhoeven (2018-12-07 00:27:11)
Quoted 11 lines
Hi Stephen,
Quoted 7 lines · Stephen Boyd
This flag doesn't look to be used by any code, just set in various clk init structures and then never tested again. Remove it from these drivers as it doesn't provide any benefit.
Cc Geert Uytterhoeven <[email protected]>Cc <[email protected]>Signed-off-by Stephen Boyd <[email protected]>
Quoted 6 lines
Thanks!
Reviewed-by Geert Uytterhoeven <[email protected]>I assume you want to apply this yourself, with the rest of the series?
Yes I'll apply it to clk-next. Thanks.
Re: [PATCH 1/8] clk: renesas: Remove usage of CLK_IS_BASIC
In reply to Stephen BoydQuoting Stephen Boyd (2018-12-06 13:58:51)
Quoted 8 lines
This flag doesn't look to be used by any code, just set in various clk init structures and then never tested again. Remove it from these drivers as it doesn't provide any benefit.
Cc Geert Uytterhoeven <[email protected]>Cc <[email protected]>Signed-off-by Stephen Boyd <[email protected]>---
Applied to clk-next
Stephen Boyd
maintainerPATCH 2/8 clk: st: Remove usage of CLK_IS_BASIC
In reply to Stephen BoydThis flag doesn't look to be used by any code, just set in various clk init structures and then never tested again. Remove it from these drivers as it doesn't provide any benefit.
--- drivers/clk/st/clk-flexgen.c | 2 +- drivers/clk/st/clkgen-fsyn.c | 4 ++-- drivers/clk/st/clkgen-pll.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)
drivers/clk/st/clk-flexgen.c +1 -1
@@ -210,7 +210,7 @@ static struct clk *clk_register_flexgen(const char *name, init.name = name; init.ops = &flexgen_ops; - init.flags =CLK_IS_BASIC |CLK_GET_RATE_NOCACHE | flexgen_flags; + init.flags =CLK_GET_RATE_NOCACHE | flexgen_flags; init.parent_names = parent_names; init.num_parents = num_parents;
drivers/clk/st/clkgen-fsyn.c +2 -2
@@ -404,7 +404,7 @@ static struct clk * __init st_clk_register_quadfs_pll( init.name = name; init.ops = quadfs->pll_ops; - init.flags =CLK_IS_BASIC |CLK_GET_RATE_NOCACHE ; + init.flags =CLK_GET_RATE_NOCACHE ; init.parent_names = &parent_name; init.num_parents =1 ;
@@ -843,7 +843,7 @@ static struct clk * __init st_clk_register_quadfs_fsynth( init.name = name; init.ops = &st_quadfs_ops; - init.flags = flags |CLK_GET_RATE_NOCACHE |CLK_IS_BASIC ; + init.flags = flags |CLK_GET_RATE_NOCACHE ; init.parent_names = &parent_name; init.num_parents =1 ;
drivers/clk/st/clkgen-pll.c +1 -1
@@ -613,7 +613,7 @@ static struct clk * __init clkgen_pll_register(const char *parent_name, init.name = clk_name; init.ops = pll_data->ops; - init.flags = pll_flags |CLK_IS_BASIC |CLK_GET_RATE_NOCACHE ; + init.flags = pll_flags |CLK_GET_RATE_NOCACHE ; init.parent_names = &parent_name; init.num_parents =1 ;
Signature · 1 line
Sent by a computer through tubes
Re: [PATCH 2/8] clk: st: Remove usage of CLK_IS_BASIC
Quoting Stephen Boyd (2018-12-06 13:58:52)
Quoted 6 lines
This flag doesn't look to be used by any code, just set in various clk init structures and then never tested again. Remove it from these drivers as it doesn't provide any benefit.
Signed-off-by Stephen Boyd <[email protected]>---
Applied to clk-next
Stephen Boyd
maintainerPATCH 3/8 clk: axm5516: Remove usage of CLK_IS_BASIC
In reply to Stephen BoydThis flag doesn't look to be used by any code, just set in various clk init structures and then never tested again. Remove it from these drivers as it doesn't provide any benefit.
--- drivers/clk/clk-axm5516.c | 2 -- 1 file changed, 2 deletions(-)
drivers/clk/clk-axm5516.c +0 -2
@@ -311,7 +311,6 @@ static struct axxia_divclk clk_per_div = {"clk_sm1_pll" }, .num_parents = 1, - .flags = CLK_IS_BASIC, .ops = &axxia_divclk_ops, }, .reg = 0x1000c,
@@ -326,7 +325,6 @@ static struct axxia_divclk clk_mmc_div = {"clk_sm1_pll" }, .num_parents = 1, - .flags = CLK_IS_BASIC, .ops = &axxia_divclk_ops, }, .reg = 0x1000c,
Signature · 1 line
Sent by a computer through tubes
Re: [PATCH 3/8] clk: axm5516: Remove usage of CLK_IS_BASIC
Quoting Stephen Boyd (2018-12-06 13:58:53)
Quoted 7 lines
This flag doesn't look to be used by any code, just set in various clk init structures and then never tested again. Remove it from these drivers as it doesn't provide any benefit.
Cc Anders Berg <[email protected]>Signed-off-by Stephen Boyd <[email protected]>---
Applied to clk-next
Stephen Boyd
maintainerPATCH 4/8 clk: h8300: Remove usage of CLK_IS_BASIC
In reply to Stephen BoydThis flag doesn't look to be used by any code, just set in various clk init structures and then never tested again. Remove it from these drivers as it doesn't provide any benefit.
--- drivers/clk/h8300/clk-h8s2678.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/h8300/clk-h8s2678.c +1 -1
@@ -117,7 +117,7 @@ static void __init h8s2678_pll_clk_setup(struct device_node *node) parent_name =of_clk_get_parent_name (node,0 ); init.name = clk_name; init.ops = &pll_ops; - init.flags =CLK_IS_BASIC ; + init.flags =0 ; init.parent_names = &parent_name; init.num_parents =1 ; pll_clock->hw.init = &init;
Signature · 1 line
Sent by a computer through tubes
Re: [PATCH 4/8] clk: h8300: Remove usage of CLK_IS_BASIC
Quoting Stephen Boyd (2018-12-06 13:58:54)
Quoted 8 lines
This flag doesn't look to be used by any code, just set in various clk init structures and then never tested again. Remove it from these drivers as it doesn't provide any benefit.
Cc Yoshinori Sato <[email protected]>Cc <[email protected]>Signed-off-by Stephen Boyd <[email protected]>---
Applied to clk-next
Stephen Boyd
maintainerPATCH 5/8 clk: hisilicon: Remove usage of CLK_IS_BASIC
In reply to Stephen BoydThis flag doesn't look to be used by any code, just set in various clk init structures and then never tested again. Remove it from these drivers as it doesn't provide any benefit.
--- drivers/clk/hisilicon/clk-hi3620.c | 2 +- drivers/clk/hisilicon/clk-hisi-phase.c | 2 +- drivers/clk/hisilicon/clk-hix5hd2.c | 2 +- drivers/clk/hisilicon/clkgate-separated.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)
drivers/clk/hisilicon/clk-hi3620.c +1 -1
@@ -435,7 +435,7 @@ static struct clk *hisi_register_clk_mmc(struct hisi_mmc_clock *mmc_clk, init.name = mmc_clk->name; init.ops = &clk_mmc_ops; - init.flags = mmc_clk->flags |CLK_IS_BASIC ; + init.flags = mmc_clk->flags; init.parent_names = (mmc_clk->parent_name ? &mmc_clk->parent_name :NULL ); init.num_parents = (mmc_clk->parent_name ?1 :0 ); mclk->hw.init = &init;
drivers/clk/hisilicon/clk-hisi-phase.c +1 -1
@@ -103,7 +103,7 @@ struct clk *clk_register_hisi_phase(struct device *dev, init.name = clks->name; init.ops = &clk_phase_ops; - init.flags = clks->flags |CLK_IS_BASIC ; + init.flags = clks->flags; init.parent_names = clks->parent_names ? &clks->parent_names :NULL ; init.num_parents = clks->parent_names ?1 :0 ;
drivers/clk/hisilicon/clk-hix5hd2.c +1 -1
@@ -274,7 +274,7 @@ hix5hd2_clk_register_complex(struct hix5hd2_complex_clock *clks, int nums,else init.ops = &clk_complex_ops; - init.flags =CLK_IS_BASIC ; + init.flags =0 ; init.parent_names = (clks[i].parent_name ? &clks[i].parent_name :NULL ); init.num_parents = (clks[i].parent_name ?1 :0 );
drivers/clk/hisilicon/clkgate-separated.c +1 -1
@@ -110,7 +110,7 @@ struct clk *hisi_register_clkgate_sep(struct device *dev, const char *name, init.name = name; init.ops = &clkgate_separated_ops; - init.flags = flags |CLK_IS_BASIC ; + init.flags = flags; init.parent_names = (parent_name ? &parent_name :NULL ); init.num_parents = (parent_name ?1 :0 );
Signature · 1 line
Sent by a computer through tubes
Re: [PATCH 5/8] clk: hisilicon: Remove usage of CLK_IS_BASIC
Quoting Stephen Boyd (2018-12-06 13:58:55)
Quoted 10 lines
This flag doesn't look to be used by any code, just set in various clk init structures and then never tested again. Remove it from these drivers as it doesn't provide any benefit.
Cc Jiancheng Xue <[email protected]>Cc Leo Yan <[email protected]>Cc Jianguo Sun <[email protected]>Cc Wei Yongjun <[email protected]>Signed-off-by Stephen Boyd <[email protected]>---
Applied to clk-next
Stephen Boyd
maintainerPATCH 6/8 clk: versatile: sp810: Remove usage of CLK_IS_BASIC
In reply to Stephen BoydThis flag doesn't look to be used by any code, just set in the clk init structure and then never tested again. Remove it from this driver as it doesn't provide any benefit.
--- drivers/clk/versatile/clk-sp810.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/versatile/clk-sp810.c +1 -1
@@ -111,7 +111,7 @@ static void __init clk_sp810_of_setup(struct device_node *node) init.name = name; init.ops = &clk_sp810_timerclken_ops; - init.flags =CLK_IS_BASIC ; + init.flags =0 ; init.parent_names = parent_names; init.num_parents = num;
Signature · 1 line
Sent by a computer through tubes
Re: [PATCH 6/8] clk: versatile: sp810: Remove usage of CLK_IS_BASIC
Quoted 6 lines · Stephen Boyd
This flag doesn't look to be used by any code, just set in the clk init structure and then never tested again. Remove it from this driver as it doesn't provide any benefit.
Cc Linus Walleij <[email protected]>Signed-off-by Stephen Boyd <[email protected]>
Can't help but wonder what semantic it was supposed to have. It seems a bit vague now.
Yours,
Linus Walleij
Re: [PATCH 6/8] clk: versatile: sp810: Remove usage of CLK_IS_BASIC
In reply to Stephen BoydQuoting Stephen Boyd (2018-12-06 13:58:56)
Quoted 7 lines
This flag doesn't look to be used by any code, just set in the clk init structure and then never tested again. Remove it from this driver as it doesn't provide any benefit.
Cc Linus Walleij <[email protected]>Signed-off-by Stephen Boyd <[email protected]>---
Applied to clk-next
Stephen Boyd
maintainerPATCH 7/8 clk: samsung: s3c2410: Remove usage of CLK_IS_BASIC
In reply to Stephen BoydThis flag doesn't look to be used by any code, just set in the clk init structure and then never tested again. Remove it from this drivers as it doesn't provide any benefit.
--- drivers/clk/samsung/clk-s3c2410-dclk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/samsung/clk-s3c2410-dclk.c +1 -1
@@ -105,7 +105,7 @@ static struct clk_hw *s3c24xx_register_clkout(struct device *dev, init.name = name; init.ops = &s3c24xx_clkout_ops; - init.flags =CLK_IS_BASIC ; + init.flags =0 ; init.parent_names = parent_names; init.num_parents = num_parents;
Signature · 1 line
Sent by a computer through tubes
Re: [PATCH 7/8] clk: samsung: s3c2410: Remove usage of CLK_IS_BASIC
Quoted 5 lines · Stephen Boyd
This flag doesn't look to be used by any code, just set in the clk init structure and then never tested again. Remove it from this drivers as it doesn't provide any benefit.
Quoted 7 lines
Cc Kukjin Kim <[email protected]>Cc Krzysztof Kozlowski <[email protected]>Cc Sylwester Nawrocki <[email protected]>Signed-off-by Stephen Boyd <[email protected]>--- drivers/clk/samsung/clk-s3c2410-dclk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Best regards,
Krzysztof
Re: [PATCH 7/8] clk: samsung: s3c2410: Remove usage of CLK_IS_BASIC
In reply to Stephen BoydQuoting Stephen Boyd (2018-12-06 13:58:57)
Quoted 9 lines
This flag doesn't look to be used by any code, just set in the clk init structure and then never tested again. Remove it from this drivers as it doesn't provide any benefit.
Cc Kukjin Kim <[email protected]>Cc Krzysztof Kozlowski <[email protected]>Cc Sylwester Nawrocki <[email protected]>Signed-off-by Stephen Boyd <[email protected]>---
Applied to clk-next
Stephen Boyd
maintainerPATCH 8/8 clk: Loongson1: Remove usage of CLK_IS_BASIC
In reply to Stephen BoydThis flag doesn't look to be used by any code, just set in the clk init structure and then never tested again. Remove it from this driver as it doesn't provide any benefit. Also remove parenthesis nearby that are not needed and include clk.h to fix a sparse warning about static function definition.
--- drivers/clk/loongson1/clk.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/clk/loongson1/clk.c +5 -3
@@ -10,6 +10,8 @@#include <linux/clk-provider.h> #include <linux/slab.h> +#include "clk.h" + struct clk_hw *__init clk_hw_register_pll(struct device *dev, const char *name, const char *parent_name,
@@ -27,9 +29,9 @@ struct clk_hw *__init clk_hw_register_pll(struct device *dev, init.name = name; init.ops = ops; - init.flags = flags |CLK_IS_BASIC ; - init.parent_names = (parent_name ? &parent_name :NULL ); - init.num_parents = (parent_name ?1 :0 ); + init.flags = flags; + init.parent_names = parent_name ? &parent_name :NULL ; + init.num_parents = parent_name ?1 :0 ; hw->init = &init;/* register the clock */
Signature · 1 line
Sent by a computer through tubes
Re: [PATCH 8/8] clk: Loongson1: Remove usage of CLK_IS_BASIC
Quoting Stephen Boyd (2018-12-06 13:58:58)
Quoted 8 lines
This flag doesn't look to be used by any code, just set in the clk init structure and then never tested again. Remove it from this driver as it doesn't provide any benefit. Also remove parenthesis nearby that are not needed and include
clk.hto fix a sparse warning about static function definition.Signed-off-by Stephen Boyd <[email protected]>---
Applied to clk-next