Skip to contentSkip to conversation

linux-next: Signed-off-by missing for commit in the sound-asoc tree

PATCH New Stephen Rothwell 2 participants 2 messages Dec 6, 2018

Subsystems (3)
Sound Linux-next tree ASoC
lore
Share & tools
lore

Stephen Rothwell

author
#0 lore raw

Hi all,

Commit

972fd1f58267 ("ASoC: max9867: Remove useless assignment")

is missing a Signed-off-by from its author.

Signature · 2 lines
Cheers,
Stephen Rothwell
#1 lore raw

PATCH v2 1/1 ASoC: max9867: Remove useless assignment

ret is assigned later, no need to initialize it.

Signed-off-by Ladislav Michl <[email protected]>

---
CHANGES:
-v2: add missing Signed-off-by
(I'm sorry for that...)

 sound/soc/codecs/max9867.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
sound/soc/codecs/max9867.c +2 -4
index 1cda54b59854..1b155f40b106 100644
@@ -476,7 +476,7 @@ static int max9867_i2c_probe(struct i2c_client *i2c,
 		const struct i2c_device_id *id)
 {
 	struct max9867_priv *max9867;
-	int ret = 0, reg;
+	int ret, reg;
 
 	max9867 = devm_kzalloc(&i2c->dev, sizeof(*max9867), GFP_KERNEL);
 	if (!max9867)

@@ -497,10 +497,8 @@ static int max9867_i2c_probe(struct i2c_client *i2c,
 	dev_info(&i2c->dev, "device revision: %x\n", reg);
 	ret = devm_snd_soc_register_component(&i2c->dev, &max9867_component,
 			max9867_dai, ARRAY_SIZE(max9867_dai));
-	if (ret < 0) {
+	if (ret < 0)
 		dev_err(&i2c->dev, "Failed to register component: %d\n", ret);
-		return ret;
-	}
 	return ret;
 }
Signature · 1 line
2.20.0.rc2