dmaengine: dw: Add missed multi-block support for iDMA 32-bit
Subsystems (2)
PATCH v2 1/7 dmaengine: dw: Add missed multi-block support for iDMA 32-bit
Quoted 11 lines · Vinod Koul
Quoted 6 lines · Andy Shevchenko
Intel integrated DMA 32-bit support multi-block transfers. Add missed setting to the platform data.
Fixes f7c799e950f9 ("dmaengine: dw: we do support Merrifield SoC in PCI mode")Signed-off-by Andy Shevchenko <[email protected]>How is this a stable material? It would improve performance by using multi blocks but given the fact that this is used for slow peripherals, do you really see a user impact?
Last my testing was done with SPI VGA panel connected and I ran few FB based tests with more or less good FPS numbers. So, I can't tell about notable user impact. Feel free not to add for stable.
Btw, I have tested via DMA test, where it's indeed at least visible, but still memory-to-memory is not what that DMA is used for.
Quoted 21 lines
Quoted 18 lines
--- drivers/dma/dw/pci.c | 1 + 1 file changed, 1 insertion(+)drivers/dma/dw/pci.c +1
-0@@ -25,6 +25,7 @@ static struct dw_dma_platform_data mrfld_pdata = { .block_size = 131071, .nr_masters = 1, .data_width = {4}, + .multi_block = {1, 1, 1, 1, 1, 1, 1, 1}, };static int dw_pci_probe (struct pci_dev *pdev,const struct pci_device_id *pid)Signature · 1 line
2.19.2Signature · 1 line
~Vinod