Skip to contentSkip to conversation

dt-bindings: eeprom: at24: add "atmel,24c2048"

PATCH In review Adrian Bunk 4 participants 5 messages Nov 29, 2018 – Dec 7, 2018

Subsystems (2)
Device tree bindings Char and misc drivers
lore
Share & tools
lore

Adrian Bunk

author
#0 lore raw

PATCH v4 1/2 dt-bindings: eeprom: at24: add "atmel,24c2048"

Signed-off-by Adrian Bunk <[email protected]>
---
 Documentation/devicetree/bindings/eeprom/at24.txt | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/eeprom/at24.txt +1 -0
index aededdbc262b..f9a7c984274c 100644
@@ -27,6 +27,7 @@ Required properties:
                 "atmel,24c256",
                 "atmel,24c512",
                 "atmel,24c1024",
+                "atmel,24c2048",
 
                 If <manufacturer> is not "atmel", then a fallback must be used
                 with the same <model> and "atmel" as manufacturer.
Signature · 1 line
2.11.0
author
#1 lore raw

PATCH v4 2/2 eeprom: at24: Add 24c2048

Works with an ST M24M02.

Signed-off-by Adrian Bunk <[email protected]>
---
 drivers/misc/eeprom/Kconfig | 2 +-
 drivers/misc/eeprom/at24.c  | 3 +++
 2 files changed, 4 insertions(+), 1 deletion(-)
drivers/misc/eeprom/Kconfig +1 -1
index fe7a1d27a017..a846faefa210 100644
@@ -13,7 +13,7 @@ config EEPROM_AT24
 	  ones like at24c64, 24lc02 or fm24c04:
 
 	     24c00, 24c01, 24c02, spd (readonly 24c02), 24c04, 24c08,
-	     24c16, 24c32, 24c64, 24c128, 24c256, 24c512, 24c1024
+	     24c16, 24c32, 24c64, 24c128, 24c256, 24c512, 24c1024, 24c2048
 
 	  Unless you like data loss puzzles, always be sure that any chip
 	  you configure as a 24c32 (32 kbit) or larger is NOT really a
drivers/misc/eeprom/at24.c +3 -0
index 636ed7149793..ddfcf4ade7bf 100644
@@ -156,6 +156,7 @@ AT24_CHIP_DATA(at24_data_24c128, 131072 / 8, AT24_FLAG_ADDR16);
 AT24_CHIP_DATA(at24_data_24c256, 262144 / 8, AT24_FLAG_ADDR16);
 AT24_CHIP_DATA(at24_data_24c512, 524288 / 8, AT24_FLAG_ADDR16);
 AT24_CHIP_DATA(at24_data_24c1024, 1048576 / 8, AT24_FLAG_ADDR16);
+AT24_CHIP_DATA(at24_data_24c2048, 2097152 / 8, AT24_FLAG_ADDR16);
 /* identical to 24c08 ? */
 AT24_CHIP_DATA(at24_data_INT3499, 8192 / 8, 0);
 

@@ -182,6 +183,7 @@ static const struct i2c_device_id at24_ids[] = {
 	{ "24c256",	(kernel_ulong_t)&at24_data_24c256 },
 	{ "24c512",	(kernel_ulong_t)&at24_data_24c512 },
 	{ "24c1024",	(kernel_ulong_t)&at24_data_24c1024 },
+	{ "24c2048",    (kernel_ulong_t)&at24_data_24c2048 },
 	{ "at24",	0 },
 	{ /* END OF LIST */ }
 };

@@ -210,6 +212,7 @@ static const struct of_device_id at24_of_match[] = {
 	{ .compatible = "atmel,24c256",		.data = &at24_data_24c256 },
 	{ .compatible = "atmel,24c512",		.data = &at24_data_24c512 },
 	{ .compatible = "atmel,24c1024",	.data = &at24_data_24c1024 },
+	{ .compatible = "atmel,24c2048",	.data = &at24_data_24c2048 },
 	{ /* END OF LIST */ },
 };
 MODULE_DEVICE_TABLE(of, at24_of_match);
Signature · 1 line
2.11.0
#2 lore raw
In reply to Adrian Bunk

czw., 29 lis 2018 o 20:59 Adrian Bunk <[email protected]> napisał(a):

Quoted 19 lines
Signed-off-by Adrian Bunk <[email protected]>
---
 Documentation/devicetree/bindings/eeprom/at24.txt | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/eeprom/at24.txt +1 -1
index aededdbc262b..f9a7c984274c 100644
@@ -27,6 +27,7 @@ Required properties:
                 "atmel,24c256",
                 "atmel,24c512",
                 "atmel,24c1024",
+                "atmel,24c2048",
 
                 If <manufacturer> is not "atmel", then a fallback must be used
                 with the same <model> and "atmel" as manufacturer.
--
Quoted 2 lines

2.11.0

Hi Rob,

this is a trivial patch - can we have your Ack so that I can send my PR to Wolfram for 4.21?

Thanks in advance,
Bartosz

#3 lore raw
Quoted 3 lines

this is a trivial patch - can we have your Ack so that I can send my PR to Wolfram for 4.21?

I think it is OK for trivial patches to go without Rob's explicit ack. At least this is how I handle it and I think I agreed long time ago with him about that...

maintainer Acked-by
#4 lore raw
Quoted 3 lines · Wolfram Sang
Quoted 3 lines

this is a trivial patch - can we have your Ack so that I can send my PR to Wolfram for 4.21?

Pinging won't help. You can check my queue in patchwork.

Quoted 4 lines

I think it is OK for trivial patches to go without Rob's explicit ack. At least this is how I handle it and I think I agreed long time ago with him about that...

Indeed. In case you still want it:

Acked-by Rob Herring <[email protected]>