Skip to contentSkip to conversation

spl/tpl: change banner into upper case

RFC PATCH In review Heiko Schocher 3 participants 3 messages Dec 5, 2018 – Dec 7, 2018

lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 spl/tpl: change banner into upper case

commit d6330064634a ("spl: Add a define for SPL_TPL_PROMPT")

changes the SPL/TPL banner from upper case into lower case. As SPL and TPL are three-letter acronyms and they are written in upper case, change it back to upper case.

---

 include/spl.h                  | 4 ++--
 test/py/u_boot_console_base.py | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
include/spl.h +2 -2
index ee92832f0a..ff4e6277d3 100644
@@ -52,9 +52,9 @@ static inline bool u_boot_first_phase(void)
 /* A string name for SPL or TPL */
 #ifdef CONFIG_SPL_BUILD
 # ifdef CONFIG_TPL_BUILD
-#  define SPL_TPL_NAME	"tpl"
+#  define SPL_TPL_NAME	"TPL"
 # else
-#  define SPL_TPL_NAME	"spl"
+#  define SPL_TPL_NAME	"SPL"
 # endif
 # define SPL_TPL_PROMPT	SPL_TPL_NAME ": "
 #else
test/py/u_boot_console_base.py +1 -1
index e044eb3ea1..326b2ac51f 100644
@@ -16,7 +16,7 @@ import sys
 import u_boot_spawn
 
 # Regexes for text we expect U-Boot to send to the console.
-pattern_u_boot_spl_signon = re.compile('(U-Boot spl \\d{4}\\.\\d{2}[^\r\n]*\\))')
+pattern_u_boot_spl_signon = re.compile('(U-Boot SPL \\d{4}\\.\\d{2}[^\r\n]*\\))')
 pattern_u_boot_main_signon = re.compile('(U-Boot \\d{4}\\.\\d{2}[^\r\n]*\\))')
 pattern_stop_autoboot_prompt = re.compile('Hit any key to stop autoboot: ')
 pattern_unknown_command = re.compile('Unknown command \'.*\' - try \'help\'')
Signature · 1 line
2.17.2
#1 lore raw

RFC PATCH 1/1 spl/tpl: change banner into upper case

Quoted 7 lines · Heiko Schocher

commit d6330064634a ("spl: Add a define for SPL_TPL_PROMPT")

changes the SPL/TPL banner from upper case into lower case. As SPL and TPL are three-letter acronyms and they are written in upper case, change it back to upper case.

Quoted 6 lines

---

 include/spl.h                  | 4 ++--
 test/py/u_boot_console_base.py | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

Oh well, I liked them like that :-)

#2 lore raw
In reply to Heiko Schocher
Quoted 8 lines · Heiko Schocher

commit d6330064634a ("spl: Add a define for SPL_TPL_PROMPT")

changes the SPL/TPL banner from upper case into lower case. As SPL and TPL are three-letter acronyms and they are written in upper case, change it back to upper case.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181207/4a5b8cb6/attachment.sig>