Skip to contentSkip to conversation

selftests/vm/gup_benchmark.c: match gup struct to kernel

PATCH In review Alison Schofield 3 participants 4 messages Dec 8, 2018 – Jan 15, 2019 Kselftest

lore
Share & tools
lore

Alison Schofield

author
#0 lore raw

PATCH 1/1 selftests/vm/gup_benchmark.c: match gup struct to kernel

An expansion field was added to the kernel copy of this structure for future use. See mm/gup_benchmark.c.

Add the same expansion field here, so that the IOCTL command decodes correctly. Otherwise, it fails with EINVAL.

Signed-off-by Alison Schofield <[email protected]>
---
 tools/testing/selftests/vm/gup_benchmark.c | 1 +
 1 file changed, 1 insertion(+)
tools/testing/selftests/vm/gup_benchmark.c +1 -0
index 880b96fc80d4..c0534e298b51 100644
@@ -25,6 +25,7 @@ struct gup_benchmark {
 	__u64 size;
 	__u32 nr_pages_per_call;
 	__u32 flags;
+	__u64 expansion[10];	/* For future use */
 };
 
 int main(int argc, char **argv)
Signature · 1 line
2.14.1
Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Alison Schofield

An expansion field was added to the kernel copy of this structure for future use. See mm/gup_benchmark.c.

Add the same expansion field here, so that the IOCTL command decodes correctly. Otherwise, it fails with EINVAL.

Signed-off-by Alison Schofield <alison.schofield at intel.com>
Acked-by Kirill A. Shutemov <kirill.shutemov at linux.intel.com>
Signature · 1 line
 Kirill A. Shutemov
#2 lore raw

PATCH 1/1 selftests/vm/gup_benchmark.c: match gup struct to kernel

In reply to Alison Schofield

Hi Shauh,

Ping on this one. It has Kirill's ACK. Without this fix the gup_benchmark fails to run (at all).

Thanks!
Alison

Quoted 7 lines · Alison Schofield

An expansion field was added to the kernel copy of this structure for future use. See mm/gup_benchmark.c.

Add the same expansion field here, so that the IOCTL command decodes correctly. Otherwise, it fails with EINVAL.

Signed-off-by Alison Schofield <alison.schofield at intel.com>
Acked-by Kirill A. Shutemov <kirill.shutemov at linux.intel.com>
Quoted 19 lines
---
 tools/testing/selftests/vm/gup_benchmark.c | 1 +
 1 file changed, 1 insertion(+)
tools/testing/selftests/vm/gup_benchmark.c +1 -0
index 880b96fc80d4..c0534e298b51 100644
@@ -25,6 +25,7 @@ struct gup_benchmark {
 	__u64 size;
 	__u32 nr_pages_per_call;
 	__u32 flags;
+	__u64 expansion[10];	/* For future use */
 };
 
 int main(int argc, char **argv)
Signature · 1 line
2.14.1
#3 lore raw

PATCH 1/1 selftests/vm/gup_benchmark.c: match gup struct to kernel

Quoted 9 lines · Alison Schofield

Hi Shauh,

Ping on this one. It has Kirill's ACK. Without this fix the gup_benchmark fails to run (at all).

Thanks!
Alison

On Fri, Dec 07, 2018 at 06:06:45PM -0800, Alison Schofield wrote:

Quoted 9 lines
Quoted 7 lines

An expansion field was added to the kernel copy of this structure for future use. See mm/gup_benchmark.c.

Add the same expansion field here, so that the IOCTL command decodes correctly. Otherwise, it fails with EINVAL.

Signed-off-by Alison Schofield <alison.schofield at intel.com>
Acked-by Kirill A. Shutemov <kirill.shutemov at linux.intel.com>

Sorry for the delay and thanks for the ping. I will apply this for linux-kselftest fixes for 5.0-rc3

thanks,
-- Shuah