Skip to contentSkip to conversation

boot/afboot-stm32: create destination directory during installation

PATCH New Thomas Petazzoni 3 participants 3 messages Dec 8, 2018 Arm STM32

lore
Share & tools
lore

Thomas Petazzoni

author
#0 lore raw

PATCH 1/1 boot/afboot-stm32: create destination directory during installation

Following d0f4f95e390bcb1c953efa125f5277a8a235396e ("Makefile: rework main directory creation logic"), BINARIES_DIR is not implicitly created by the main Makefile at the beginning of the build, leaving that up to whatever piece of code needs to install something in $(BINARIES_DIR).

The afboot-stm32 package didn't pay attention to this, which this commit fixes.

While at it, we move the afboot-stm32 installation into <pkg>_INSTALL_IMAGES_CMDS, because using <pkg>_INSTALL_TARGET_CMDS to install only files to BINARIES_DIR is a bit strange.

Fixes:

https://gitlab.com/buildroot.org/buildroot/-/jobs/131217111

Signed-off-by Thomas Petazzoni <[email protected]>
---
 boot/afboot-stm32/afboot-stm32.mk | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
boot/afboot-stm32/afboot-stm32.mk +4 -2
index 042b21fa55..5e221cf364 100644
@@ -6,13 +6,15 @@
 
 AFBOOT_STM32_VERSION = v0.1
 AFBOOT_STM32_SITE = $(call github,mcoquelin-stm32,afboot-stm32,$(AFBOOT_STM32_VERSION))
+AFBOOT_STM32_INSTALL_IMAGES = YES
+AFBOOT_STM32_INSTALL_TARGET = NO
 
 define AFBOOT_STM32_BUILD_CMDS
 	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) CROSS_COMPILE=$(TARGET_CROSS) all
 endef
 
-define AFBOOT_STM32_INSTALL_TARGET_CMDS
-	$(INSTALL) -m 0755 $(@D)/stm32*.bin $(BINARIES_DIR)
+define AFBOOT_STM32_INSTALL_IMAGES_CMDS
+	$(INSTALL) -m 0755 -t $(BINARIES_DIR) -D $(@D)/stm32*.bin
 endef
 
 $(eval $(generic-package))
Signature · 1 line
2.19.2
#1 lore raw

PATCH 1/1 boot/afboot-stm32: create destination directory during installation

Thomas, All,

On 2018-12-08 15:18 +0100, Thomas Petazzoni spake thusly:

Quoted 13 lines

Following d0f4f95e390bcb1c953efa125f5277a8a235396e ("Makefile: rework main directory creation logic"), BINARIES_DIR is not implicitly created by the main Makefile at the beginning of the build, leaving that up to whatever piece of code needs to install something in $(BINARIES_DIR).

The afboot-stm32 package didn't pay attention to this, which this commit fixes.

While at it, we move the afboot-stm32 installation into <pkg>_INSTALL_IMAGES_CMDS, because using <pkg>_INSTALL_TARGET_CMDS to install only files to BINARIES_DIR is a bit strange.

Quoted 5 lines

Fixes:

https://gitlab.com/buildroot.org/buildroot/-/jobs/131217111

Signed-off-by Thomas Petazzoni <[email protected]>
Acked-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 33 lines
---
 boot/afboot-stm32/afboot-stm32.mk | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
boot/afboot-stm32/afboot-stm32.mk +4 -2
index 042b21fa55..5e221cf364 100644
@@ -6,13 +6,15 @@
 
 AFBOOT_STM32_VERSION = v0.1
 AFBOOT_STM32_SITE = $(call github,mcoquelin-stm32,afboot-stm32,$(AFBOOT_STM32_VERSION))
+AFBOOT_STM32_INSTALL_IMAGES = YES
+AFBOOT_STM32_INSTALL_TARGET = NO
 
 define AFBOOT_STM32_BUILD_CMDS
 	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) CROSS_COMPILE=$(TARGET_CROSS) all
 endef
 
-define AFBOOT_STM32_INSTALL_TARGET_CMDS
-	$(INSTALL) -m 0755 $(@D)/stm32*.bin $(BINARIES_DIR)
+define AFBOOT_STM32_INSTALL_IMAGES_CMDS
+	$(INSTALL) -m 0755 -t $(BINARIES_DIR) -D $(@D)/stm32*.bin
 endef
 
 $(eval $(generic-package))
Signature · 6 lines
2.19.2

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 boot/afboot-stm32: create destination directory during installation

In reply to Thomas Petazzoni
Quoted 15 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Following d0f4f95e390bcb1c953efa125f5277a8a235396e ("Makefile: rework main directory creation logic"), BINARIES_DIR is not implicitly created by the main Makefile at the beginning of the build, leaving that up to whatever piece of code needs to install something in $(BINARIES_DIR).

The afboot-stm32 package didn't pay attention to this, which this commit fixes.

While at it, we move the afboot-stm32 installation into <pkg>_INSTALL_IMAGES_CMDS, because using <pkg>_INSTALL_TARGET_CMDS to install only files to BINARIES_DIR is a bit strange.

Quoted 5 lines

Fixes:

https://gitlab.com/buildroot.org/buildroot/-/jobs/131217111

Signed-off-by Thomas Petazzoni <[email protected]>

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard