minnowboard-max: defconfigs: bump kernel to 4.19.8
PATCH 1/1 minnowboard-max: defconfigs: bump kernel to 4.19.8
--- configs/minnowboard_max-graphical_defconfig | 4 ++-- configs/minnowboard_max_defconfig | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-)
configs/minnowboard_max-graphical_defconfig +2 -2
@@ -3,7 +3,7 @@ BR2_x86_64=y BR2_x86_silvermont=y # Toolchain -BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_14=y +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_19=y BR2_TOOLCHAIN_BUILDROOT_LOCALE=y BR2_TOOLCHAIN_BUILDROOT_CXX=y # needed for TARGET_GRUB2
@@ -23,7 +23,7 @@ BR2_PACKAGE_HOST_MTOOLS=y # Linux BR2_LINUX_KERNEL=y BR2_LINUX_KERNEL_CUSTOM_VERSION=y -BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.14.13" +BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.19.8" BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/minnowboard/linux.config"
configs/minnowboard_max_defconfig +3 -3
@@ -7,8 +7,8 @@ BR2_SYSTEM_DHCP="eth0" BR2_ROOTFS_POST_BUILD_SCRIPT="board/minnowboard/post-build.sh" BR2_ROOTFS_POST_IMAGE_SCRIPT="board/minnowboard/post-image.sh" -# Linux headers same as kernel, a 4.14 series -BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_14=y +# Linux headers same as kernel, a 4.19 series +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_19=y # Needed for grub2 BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
@@ -23,7 +23,7 @@ BR2_PACKAGE_LINUX_FIRMWARE_RTL_8169=y # Linux kernel BR2_LINUX_KERNEL=y BR2_LINUX_KERNEL_CUSTOM_VERSION=y -BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.14.13" +BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.19.8" BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/minnowboard/linux.config"
Signature · 1 line
2.11.0
PATCH 1/1 minnowboard-max: defconfigs: bump kernel to 4.19.8
Peter, All,
On 2018-12-08 22:52 +0100, Peter Korsgaard spake thusly:
Quoted 1 line
Signed-off-by Peter Korsgaard <[email protected]>
However, I have a very minor comment, see below...
[--SNIP--]
configs/minnowboard_max_defconfig BR2_SYSTEM_DHCP="eth0" · line 10
Quoted 11 lines
configs/minnowboard_max_defconfig +1
-2@@ -7,8 +7,8 @@ BR2_SYSTEM_DHCP="eth0" BR2_ROOTFS_POST_BUILD_SCRIPT="board/minnowboard/post-build.sh" BR2_ROOTFS_POST_IMAGE_SCRIPT="board/minnowboard/post-image.sh" -# Linux headers same as kernel, a 4.14 series -BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_14=y +# Linux headers same as kernel, a 4.19 series
Do we really need that comment? It is interesting for defconfigs that use a sha1 from a git tree, for which it is impossible to quickly identify the kernel version, but here, the kernel version is human-readable, so we don;t really care about the comment, do we?
Regards,
Yann E. MORIN.
Quoted 20 lines
configs/minnowboard_max_defconfig +2
-1+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_19=y # Needed for grub2 BR2_TOOLCHAIN_BUILDROOT_WCHAR=y@@ -23,7 +23,7 @@ BR2_PACKAGE_LINUX_FIRMWARE_RTL_8169=y # Linux kernel BR2_LINUX_KERNEL=y BR2_LINUX_KERNEL_CUSTOM_VERSION=y -BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.14.13" +BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.19.8" BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/minnowboard/linux.config"Signature · 6 lines
2.11.0 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/1 minnowboard-max: defconfigs: bump kernel to 4.19.8
Quoted 19 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Yann" == Yann E MORIN <[email protected]> writes:
Peter, All,
On 2018-12-08 22:52 +0100, Peter Korsgaard spake thusly:Quoted 1 line
Signed-off-by Peter Korsgaard <[email protected]>Reviewed-by "Yann E. MORIN" <[email protected]>However, I have a very minor comment, see below...
[--SNIP--]
Quoted 8 lines
configs/minnowboard_max_defconfig +0
-0@@ -7,8 +7,8 @@ BR2_SYSTEM_DHCP="eth0"BR2_ROOTFS_POST_BUILD_SCRIPT="board/minnowboard/post-build.sh" BR2_ROOTFS_POST_IMAGE_SCRIPT="board/minnowboard/post-image.sh"
Quoted 8 lines
configs/minnowboard_max_defconfig BR2_SYSTEM_DHCP="eth0" · line 10
Quoted 3 lines
configs/minnowboard_max_defconfig +1
-2-# Linux headers same as kernel, a 4.14 series -BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_14=y +# Linux headers same as kernel, a 4.19 seriesDo we really need that comment? It is interesting for defconfigs that use a sha1 from a git tree, for which it is impossible to quickly identify the kernel version, but here, the kernel version is human-readable, so we don;t really care about the comment, do we?
I have no problem removing it, I just wanted to keep the diff to a minimum.
We do have a number of other defconfigs with a similar line, E.G. sheevaplug_defconfig, openblocks_a6_defconfig, .. - It probably makes sense to remove them all in one go.
In the mean time I have committed this patch, thanks.
Signature · 1 line
Bye, Peter Korsgaard