Skip to contentSkip to conversation

bmips: swapping IO space isn't required

PATCH New Álvaro Fernández Rojas 2 participants 4 messages Dec 9, 2018 – Dec 10, 2018 MIPS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bmips: swapping IO space isn't required

---
 arch/mips/mach-bmips/Kconfig | 10 ----------
 1 file changed, 10 deletions(-)
arch/mips/mach-bmips/Kconfig +0 -10
index 521996599e..b259a931c9 100644
@@ -25,7 +25,6 @@ config SOC_BMIPS_BCM3380
 	select MIPS_TUNE_4KC
 	select SUPPORTS_BIG_ENDIAN
 	select SUPPORTS_CPU_MIPS32_R1
-	select SWAP_IO_SPACE
 	select SYSRESET_WATCHDOG
 	help
 	  This supports BMIPS BCM3380 family.
@@ -36,7 +35,6 @@ config SOC_BMIPS_BCM6318
 	select MIPS_TUNE_4KC
 	select SUPPORTS_BIG_ENDIAN
 	select SUPPORTS_CPU_MIPS32_R1
-	select SWAP_IO_SPACE
 	select SYSRESET_SYSCON
 	help
 	  This supports BMIPS BCM6318 family.
@@ -47,7 +45,6 @@ config SOC_BMIPS_BCM6328
 	select MIPS_TUNE_4KC
 	select SUPPORTS_BIG_ENDIAN
 	select SUPPORTS_CPU_MIPS32_R1
-	select SWAP_IO_SPACE
 	select SYSRESET_SYSCON
 	help
 	  This supports BMIPS BCM6328 family including BCM63281 and BCM63283.
@@ -58,7 +55,6 @@ config SOC_BMIPS_BCM6338
 	select MIPS_TUNE_4KC
 	select SUPPORTS_BIG_ENDIAN
 	select SUPPORTS_CPU_MIPS32_R1
-	select SWAP_IO_SPACE
 	select SYSRESET_SYSCON
 	help
 	  This supports BMIPS BCM6338 family.
@@ -69,7 +65,6 @@ config SOC_BMIPS_BCM6348
 	select MIPS_TUNE_4KC
 	select SUPPORTS_BIG_ENDIAN
 	select SUPPORTS_CPU_MIPS32_R1
-	select SWAP_IO_SPACE
 	select SYSRESET_WATCHDOG
 	help
 	  This supports BMIPS BCM6348 family.
@@ -80,7 +75,6 @@ config SOC_BMIPS_BCM6358
 	select MIPS_TUNE_4KC
 	select SUPPORTS_BIG_ENDIAN
 	select SUPPORTS_CPU_MIPS32_R1
-	select SWAP_IO_SPACE
 	select SYSRESET_SYSCON
 	help
 	  This supports BMIPS BCM6358 family including BCM6358 and BCM6359.
@@ -91,7 +85,6 @@ config SOC_BMIPS_BCM6368
 	select MIPS_TUNE_4KC
 	select SUPPORTS_BIG_ENDIAN
 	select SUPPORTS_CPU_MIPS32_R1
-	select SWAP_IO_SPACE
 	select SYSRESET_SYSCON
 	help
 	  This supports BMIPS BCM6368 family including BCM6368 and BCM6369.
@@ -102,7 +95,6 @@ config SOC_BMIPS_BCM6362
 	select MIPS_TUNE_4KC
 	select SUPPORTS_BIG_ENDIAN
 	select SUPPORTS_CPU_MIPS32_R1
-	select SWAP_IO_SPACE
 	select SYSRESET_SYSCON
 	help
 	  This supports BMIPS BCM6362 family including BCM6361 and BCM6362.
@@ -113,7 +105,6 @@ config SOC_BMIPS_BCM63268
 	select MIPS_TUNE_4KC
 	select SUPPORTS_BIG_ENDIAN
 	select SUPPORTS_CPU_MIPS32_R1
-	select SWAP_IO_SPACE
 	select SYSRESET_SYSCON
 	help
 	  This supports BMIPS BCM63268 family including BCM63168, BCM63169,
@@ -125,7 +116,6 @@ config SOC_BMIPS_BCM6838
 	select MIPS_TUNE_4KC
 	select SUPPORTS_BIG_ENDIAN
 	select SUPPORTS_CPU_MIPS32_R1
-	select SWAP_IO_SPACE
 	select SYSRESET_SYSCON
 	help
 	  This supports BMIPS BCM6838 family including BCM68380, BCM68381,
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 bmips: swapping IO space isn't required

Am 09.12.18 um 10:41 schrieb Álvaro Fernández Rojas:

Quoted 4 lines
---
 arch/mips/mach-bmips/Kconfig | 10 ----------
 1 file changed, 10 deletions(-)

I guess this is related to your recent series "serial: bcm6345: switch to raw I/O functions"? As Tom already applied this series, this patch should go in 2019.01 too?

Quoted 86 lines
arch/mips/mach-bmips/Kconfig +0 -10
index 521996599e..b259a931c9 100644
@@ -25,7 +25,6 @@ config SOC_BMIPS_BCM3380
 	select MIPS_TUNE_4KC
 	select SUPPORTS_BIG_ENDIAN
 	select SUPPORTS_CPU_MIPS32_R1
-	select SWAP_IO_SPACE
 	select SYSRESET_WATCHDOG
 	help
 	  This supports BMIPS BCM3380 family.
@@ -36,7 +35,6 @@ config SOC_BMIPS_BCM6318
 	select MIPS_TUNE_4KC
 	select SUPPORTS_BIG_ENDIAN
 	select SUPPORTS_CPU_MIPS32_R1
-	select SWAP_IO_SPACE
 	select SYSRESET_SYSCON
 	help
 	  This supports BMIPS BCM6318 family.
@@ -47,7 +45,6 @@ config SOC_BMIPS_BCM6328
 	select MIPS_TUNE_4KC
 	select SUPPORTS_BIG_ENDIAN
 	select SUPPORTS_CPU_MIPS32_R1
-	select SWAP_IO_SPACE
 	select SYSRESET_SYSCON
 	help
 	  This supports BMIPS BCM6328 family including BCM63281 and BCM63283.
@@ -58,7 +55,6 @@ config SOC_BMIPS_BCM6338
 	select MIPS_TUNE_4KC
 	select SUPPORTS_BIG_ENDIAN
 	select SUPPORTS_CPU_MIPS32_R1
-	select SWAP_IO_SPACE
 	select SYSRESET_SYSCON
 	help
 	  This supports BMIPS BCM6338 family.
@@ -69,7 +65,6 @@ config SOC_BMIPS_BCM6348
 	select MIPS_TUNE_4KC
 	select SUPPORTS_BIG_ENDIAN
 	select SUPPORTS_CPU_MIPS32_R1
-	select SWAP_IO_SPACE
 	select SYSRESET_WATCHDOG
 	help
 	  This supports BMIPS BCM6348 family.
@@ -80,7 +75,6 @@ config SOC_BMIPS_BCM6358
 	select MIPS_TUNE_4KC
 	select SUPPORTS_BIG_ENDIAN
 	select SUPPORTS_CPU_MIPS32_R1
-	select SWAP_IO_SPACE
 	select SYSRESET_SYSCON
 	help
 	  This supports BMIPS BCM6358 family including BCM6358 and BCM6359.
@@ -91,7 +85,6 @@ config SOC_BMIPS_BCM6368
 	select MIPS_TUNE_4KC
 	select SUPPORTS_BIG_ENDIAN
 	select SUPPORTS_CPU_MIPS32_R1
-	select SWAP_IO_SPACE
 	select SYSRESET_SYSCON
 	help
 	  This supports BMIPS BCM6368 family including BCM6368 and BCM6369.
@@ -102,7 +95,6 @@ config SOC_BMIPS_BCM6362
 	select MIPS_TUNE_4KC
 	select SUPPORTS_BIG_ENDIAN
 	select SUPPORTS_CPU_MIPS32_R1
-	select SWAP_IO_SPACE
 	select SYSRESET_SYSCON
 	help
 	  This supports BMIPS BCM6362 family including BCM6361 and BCM6362.
@@ -113,7 +105,6 @@ config SOC_BMIPS_BCM63268
 	select MIPS_TUNE_4KC
 	select SUPPORTS_BIG_ENDIAN
 	select SUPPORTS_CPU_MIPS32_R1
-	select SWAP_IO_SPACE
 	select SYSRESET_SYSCON
 	help
 	  This supports BMIPS BCM63268 family including BCM63168, BCM63169,
@@ -125,7 +116,6 @@ config SOC_BMIPS_BCM6838
 	select MIPS_TUNE_4KC
 	select SUPPORTS_BIG_ENDIAN
 	select SUPPORTS_CPU_MIPS32_R1
-	select SWAP_IO_SPACE
 	select SYSRESET_SYSCON
 	help
 	  This supports BMIPS BCM6838 family including BCM68380, BCM68381,
Signature · 1 line
- Daniel
#2 lore raw

PATCH 1/1 bmips: swapping IO space isn't required

Hi Daniel,

Quoted 10 lines · Daniel Schwierzeck

Am 09.12.18 um 10:41 schrieb Álvaro Fernández Rojas:

Quoted 4 lines
---
  arch/mips/mach-bmips/Kconfig | 10 ----------
  1 file changed, 10 deletions(-)

I guess this is related to your recent series "serial: bcm6345: switch to raw I/O functions"? As Tom already applied this series, this patch should go in 2019.01 too?

Yes, I completely forgot I had copied SWAP_IO_SPACE from linux target without really needing it.

Without this patch serial driver isn't working for bmips boards, so yeah this should go in 2019.01.

Quoted 86 lines
Quoted 86 lines
arch/mips/mach-bmips/Kconfig +0 -10
index 521996599e..b259a931c9 100644
@@ -25,7 +25,6 @@ config SOC_BMIPS_BCM3380
  	select MIPS_TUNE_4KC
  	select SUPPORTS_BIG_ENDIAN
  	select SUPPORTS_CPU_MIPS32_R1
-	select SWAP_IO_SPACE
  	select SYSRESET_WATCHDOG
  	help
  	  This supports BMIPS BCM3380 family.
@@ -36,7 +35,6 @@ config SOC_BMIPS_BCM6318
  	select MIPS_TUNE_4KC
  	select SUPPORTS_BIG_ENDIAN
  	select SUPPORTS_CPU_MIPS32_R1
-	select SWAP_IO_SPACE
  	select SYSRESET_SYSCON
  	help
  	  This supports BMIPS BCM6318 family.
@@ -47,7 +45,6 @@ config SOC_BMIPS_BCM6328
  	select MIPS_TUNE_4KC
  	select SUPPORTS_BIG_ENDIAN
  	select SUPPORTS_CPU_MIPS32_R1
-	select SWAP_IO_SPACE
  	select SYSRESET_SYSCON
  	help
  	  This supports BMIPS BCM6328 family including BCM63281 and BCM63283.
@@ -58,7 +55,6 @@ config SOC_BMIPS_BCM6338
  	select MIPS_TUNE_4KC
  	select SUPPORTS_BIG_ENDIAN
  	select SUPPORTS_CPU_MIPS32_R1
-	select SWAP_IO_SPACE
  	select SYSRESET_SYSCON
  	help
  	  This supports BMIPS BCM6338 family.
@@ -69,7 +65,6 @@ config SOC_BMIPS_BCM6348
  	select MIPS_TUNE_4KC
  	select SUPPORTS_BIG_ENDIAN
  	select SUPPORTS_CPU_MIPS32_R1
-	select SWAP_IO_SPACE
  	select SYSRESET_WATCHDOG
  	help
  	  This supports BMIPS BCM6348 family.
@@ -80,7 +75,6 @@ config SOC_BMIPS_BCM6358
  	select MIPS_TUNE_4KC
  	select SUPPORTS_BIG_ENDIAN
  	select SUPPORTS_CPU_MIPS32_R1
-	select SWAP_IO_SPACE
  	select SYSRESET_SYSCON
  	help
  	  This supports BMIPS BCM6358 family including BCM6358 and BCM6359.
@@ -91,7 +85,6 @@ config SOC_BMIPS_BCM6368
  	select MIPS_TUNE_4KC
  	select SUPPORTS_BIG_ENDIAN
  	select SUPPORTS_CPU_MIPS32_R1
-	select SWAP_IO_SPACE
  	select SYSRESET_SYSCON
  	help
  	  This supports BMIPS BCM6368 family including BCM6368 and BCM6369.
@@ -102,7 +95,6 @@ config SOC_BMIPS_BCM6362
  	select MIPS_TUNE_4KC
  	select SUPPORTS_BIG_ENDIAN
  	select SUPPORTS_CPU_MIPS32_R1
-	select SWAP_IO_SPACE
  	select SYSRESET_SYSCON
  	help
  	  This supports BMIPS BCM6362 family including BCM6361 and BCM6362.
@@ -113,7 +105,6 @@ config SOC_BMIPS_BCM63268
  	select MIPS_TUNE_4KC
  	select SUPPORTS_BIG_ENDIAN
  	select SUPPORTS_CPU_MIPS32_R1
-	select SWAP_IO_SPACE
  	select SYSRESET_SYSCON
  	help
  	  This supports BMIPS BCM63268 family including BCM63168, BCM63169,
@@ -125,7 +116,6 @@ config SOC_BMIPS_BCM6838
  	select MIPS_TUNE_4KC
  	select SUPPORTS_BIG_ENDIAN
  	select SUPPORTS_CPU_MIPS32_R1
-	select SWAP_IO_SPACE
  	select SYSRESET_SYSCON
  	help
  	  This supports BMIPS BCM6838 family including BCM68380, BCM68381,
#3 lore raw

PATCH 1/1 bmips: swapping IO space isn't required

In reply to Álvaro Fernández Rojas

Am 09.12.18 um 10:41 schrieb Álvaro Fernández Rojas:

Quoted 5 lines
---
 arch/mips/mach-bmips/Kconfig | 10 ----------
 1 file changed, 10 deletions(-)

applied to u-boot-mips/fixes, thanks.

Signature · 9 lines
- Daniel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181210/8a40c690/attachment.sig>