btrfs: extent-tree: cleanup one-shot usage of @blocksize in do_walk_down
PATCH 1/1 btrfs: extent-tree: cleanup one-shot usage of @blocksize in do_walk_down
@blocksize variable in do_walk_down() is only used once, really no need to declare it.
Signed-off-by Qu Wenruo <[email protected]>
--- fs/btrfs/extent-tree.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
fs/btrfs/extent-tree.c +1 -3
@@ -8577,7 +8577,6 @@ static noinline int do_walk_down(struct btrfs_trans_handle *trans,u64 bytenr;u64 generation;u64 parent; -u32 blocksize;struct btrfs_key key;struct btrfs_key first_key;struct extent_buffer *next;
@@ -8602,7 +8601,6 @@ static noinline int do_walk_down(struct btrfs_trans_handle *trans, bytenr =btrfs_node_blockptr (path->nodes[level], path->slots[level]);btrfs_node_key_to_cpu (path->nodes[level], &first_key, path->slots[level]); - blocksize = fs_info->nodesize; next =find_extent_buffer (fs_info, bytenr);if (!next) {
@@ -8726,7 +8724,7 @@ static noinline int do_walk_down(struct btrfs_trans_handle *trans, ret); } } - ret =btrfs_free_extent (trans, root, bytenr, blocksize, + ret =btrfs_free_extent (trans, root, bytenr, fs_info->nodesize, parent, root->root_key.objectid, level -1 ,0 , false);if (ret)
Signature · 1 line
2.19.2
Quoted 4 lines · Qu Wenruo
@blocksize variable in
do_walk_down()is only used once, really no need to declare it.Signed-off-by Qu Wenruo <[email protected]>
Reviewed-by Nikolay Borisov <[email protected]>
Quoted 34 lines
--- fs/btrfs/extent-tree.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)fs/btrfs/extent-tree.c +1
-3@@ -8577,7 +8577,6 @@ static noinline int do_walk_down(struct btrfs_trans_handle *trans,u64 bytenr;u64 generation;u64 parent; -u32 blocksize;struct btrfs_key key;struct btrfs_key first_key;struct extent_buffer *next;@@ -8602,7 +8601,6 @@ static noinline int do_walk_down(struct btrfs_trans_handle *trans, bytenr =btrfs_node_blockptr (path->nodes[level], path->slots[level]);btrfs_node_key_to_cpu (path->nodes[level], &first_key, path->slots[level]); - blocksize = fs_info->nodesize; next =find_extent_buffer (fs_info, bytenr);if (!next) {@@ -8726,7 +8724,7 @@ static noinline int do_walk_down(struct btrfs_trans_handle *trans, ret); } } - ret =btrfs_free_extent (trans, root, bytenr, blocksize, + ret =btrfs_free_extent (trans, root, bytenr, fs_info->nodesize, parent, root->root_key.objectid, level -1 ,0 , false);if (ret)
Looks good,
Reviewed-by Johannes Thumshirn <[email protected]>
Signature · 6 lines
Johannes Thumshirn SUSE Labs Filesystems [email protected] +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Quoted 4 lines · Qu Wenruo
@blocksize variable in
do_walk_down()is only used once, really no need to declare it.Signed-off-by Qu Wenruo <[email protected]>
Added to misc-next, thanks.