USB: serial: option: add Fibocom NL668 series (fixed line break issue)

Quoted 23 lines · Jörgen Storvist

Added USB serial option driver support for Fibocom NL668 series cellular module. Reserved USB endpoints 4 and 5 for network interfaces.

Signed-off-by Jörgen Storvist <[email protected]>

drivers/usb/serial/option.c | 5 +++++

  1 file changed, 5 insertions(+)

drivers/usb/serial/option.c +3 -0

index e24ff16..f2cc85c 100644
@@ -552,6 +552,9 @@ static void option_instat_callback(struct urb *urb);
  #define WETELECOM_PRODUCT_6802			0x6802
  #define WETELECOM_PRODUCT_WMD300		0x6803
 
+/* Fibocom products */
+#define FIBOCOM_VENDOR_ID   			0x1508
+#define FIBOCOM_PRODUCT_NL668   		0x1001
 
  /* Device flags */
 

drivers/usb/serial/option.c static const struct usb_device_id option_ids[] = { · line 1951

Quoted 9 lines

drivers/usb/serial/option.c +2 -0

@@ -1941,6 +1944,8 @@ static const struct usb_device_id option_ids[] = {
  	{ USB_DEVICE_AND_INTERFACE_INFO(WETELECOM_VENDOR_ID, WETELECOM_PRODUCT_6802, 0xff, 0xff, 0xff) },
  	{ USB_DEVICE_AND_INTERFACE_INFO(WETELECOM_VENDOR_ID, WETELECOM_PRODUCT_WMD300, 0xff, 0xff, 0xff) },
  	{ USB_DEVICE_AND_INTERFACE_INFO(0x03f0, 0x421d, 0xff, 0xff, 0xff) }, /* HP lt2523 (Novatel E371) */
+	{ USB_DEVICE(FIBOCOM_VENDOR_ID, FIBOCOM_PRODUCT_NL668), /* Fibocom NL668 series */
+	  .driver_info = RSVD(4) | RSVD(5) },
  	{ } /* Terminating entry */
  };
  MODULE_DEVICE_TABLE(usb, option_ids);

Listed owner of the 0x1508 VID is "MAATEL" which probably is a customer or subsidiary of FIBOCOM (which has the VID 0x2cb7).
Please don't do this value-to-name conversion, it is completely useless and in this case most likely wrong as well.
Just skip the declaration part and use the VID and PID values directly in the device structure list.