tests/gem_shrink: Background, direct and OOM shrinker plus userptr tests

PATCH New Tvrtko Ursulin 2 participants 4 messages Dec 10, 2018 Library code

lore

Share & tools

lore

Tvrtko Ursulin

author

2018-12-10 10:11 UTC #0 lore raw

PATCH 1/2 tests/gem_shrink: Background, direct and OOM shrinker plus userptr tests

From: Tvrtko Ursulin <[email protected]>

...

Signed-off-by Tvrtko Ursulin <[email protected]>

---
 lib/igt_core.c          |  19 +++
 lib/igt_core.h          |   1 +
 tests/i915/gem_shrink.c | 348 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 368 insertions(+)

lib/igt_core.c +19 -0

index 64883d6402af..a22c4b077d85 100644
@@ -1680,6 +1680,25 @@ void igt_stop_helper(struct igt_helper_process *proc)
 	assert(helper_was_alive(proc, status));
 }
 
+/**
+ * igt_try_stop_helper:
+ * @proc: #igt_helper_process structure
+ *
+ * Terminates a helper process if it is still running and returns true, or false
+ * if the process wasn't running.
+ */
+bool igt_try_stop_helper(struct igt_helper_process *proc)
+{
+	int status;
+
+	/* failure here means the pid is already dead and so waiting is safe */
+	kill(proc->pid, proc->use_SIGKILL ? SIGKILL : SIGTERM);
+
+	status = igt_wait_helper(proc);
+
+	return helper_was_alive(proc, status);
+}
+
 static void children_exit_handler(int sig)
 {
 	int status;

lib/igt_core.h +1 -0

index 6f8c3852a686..ed5ceebf1205 100644
@@ -795,6 +795,7 @@ bool __igt_fork_helper(struct igt_helper_process *proc);
 	for (; __igt_fork_helper(proc); exit(0))
 int igt_wait_helper(struct igt_helper_process *proc);
 void igt_stop_helper(struct igt_helper_process *proc);
+bool igt_try_stop_helper(struct igt_helper_process *proc);
 
 /* exit handler code */

tests/i915/gem_shrink.c +348 -0

366 lines not on this page · raw message

Signature · 6 lines

2.19.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Tvrtko Ursulin

author

2018-12-10 10:11 UTC #1 lore raw

PATCH 2/2 intel-ci: Unblacklist the new tests??

From: Tvrtko Ursulin <[email protected]>

Signed-off-by Tvrtko Ursulin <[email protected]>

---
 tests/intel-ci/blacklist.txt          | 1 +
 tests/intel-ci/fast-feedback.testlist | 3 +++
 2 files changed, 4 insertions(+)

tests/intel-ci/blacklist.txt +1 -0

index 73d127603d28..8083efc407d4 100644
@@ -60,6 +60,7 @@ igt@gem_ring_sync_copy(@.*)?
 igt@gem_ring_sync_loop(@.*)?
 igt@gem_seqno_wrap(@.*)?
 igt@gem_shrink@(?!reclaim$).*
+igt@gem_shrink@(?!two-reclaims-and-oom).*
 igt@gem_softpin@.*(hang|S4).*
 igt@gem_spin_batch(@.*)?
 igt@gem_stolen@.*hibernate.*

tests/intel-ci/fast-feedback.testlist +3 -0

index 6d42792c67f7..32c1a3266553 100644
@@ -124,6 +124,9 @@ igt@gem_ringfill@basic-default
 igt@gem_ringfill@basic-default-interruptible
 igt@gem_ringfill@basic-default-forked
 igt@gem_ringfill@basic-default-fd
+igt@gem_shrink@two-reclaims-and-oom
+igt@gem_shrink@two-reclaims-and-oom-userptr
+igt@gem_shrink@two-reclaims-and-oom-both
 igt@gem_sync@basic-all
 igt@gem_sync@basic-each
 igt@gem_sync@basic-many-each

Signature · 6 lines

2.19.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Patchwork

2018-12-10 10:44 UTC #2 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for series starting with [RFT,i-g-t,1/2] tests/gem_shrink: Background, direct and OOM shrinker plus userptr tests

In reply to Tvrtko Ursulin

== Series Details ==

Series: series starting with [RFT,i-g-t,1/2] tests/gem_shrink: Background, direct and OOM shrinker plus userptr tests
URL : https://patchwork.freedesktop.org/series/53825/
State : success

== Summary ==

CI Bug Log - changes from IGT_4744 -> IGTPW_2139
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/53825/revisions/1/mbox/

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_2139:

### IGT changes ###

#### Warnings ####

* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-c:
- {fi-kbl-7567u}: PASS -> SKIP +33

Known issues
------------

Here are the changes found in IGTPW_2139 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_ctx_create@basic-files:
- fi-bsw-kefka: PASS -> FAIL [fdo#108656]

* igt@i915_selftest@live_hangcheck:
- fi-bwr-2160: PASS -> DMESG-FAIL [fdo#108735]

* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: PASS -> DMESG-WARN [fdo#102614]
- fi-byt-clapper: PASS -> FAIL [fdo#103167]

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-skl-6700k2: PASS -> INCOMPLETE [fdo#104108] / [fdo#105524] / [k.org#199541]

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- fi-skl-6600u: PASS -> INCOMPLETE [fdo#104108] / [fdo#107773]

* igt@pm_rpm@basic-rte:
- {fi-icl-u3}: NOTRUN -> INCOMPLETE [fdo#108990]

* {igt@runner@aborted}:
- {fi-icl-y}: NOTRUN -> FAIL [fdo#108070]

#### Possible fixes ####

* igt@gem_exec_suspend@basic-s3:
- {fi-icl-u3}: INCOMPLETE [fdo#107713] -> PASS

* igt@gem_sync@basic-many-each:
- fi-skl-6260u: DMESG-WARN [fdo#105541] -> PASS

* igt@i915_selftest@live_contexts:
- fi-bsw-n3050: DMESG-FAIL [fdo#108626] / [fdo#108656] -> PASS

* igt@kms_busy@basic-flip-b:
- fi-gdg-551: FAIL [fdo#103182] -> PASS

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS
- fi-blb-e6850: INCOMPLETE [fdo#107718] -> PASS

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

Participating hosts (50 -> 47)
------------------------------

Additional (2): fi-icl-y fi-pnv-d510
Missing (5): fi-kbl-soraka fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600

Build changes
-------------

* IGT: IGT_4744 -> IGTPW_2139

CI_DRM_5291: 9bb72982ee481a5ae4da600e270d87c8416525a7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2139: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2139/
IGT_4744: 4579ac1d445cf39f6de474071b20db790db575bd @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Testlist changes ==

+igt@gem_shrink@two-reclaims-and-oom
+igt@gem_shrink@two-reclaims-and-oom-both
+igt@gem_shrink@two-reclaims-and-oom-userptr

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2139/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Patchwork

2018-12-10 12:22 UTC #3 lore raw

[igt-dev] ✓ Fi.CI.IGT: success for series starting with [RFT,i-g-t,1/2] tests/gem_shrink: Background, direct and OOM shrinker plus userptr tests

In reply to Tvrtko Ursulin

== Series Details ==

Series: series starting with [RFT,i-g-t,1/2] tests/gem_shrink: Background, direct and OOM shrinker plus userptr tests
URL : https://patchwork.freedesktop.org/series/53825/
State : success

== Summary ==

CI Bug Log - changes from IGT_4744_full -> IGTPW_2139_full
====================================================

Summary
-------

**WARNING**

Minor unknown changes coming with IGTPW_2139_full need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_2139_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/53825/revisions/1/mbox/

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_2139_full:

### IGT changes ###

#### Warnings ####

* igt@pm_rc6_residency@rc6-accuracy:
- shard-snb: PASS -> SKIP

Known issues
------------

Here are the changes found in IGTPW_2139_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_fence@basic-await-default:
- shard-hsw: PASS -> FAIL [fdo#108888]

* igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
- shard-glk: PASS -> FAIL [fdo#108145] +1

* igt@kms_color@pipe-a-ctm-max:
- shard-kbl: PASS -> FAIL [fdo#108147]
- shard-apl: PASS -> FAIL [fdo#108147]

* igt@kms_color@pipe-c-legacy-gamma:
- shard-kbl: PASS -> FAIL [fdo#104782]
- shard-apl: PASS -> FAIL [fdo#104782]

* igt@kms_cursor_crc@cursor-128x128-random:
- shard-apl: PASS -> FAIL [fdo#103232] +8

* igt@kms_cursor_crc@cursor-256x256-sliding:
- shard-glk: PASS -> FAIL [fdo#103232] +2
- shard-kbl: PASS -> FAIL [fdo#103232] +2

* igt@kms_cursor_crc@cursor-256x256-suspend:
- shard-apl: PASS -> FAIL [fdo#103191] / [fdo#103232]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff:
- shard-apl: PASS -> FAIL [fdo#103167]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
- shard-kbl: PASS -> FAIL [fdo#103167]

* igt@kms_frontbuffer_tracking@fbc-1p-rte:
- shard-apl: PASS -> FAIL [fdo#103167] / [fdo#105682]

* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
- shard-glk: PASS -> FAIL [fdo#103167] +11

* igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
- shard-glk: PASS -> FAIL [fdo#103166] +6

* igt@kms_plane_multiple@atomic-pipe-b-tiling-x:
- shard-kbl: PASS -> FAIL [fdo#103166]

* igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
- shard-apl: PASS -> FAIL [fdo#103166] +2

* igt@kms_rotation_crc@primary-rotation-180:
- shard-snb: NOTRUN -> FAIL [fdo#103925]

* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-apl: PASS -> DMESG-WARN [fdo#103558] / [fdo#105602] +3

#### Possible fixes ####

* igt@kms_busy@extended-modeset-hang-newfb-render-c:
- shard-kbl: DMESG-WARN [fdo#107956] -> PASS

* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
- shard-hsw: DMESG-WARN [fdo#107956] -> PASS

* igt@kms_color@pipe-b-legacy-gamma:
- shard-apl: FAIL [fdo#104782] -> PASS
- shard-kbl: FAIL [fdo#104782] -> PASS

* igt@kms_cursor_crc@cursor-128x128-onscreen:
- shard-kbl: FAIL [fdo#103232] -> PASS +2
- shard-apl: FAIL [fdo#103232] -> PASS

* igt@kms_cursor_crc@cursor-128x42-onscreen:
- shard-glk: FAIL [fdo#103232] -> PASS +2

* igt@kms_flip@flip-vs-expired-vblank:
- shard-glk: FAIL [fdo#102887] / [fdo#105363] -> PASS

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
- shard-apl: FAIL [fdo#103167] -> PASS +1
- shard-kbl: FAIL [fdo#103167] -> PASS

* igt@kms_frontbuffer_tracking@fbc-rgb565-draw-render:
- shard-glk: FAIL [fdo#103167] -> PASS +3

* {igt@kms_plane@pixel-format-pipe-c-planes-source-clamping}:
- shard-glk: FAIL [fdo#108948] -> PASS

* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-glk: FAIL [fdo#108145] -> PASS

* igt@kms_plane_multiple@atomic-pipe-b-tiling-yf:
- shard-apl: FAIL [fdo#103166] -> PASS +2

* igt@kms_plane_multiple@atomic-pipe-c-tiling-y:
- shard-kbl: FAIL [fdo#103166] -> PASS

* {igt@kms_rotation_crc@multiplane-rotation-cropping-top}:
- shard-kbl: DMESG-FAIL [fdo#108950] -> PASS
- shard-glk: DMESG-FAIL [fdo#105763] / [fdo#106538] -> PASS

* igt@kms_setmode@basic:
- shard-hsw: FAIL [fdo#99912] -> PASS
- shard-kbl: FAIL [fdo#99912] -> PASS

* igt@perf@blocking:
- shard-hsw: FAIL [fdo#102252] -> PASS

* igt@prime_vgem@shrink:
- shard-snb: INCOMPLETE [fdo#105411] -> PASS

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

Participating hosts (7 -> 5)
------------------------------

Missing (2): shard-skl shard-iclb

Build changes
-------------

* IGT: IGT_4744 -> IGTPW_2139

== Logs ==