arm64: meson-gxm: Add support for the Mali T820 GPU
Subsystems (4)
cover arm64: meson-gxm: Add support for the Mali T820 GPU
This patchset adds :
- Optional reset properties in the midgard bindings
- Mali T820 Node in Amlogic Meson GXM DTSI
Christian Hewitt (1):
arm64: dts: meson-gxm: Add Mali-T820 node
Neil Armstrong (1):
dt-bindings: gpu: mali-midgard: Add resets property
.../bindings/gpu/arm,mali-midgard.txt | 2 ++ arch/arm64/boot/dts/amlogic/meson-gxm.dtsi | 27 +++++++++++++++++++ 2 files changed, 29 insertions(+)
Signature · 6 lines
2.19.2 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH 1/2 dt-bindings: gpu: mali-midgard: Add resets property
The Amlogic ARM Mali Midgard requires reset controls to power on and software reset the GPU, adds these as optional in the bindings.
--- Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt | 2 ++ 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt +2 -0
@@ -37,6 +37,8 @@ Optional properties: - operating-points-v2 : Refer to Documentation/devicetree/bindings/opp/opp.txt for details. +- resets : Phandle to the reset controls for the Mali Midgard device. + Example for a Mali-T760:
Signature · 1 line
2.19.2
Rob Herring
maintainerRe: [PATCH 1/2] dt-bindings: gpu: mali-midgard: Add resets property
Quoted 14 lines · Neil Armstrong
The Amlogic ARM Mali Midgard requires reset controls to power on and software reset the GPU, adds these as optional in the bindings.
Signed-off-by Neil Armstrong <[email protected]>--- Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt | 2 ++ 1 file changed, 2 insertions(+)Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt +0
-0
Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt Optional properties: · line 40
Quoted 4 lines
Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt +1
-0@@ -37,6 +37,8 @@ Optional properties: - operating-points-v2 : Refer to Documentation/devicetree/bindings/opp/opp.txt for details. +- resets : Phandle to the reset controls for the Mali Midgard device.
How many? Sounds like 1, but the dts has 2. There's also a similar patch for Allwinner[1]. I don't want to see a different number of resets and different names for each vendor. So first figure out how many resets the IP block has. You'll have to find someone with access to the TRM.
Rob
[1] https://patchwork.ozlabs.org/patch/1003654/
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 1/2] dt-bindings: gpu: mali-midgard: Add resets property
Quoted 18 lines · Rob Herring
Quoted 17 lines · Neil Armstrong
The Amlogic ARM Mali Midgard requires reset controls to power on and software reset the GPU, adds these as optional in the bindings.
Signed-off-by Neil Armstrong <[email protected]>--- Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt | 2 ++ 1 file changed, 2 insertions(+)Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt +0
-0@@ -37,6 +37,8 @@ Optional properties: - operating-points-v2 : Refer to Documentation/devicetree/bindings/opp/opp.txt for details.
Quoted 7 lines
Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt Optional properties: · line 40
Quoted 1 line
Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt +1
-0+- resets : Phandle to the reset controls for the Mali Midgard device.How many? Sounds like 1, but the dts has 2. There's also a similar patch for Allwinner[1]. I don't want to see a different number of resets and different names for each vendor. So first figure out how many resets the IP block has. You'll have to find someone with access to the TRM.
I can answer for Amlogic, they have a reset for the bus interface and the GPU IP itself.
You are asking something impossible ;-) We can assume it has a single reset interface, but vendors can add more to reset some glue HW. So we will need some variant per-vendor, sorry to annoy you !
Neil
Quoted 5 lines
Rob
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH 2/2 arm64: dts: meson-gxm: Add Mali-T820 node
In reply to Neil ArmstrongFrom: Christian Hewitt <[email protected]>
The Amlogic Meson GXM SoC embeds an ARM Mali T820 GPU.
This patch adds the node with all the needed properties to power on the GPU.
This has been tested with the work-in-progress PanFrost project aiming support for ARM Mali Midgard and later GPUs.
--- arch/arm64/boot/dts/amlogic/meson-gxm.dtsi | 27 ++++++++++++++++++++++ 1 file changed, 27 insertions(+)
arch/arm64/boot/dts/amlogic/meson-gxm.dtsi +27 -0
@@ -91,6 +91,33 @@ reset-names = "phy"; status = "okay"; }; + + mali: gpu@c0000 { + compatible = "amlogic,meson-gxm-mali", "arm,mali-t820"; + reg = <0x0 0xc0000 0x0 0x40000>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 161 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 162 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "gpu", "mmu", "job"; + clocks = <&clkc CLKID_MALI>; + resets = <&reset RESET_MALI_CAPB3>, <&reset RESET_MALI>; + + /* + * Mali clocking is provided by two identical clock paths + * MALI_0 and MALI_1 muxed to a single clock by a glitch + * free mux to safely change frequency while running. + */ + assigned-clocks = <&clkc CLKID_MALI_0_SEL>, + <&clkc CLKID_MALI_0>, + <&clkc CLKID_MALI>; /* Glitch free mux */ + assigned-clock-parents = <&clkc CLKID_FCLK_DIV3>, + <0>, /* Do Nothing */ + <&clkc CLKID_MALI_0>; + assigned-clock-rates = <0>, /* Do Nothing */ + <666666666>, + <0>; /* Do Nothing */ + }; }; &clkc_AO {
Signature · 6 lines
2.19.2 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 9 lines · Neil Armstrong
This patchset adds :
- Optional reset properties in the midgard bindings
- Mali T820 Node in Amlogic Meson GXM DTSIChristian Hewitt (1):
arm64: dts: meson-gxm: Add Mali-T820 nodeNeil Armstrong (1):
dt-bindings: gpu: mali-midgard: Add resets property
Queued for v4.21 (branch: dt64)
Thanks,
Kevin
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel