Skip to contentSkip to conversation

ARM: dts: am33xx: Remove unnecessary properties

PATCH In review Felix Brack 2 participants 5 messages Dec 10, 2018 – Dec 14, 2018 Device tree bindings

lore
Share & tools
lore

Felix Brack

author
#0 lore raw

PATCH 1/1 ARM: dts: am33xx: Remove unnecessary properties

Remove the unnecessary properties #address-cells and #size-cells of node pinmux as there are no child-nodes with property reg.

Signed-off-by Felix Brack <[email protected]>
---
 arch/arm/boot/dts/am33xx.dtsi | 2 --
 1 file changed, 2 deletions(-)
arch/arm/boot/dts/am33xx.dtsi +0 -2
index d3dd6a16e70a..d640cdffe355 100644
@@ -208,8 +208,6 @@
 				am33xx_pinmux: pinmux@800 {
 					compatible = "pinctrl-single";
 					reg = <0x800 0x238>;
-					#address-cells = <1>;
-					#size-cells = <0>;
 					#pinctrl-cells = <1>;
 					pinctrl-single,register-width = <32>;
 					pinctrl-single,function-mask = <0x7f>;
Signature · 1 line
2.17.1
#1 lore raw
Quoted 2 lines · Felix Brack

Remove the unnecessary properties #address-cells and #size-cells of node pinmux as there are no child-nodes with property reg.

Applying into omap-for-v4.21/dt thanks.

Tony

#2 lore raw
Quoted 5 lines · Tony Lindgren
Quoted 2 lines · Felix Brack

Remove the unnecessary properties #address-cells and #size-cells of node pinmux as there are no child-nodes with property reg.

Applying into omap-for-v4.21/dt thanks.

Actually this currently conflicts with the pending am33xx l4 ti-sysc changes, so let's wait on this one to avoid causing merge conflicts between branches.

So dropping for now.

Regards,

Tony

author
#3 lore raw

Hi Tony,

Quoted 5 lines · Tony Lindgren
Quoted 4 lines · Tony Lindgren
Quoted 2 lines · Felix Brack

Remove the unnecessary properties #address-cells and #size-cells of node pinmux as there are no child-nodes with property reg.

Quoted 7 lines
Quoted 1 line

Applying into omap-for-v4.21/dt thanks.

Actually this currently conflicts with the pending am33xx l4 ti-sysc changes, so let's wait on this one to avoid causing merge conflicts between branches.

Okay, I see. The changes introduced by my patch would then affect the new file am33xx-l4.dtsi instead of am33xx.dtsi

Quoted 2 lines

So dropping for now.

Will you "apply" my patch once the am33xx l4 ti-sysc changes are applied or do you expect me to send V2 patch (to be applied to the new am33xx-l4.dtsi) ?

regards, Felix

#4 lore raw
Quoted 10 lines · Felix Brack

Hi Tony,

Quoted 7 lines · Tony Lindgren
Quoted 5 lines · Tony Lindgren
Quoted 2 lines · Felix Brack

Remove the unnecessary properties #address-cells and #size-cells of node pinmux as there are no child-nodes with property reg.

Applying into omap-for-v4.21/dt thanks.

Quoted 7 lines
Quoted 5 lines

Actually this currently conflicts with the pending am33xx l4 ti-sysc changes, so let's wait on this one to avoid causing merge conflicts between branches.

Okay, I see. The changes introduced by my patch would then affect the new file am33xx-l4.dtsi instead of am33xx.dtsi

Yup, and I wanted to keep the am33xx-l4.dtsi in a separate branch from the rest of the dts changes.

Quoted 5 lines
Quoted 2 lines

So dropping for now.

Will you "apply" my patch once the am33xx l4 ti-sysc changes are applied or do you expect me to send V2 patch (to be applied to the new am33xx-l4.dtsi) ?

I'd prefer you to send an updated version against Linux next as the am33xx-l4.dtsi changes have been in next for a while now. It is unlikely at this point that they would not get merged, but I'd rather wait a bit before applying to avoid mixing the two otherwise independent branches :)

Regards,

Tony