Skip to contentSkip to conversation

package/lldpd: fix readline dependency

PATCH New Thomas Petazzoni 1 participant 2 messages Dec 10, 2018 – Dec 13, 2018

lore
Share & tools
lore

Thomas Petazzoni

author
#0 lore raw

PATCH 1/1 package/lldpd: fix readline dependency

lldpd can optionally depend on readline, but readline is never added to LLDPD_DEPENDENCIES, which this commit fixes.

This was detected using per-package directories.

Signed-off-by Thomas Petazzoni <[email protected]>
---
 package/lldpd/lldpd.mk | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
package/lldpd/lldpd.mk +7 -1
index 939cd128fa..6a520448da 100644
@@ -36,7 +36,6 @@ LLDPD_CONF_OPTS = \
 	--without-libbsd \
 	--disable-hardening \
 	--disable-privsep \
-	$(if $(BR2_PACKAGE_READLINE),--with-readline,--without-readline) \
 	$(if $(BR2_PACKAGE_LLDPD_CDP),--enable-cdp,--disable-cdp) \
 	$(if $(BR2_PACKAGE_LLDPD_FDP),--enable-fdp,--disable-fdp) \
 	$(if $(BR2_PACKAGE_LLDPD_EDP),--enable-edp,--disable-edp) \

@@ -46,6 +45,13 @@ LLDPD_CONF_OPTS = \
 	$(if $(BR2_PACKAGE_LLDPD_DOT3),--enable-dot3,--disable-dot3) \
 	$(if $(BR2_PACKAGE_LLDPD_CUSTOM_TLV),--enable-custom,--disable-custom)
 
+ifeq ($(BR2_PACKAGE_READLINE),y)
+LLDPD_CONF_OPTS += --with-readline
+LLDPD_DEPENDENCIES += readline
+else
+LLDPD_CONF_OPTS += --without-readline
+endif
+
 define LLDPD_INSTALL_INIT_SYSV
 	$(INSTALL) -D -m 0755 package/lldpd/S60lldpd \
 		$(TARGET_DIR)/etc/init.d/S60lldpd
Signature · 1 line
2.19.2
author Applied
#1 lore raw

PATCH 1/1 package/lldpd: fix readline dependency

Hello,

Quoted 9 lines · Thomas Petazzoni

lldpd can optionally depend on readline, but readline is never added to LLDPD_DEPENDENCIES, which this commit fixes.

This was detected using per-package directories.

Signed-off-by Thomas Petazzoni <[email protected]>
---
 package/lldpd/lldpd.mk | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com