bpf: convert to DEFINE_SHOW_ATTRIBUTE
Subsystems (2)
PATCH 1/1 bpf: convert to DEFINE_SHOW_ATTRIBUTE
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
Signed-off-by Yangtao Li <[email protected]>
--- drivers/net/netdevsim/bpf.c | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-)
drivers/net/netdevsim/bpf.c +2 -14
@@ -48,7 +48,7 @@ struct nsim_bpf_bound_map {struct list_head l; }; -static int nsim_debugfs_bpf_string_read (struct seq_file *file,void *data) +static int nsim_bpf_string_show (struct seq_file *file,void *data) {const char **str = file->private;
@@ -57,19 +57,7 @@ static int nsim_debugfs_bpf_string_read(struct seq_file *file, void *data)return 0 ; } - -static int nsim_debugfs_bpf_string_open (struct inode *inode,struct file *f) -{ -return single_open (f, nsim_debugfs_bpf_string_read, inode->i_private); -} - -static const struct file_operations nsim_bpf_string_fops = { - .owner =THIS_MODULE , - .open = nsim_debugfs_bpf_string_open, - .release = single_release, - .read = seq_read, - .llseek = seq_lseek -}; +DEFINE_SHOW_ATTRIBUTE (nsim_bpf_string);static int nsim_bpf_verify_insn (struct bpf_verifier_env *env,int insn_idx,int prev_insn)
Signature · 1 line
2.17.0
Quoted 3 lines · Yangtao Li
Use
DEFINE_SHOW_ATTRIBUTEmacro to simplify the code.Signed-off-by Yangtao Li <[email protected]>
Acked-by Jakub Kicinski <[email protected]>
Please post v2 with the subject prefix set to "netdevsim:" rather than "bpf:".
Quoted 37 lines
drivers/net/netdevsim/bpf.c | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-)drivers/net/netdevsim/bpf.c +2
-14@@ -48,7 +48,7 @@ struct nsim_bpf_bound_map {struct list_head l; }; -static int nsim_debugfs_bpf_string_read (struct seq_file *file,void *data) +static int nsim_bpf_string_show (struct seq_file *file,void *data) {const char **str = file->private;@@ -57,19 +57,7 @@ static int nsim_debugfs_bpf_string_read(struct seq_file *file, void *data)return 0 ; } - -static int nsim_debugfs_bpf_string_open (struct inode *inode,struct file *f) -{ -return single_open (f, nsim_debugfs_bpf_string_read, inode->i_private); -} - -static const struct file_operations nsim_bpf_string_fops = { - .owner =THIS_MODULE , - .open = nsim_debugfs_bpf_string_open, - .release = single_release, - .read = seq_read, - .llseek = seq_lseek -}; +DEFINE_SHOW_ATTRIBUTE (nsim_bpf_string);static int nsim_bpf_verify_insn (struct bpf_verifier_env *env,int insn_idx,int prev_insn)
Quoted 10 lines · Jakub Kicinski
Quoted 3 lines · Yangtao Li
Use
DEFINE_SHOW_ATTRIBUTEmacro to simplify the code.Signed-off-by Yangtao Li <[email protected]>Acked-by Jakub Kicinski <[email protected]>Please post v2 with the subject prefix set to "netdevsim:" rather than "bpf:".
The newer has been sent.
Thanks,
Yangtao
Quoted 39 lines
Quoted 38 lines
drivers/net/netdevsim/bpf.c | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-)drivers/net/netdevsim/bpf.c +2
-14@@ -48,7 +48,7 @@ struct nsim_bpf_bound_map {struct list_head l; }; -static int nsim_debugfs_bpf_string_read (struct seq_file *file,void *data) +static int nsim_bpf_string_show (struct seq_file *file,void *data) {const char **str = file->private;@@ -57,19 +57,7 @@ static int nsim_debugfs_bpf_string_read(struct seq_file *file, void *data)return 0 ; } - -static int nsim_debugfs_bpf_string_open (struct inode *inode,struct file *f) -{ -return single_open (f, nsim_debugfs_bpf_string_read, inode->i_private); -} - -static const struct file_operations nsim_bpf_string_fops = { - .owner =THIS_MODULE , - .open = nsim_debugfs_bpf_string_open, - .release = single_release, - .read = seq_read, - .llseek = seq_lseek -}; +DEFINE_SHOW_ATTRIBUTE (nsim_bpf_string);static int nsim_bpf_verify_insn (struct bpf_verifier_env *env,int insn_idx,int prev_insn)