Skip to contentSkip to conversation

lib/bpf: fix build warning if no elf

PATCH In review Stephen Hemminger 2 participants 2 messages Dec 10, 2018 – Dec 11, 2018

Subsystems (3)
Networking Network drivers Library code
lore
Share & tools
lore

Stephen Hemminger

author
#0 lore raw

PATCH 1/1 lib/bpf: fix build warning if no elf

Function was not used unlesss HAVE_ELF causing:

bpf.c:105:13: warning: ‘bpf_map_offload_neutral’ defined but not used [-Wunused-function]

Signed-off-by Stephen Hemminger <[email protected]>
---
 lib/bpf.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
lib/bpf.c +5 -5
index 6aff8f7bad7f..5e85cfc0bdd5 100644
@@ -102,11 +102,6 @@ static const struct bpf_prog_meta __bpf_prog_meta[] = {
 	},
 };
 
-static bool bpf_map_offload_neutral(enum bpf_map_type type)
-{
-	return type == BPF_MAP_TYPE_PERF_EVENT_ARRAY;
-}
-
 static const char *bpf_prog_to_subdir(enum bpf_prog_type type)
 {
 	assert(type < ARRAY_SIZE(__bpf_prog_meta) &&

@@ -1610,6 +1605,11 @@ static bool bpf_is_map_in_map_type(const struct bpf_elf_map *map)
 	       map->type == BPF_MAP_TYPE_HASH_OF_MAPS;
 }
 
+static bool bpf_map_offload_neutral(enum bpf_map_type type)
+{
+	return type == BPF_MAP_TYPE_PERF_EVENT_ARRAY;
+}
+
 static int bpf_map_attach(const char *name, struct bpf_elf_ctx *ctx,
 			  const struct bpf_elf_map *map, struct bpf_map_ext *ext,
 			  int *have_map_in_map)
Signature · 1 line
2.19.2