Skip to contentSkip to conversation

ARM: shmobile: fix build regressions

PATCH In review Arnd Bergmann 3 participants 6 messages Dec 10, 2018 – Dec 17, 2018 Arm/RISC-V/Renesas architecture

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: shmobile: fix build regressions

A number of Kconfig options have become available now to random ARM platforms outside of ARCH_MULTIPLATFORM, which now causes Kconfig warnings, and other build errors when those select options that lack additonal dependencies, e.g.:

WARNING: unmet direct dependencies detected for HAVE_ARM_ARCH_TIMER
Depends on [n]: CPU_V7 [=n]
Selected by [y]:
- ARCH_RCAR_GEN2 [=y] && SOC_RENESAS [=y]
- ARCH_R8A73A4 [=y] && SOC_RENESAS [=y] && ARM [=y]

WARNING: unmet direct dependencies detected for SYS_SUPPORTS_EM_STI
Depends on [n]: GENERIC_CLOCKEVENTS [=n]
Selected by [y]:
- ARCH_EMEV2 [=y] && SOC_RENESAS [=y] && ARM [=y]

Put the old dependency on ARCH_RENESAS back for the moment to restore the previous behavior.

Fixes 062887bf5ef7 ("ARM: shmobile: Move SoC Kconfig symbols to drivers/soc/renesas/")
---
 drivers/soc/renesas/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/soc/renesas/Kconfig +1 -1
index 4d8012e1205c..68bfca6f20dd 100644
@@ -44,7 +44,7 @@ config ARCH_RZN1
 	bool
 	select ARM_AMBA
 
-if ARM
+if ARM && ARCH_RENESAS
 
 #comment "Renesas ARM SoCs System Type"
 
Signature · 1 line
2.20.0
Acked-by on v1 1/1
#1 lore raw

Hi Arnd,

Quoted 11 lines · Arnd Bergmann

A number of Kconfig options have become available now to random ARM platforms outside of ARCH_MULTIPLATFORM, which now causes Kconfig warnings, and other build errors when those select options that lack additonal dependencies, e.g.:

WARNING: unmet direct dependencies detected for HAVE_ARM_ARCH_TIMER
Depends on [n]: CPU_V7 [=n]
Selected by [y]:
- ARCH_RCAR_GEN2 [=y] && SOC_RENESAS [=y]
- ARCH_R8A73A4 [=y] && SOC_RENESAS [=y] && ARM [=y]

Quoted 7 lines

WARNING: unmet direct dependencies detected for SYS_SUPPORTS_EM_STI
Depends on [n]: GENERIC_CLOCKEVENTS [=n]
Selected by [y]:
- ARCH_EMEV2 [=y] && SOC_RENESAS [=y] && ARM [=y]

Put the old dependency on ARCH_RENESAS back for the moment to restore the previous behavior.

Thanks, the build bots must be lazy or overloaded these days... The ARM selects are indeed more troublesome than the ARM64 ones.

BTW, did you see issues with the ARM64 Kconfig symbol move too, or is that mitigated by ARM64 always selecting GENERIC_CLOCKEVENTS?

Quoted 2 lines
Fixes 062887bf5ef7 ("ARM: shmobile: Move SoC Kconfig symbols to drivers/soc/renesas/")

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
#2 lore raw
Quoted 20 lines · Geert Uytterhoeven

Hi Arnd,

Quoted 16 lines · Arnd Bergmann

A number of Kconfig options have become available now to random ARM platforms outside of ARCH_MULTIPLATFORM, which now causes Kconfig warnings, and other build errors when those select options that lack additonal dependencies, e.g.:

WARNING: unmet direct dependencies detected for HAVE_ARM_ARCH_TIMER
Depends on [n]: CPU_V7 [=n]
Selected by [y]:
- ARCH_RCAR_GEN2 [=y] && SOC_RENESAS [=y]
- ARCH_R8A73A4 [=y] && SOC_RENESAS [=y] && ARM [=y]

WARNING: unmet direct dependencies detected for SYS_SUPPORTS_EM_STI
Depends on [n]: GENERIC_CLOCKEVENTS [=n]
Selected by [y]:
- ARCH_EMEV2 [=y] && SOC_RENESAS [=y] && ARM [=y]

Quoted 8 lines
Quoted 2 lines

Put the old dependency on ARCH_RENESAS back for the moment to restore the previous behavior.

Thanks, the build bots must be lazy or overloaded these days... The ARM selects are indeed more troublesome than the ARM64 ones.

BTW, did you see issues with the ARM64 Kconfig symbol move too, or is that mitigated by ARM64 always selecting GENERIC_CLOCKEVENTS?

I restarted my randconfig builder yesterday, and after a few hundred builds on each architecture, I did not see any arm64 failures, so it's probably ok there.
I have a clean build now (about to rebase to today's linux-next, which will surely change that).

Quoted 4 lines
Quoted 2 lines
Fixes 062887bf5ef7 ("ARM: shmobile: Move SoC Kconfig symbols to drivers/soc/renesas/")

Thanks.

Arnd

#3 lore raw
In reply to Arnd Bergmann

Hi Arnd,

Quoted 30 lines · Arnd Bergmann

A number of Kconfig options have become available now to random ARM platforms outside of ARCH_MULTIPLATFORM, which now causes Kconfig warnings, and other build errors when those select options that lack additonal dependencies, e.g.:

WARNING: unmet direct dependencies detected for HAVE_ARM_ARCH_TIMER
Depends on [n]: CPU_V7 [=n]
Selected by [y]:
- ARCH_RCAR_GEN2 [=y] && SOC_RENESAS [=y]
- ARCH_R8A73A4 [=y] && SOC_RENESAS [=y] && ARM [=y]

WARNING: unmet direct dependencies detected for SYS_SUPPORTS_EM_STI
Depends on [n]: GENERIC_CLOCKEVENTS [=n]
Selected by [y]:
- ARCH_EMEV2 [=y] && SOC_RENESAS [=y] && ARM [=y]

Put the old dependency on ARCH_RENESAS back for the moment to restore the previous behavior.

Fixes 062887bf5ef7 ("ARM: shmobile: Move SoC Kconfig symbols to drivers/soc/renesas/")
---
 drivers/soc/renesas/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/soc/renesas/Kconfig +0 -0
index 4d8012e1205c..68bfca6f20dd 100644

drivers/soc/renesas/Kconfig config ARCH_RZN1 · line 47

Quoted 5 lines
drivers/soc/renesas/Kconfig +1 -1
@@ -44,7 +44,7 @@ config ARCH_RZN1
        bool
        select ARM_AMBA
 
-if ARM
+if ARM && ARCH_RENESAS

After a closer look, I think restricting this from ARM to ARCH_MULTI_V7 should work, too (ARCH_MULTI_V7 selects CPU_V7, and ARCH_MULTIPLATFORM selects GENERIC_CLOCKEVENTS).

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
#4 lore raw
Quoted 36 lines · Geert Uytterhoeven

Hi Arnd,

Quoted 33 lines · Arnd Bergmann

A number of Kconfig options have become available now to random ARM platforms outside of ARCH_MULTIPLATFORM, which now causes Kconfig warnings, and other build errors when those select options that lack additonal dependencies, e.g.:

WARNING: unmet direct dependencies detected for HAVE_ARM_ARCH_TIMER
Depends on [n]: CPU_V7 [=n]
Selected by [y]:
- ARCH_RCAR_GEN2 [=y] && SOC_RENESAS [=y]
- ARCH_R8A73A4 [=y] && SOC_RENESAS [=y] && ARM [=y]

WARNING: unmet direct dependencies detected for SYS_SUPPORTS_EM_STI
Depends on [n]: GENERIC_CLOCKEVENTS [=n]
Selected by [y]:
- ARCH_EMEV2 [=y] && SOC_RENESAS [=y] && ARM [=y]

Put the old dependency on ARCH_RENESAS back for the moment to restore the previous behavior.

Fixes 062887bf5ef7 ("ARM: shmobile: Move SoC Kconfig symbols to drivers/soc/renesas/")
---
 drivers/soc/renesas/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/soc/renesas/Kconfig +0 -0
index 4d8012e1205c..68bfca6f20dd 100644
@@ -44,7 +44,7 @@ config ARCH_RZN1
        bool
        select ARM_AMBA
 
Quoted 6 lines

drivers/soc/renesas/Kconfig config ARCH_RZN1 · line 47

Quoted 2 lines
drivers/soc/renesas/Kconfig +1 -1
-if ARM
+if ARM && ARCH_RENESAS

After a closer look, I think restricting this from ARM to ARCH_MULTI_V7 should work, too (ARCH_MULTI_V7 selects CPU_V7, and ARCH_MULTIPLATFORM selects GENERIC_CLOCKEVENTS).

Hi Arnd,

what is your preferred way forwards here?
I'm tempted to take your patch as-is and then work on refining the dependency as a follow-up.

#5 lore raw
Quoted 44 lines · Simon Horman
Quoted 36 lines · Geert Uytterhoeven

Hi Arnd,

Quoted 33 lines · Arnd Bergmann

A number of Kconfig options have become available now to random ARM platforms outside of ARCH_MULTIPLATFORM, which now causes Kconfig warnings, and other build errors when those select options that lack additonal dependencies, e.g.:

WARNING: unmet direct dependencies detected for HAVE_ARM_ARCH_TIMER
Depends on [n]: CPU_V7 [=n]
Selected by [y]:
- ARCH_RCAR_GEN2 [=y] && SOC_RENESAS [=y]
- ARCH_R8A73A4 [=y] && SOC_RENESAS [=y] && ARM [=y]

WARNING: unmet direct dependencies detected for SYS_SUPPORTS_EM_STI
Depends on [n]: GENERIC_CLOCKEVENTS [=n]
Selected by [y]:
- ARCH_EMEV2 [=y] && SOC_RENESAS [=y] && ARM [=y]

Put the old dependency on ARCH_RENESAS back for the moment to restore the previous behavior.

Fixes 062887bf5ef7 ("ARM: shmobile: Move SoC Kconfig symbols to drivers/soc/renesas/")
---
 drivers/soc/renesas/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/soc/renesas/Kconfig +0 -0
index 4d8012e1205c..68bfca6f20dd 100644
@@ -44,7 +44,7 @@ config ARCH_RZN1
        bool
        select ARM_AMBA
 
Quoted 6 lines

drivers/soc/renesas/Kconfig config ARCH_RZN1 · line 47

Quoted 2 lines
drivers/soc/renesas/Kconfig +1 -1
-if ARM
+if ARM && ARCH_RENESAS

After a closer look, I think restricting this from ARM to ARCH_MULTI_V7 should work, too (ARCH_MULTI_V7 selects CPU_V7, and ARCH_MULTIPLATFORM selects GENERIC_CLOCKEVENTS).

Quoted 5 lines

Hi Arnd,

what is your preferred way forwards here?
I'm tempted to take your patch as-is and then work on refining the dependency as a follow-up.

I have gone ahead and applied Arnd's patch as a fix for v4.21. It seems like the safest option for a fix.