Skip to contentSkip to conversation

dt-bindings: media: tegra-cec: Document Tegra186 and Tegra194

PATCH In review Thierry Reding 2 participants 5 messages Dec 11, 2018 – Dec 18, 2018

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/3 dt-bindings: media: tegra-cec: Document Tegra186 and Tegra194

From: Thierry Reding <[email protected]>

The Tegra186 and Tegra194 contain a CEC controller that is identical to that found in earlier generations. Document the compatible strings for these newer chips.

---
Changes in v2:
- new patch adding missing compatible strings

 Documentation/devicetree/bindings/media/tegra-cec.txt | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/media/tegra-cec.txt +2 -0
index c503f06f3b84..da3590f0b7a1 100644
@@ -8,6 +8,8 @@ Required properties:
 	"nvidia,tegra114-cec"
 	"nvidia,tegra124-cec"
 	"nvidia,tegra210-cec"
+	"nvidia,tegra186-cec"
+	"nvidia,tegra194-cec"
   - reg : Physical base address of the IP registers and length of memory
 	  mapped region.
   - interrupts : HDMI CEC interrupt number to the CPU.
Signature · 1 line
2.19.1
#1 lore raw

PATCH v2 2/3 media: tegra-cec: Support Tegra186 and Tegra194

From: Thierry Reding <[email protected]>

The CEC controller found on Tegra186 and Tegra194 is the same as on earlier generations.

---
 drivers/media/platform/tegra-cec/tegra_cec.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/media/platform/tegra-cec/tegra_cec.c +2 -0
index aba488cd0e64..8a1e10d008d0 100644
@@ -472,6 +472,8 @@ static const struct of_device_id tegra_cec_of_match[] = {
 	{ .compatible = "nvidia,tegra114-cec", },
 	{ .compatible = "nvidia,tegra124-cec", },
 	{ .compatible = "nvidia,tegra210-cec", },
+	{ .compatible = "nvidia,tegra186-cec", },
+	{ .compatible = "nvidia,tegra194-cec", },
 	{},
 };
 
Signature · 1 line
2.19.1
#2 lore raw

PATCH v2 3/3 media: tegra-cec: Export OF device ID match table

In reply to Thierry Reding

From: Thierry Reding <[email protected]>

Exporting the OF device ID match table allows udev to automatically load the module upon receiving an "ADD" uevent for the CEC controller device.

---
 drivers/media/platform/tegra-cec/tegra_cec.c | 1 +
 1 file changed, 1 insertion(+)
drivers/media/platform/tegra-cec/tegra_cec.c +1 -0
index 8a1e10d008d0..4e9f91528f77 100644
@@ -476,6 +476,7 @@ static const struct of_device_id tegra_cec_of_match[] = {
 	{ .compatible = "nvidia,tegra194-cec", },
 	{},
 };
+MODULE_DEVICE_TABLE(of, tegra_cec_of_match);
 
 static struct platform_driver tegra_cec_driver = {
 	.driver = {
Signature · 1 line
2.19.1
maintainer
#3 lore raw
In reply to Thierry Reding
Quoted 5 lines · Thierry Reding

From: Thierry Reding <[email protected]>

The Tegra186 and Tegra194 contain a CEC controller that is identical to that found in earlier generations. Document the compatible strings for these newer chips.

If identical, why don't you have a fallback compatible?

Quoted 25 lines

---
Changes in v2:
- new patch adding missing compatible strings

 Documentation/devicetree/bindings/media/tegra-cec.txt | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/media/tegra-cec.txt +2 -0
index c503f06f3b84..da3590f0b7a1 100644
@@ -8,6 +8,8 @@ Required properties:
 	"nvidia,tegra114-cec"
 	"nvidia,tegra124-cec"
 	"nvidia,tegra210-cec"
+	"nvidia,tegra186-cec"
+	"nvidia,tegra194-cec"
   - reg : Physical base address of the IP registers and length of memory
 	  mapped region.
   - interrupts : HDMI CEC interrupt number to the CPU.
Signature · 1 line
2.19.1
#4 lore raw
Quoted 8 lines · Rob Herring
Quoted 5 lines · Thierry Reding

From: Thierry Reding <[email protected]>

The Tegra186 and Tegra194 contain a CEC controller that is identical to that found in earlier generations. Document the compatible strings for these newer chips.

If identical, why don't you have a fallback compatible?

That's a good point. I think it would be fine to always fall back to the nvidia,tegra20-cec compatible.

Thierry