package/intel-microcode: don't use install -D -t
PATCH 1/1 package/intel-microcode: don't use install -D -t
Commit 1f0beaf9a8e2b8f0bb6e53694b38d70900b9128f ("intel-microcode:
bump to version 20180807a") introduced the use of "install -D -t" to the intel-microcode package. The intent is that install will create the full destination directory, including all components leading to it, before copying the files.
Unfortunately, "install -D -t" is only supported since coreutils since v8.23. Several of the build systems we support have older coreutils versions, such as Debian 7, which uses coreutils 8.13. Ubuntu 14.04 also doesn't have a recent enough coreutils.
So let's create the directory explicitly first, and then use a more regular "install -t".
Fixes:
http://autobuild.buildroot.net/results/aa44f9ff90f296f886be6309b3355ed075494fb2/
Note: the "gzip: stdout: Broken pipe" messages in those failures seem unrelated. We have been able to reproduce the installation failure without those "Broken pipe" issues, and we have not been able to reproduce those "Broken pipe" problems.
--- package/intel-microcode/intel-microcode.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
package/intel-microcode/intel-microcode.mk +2 -1
@@ -13,7 +13,8 @@ INTEL_MICROCODE_LICENSE_FILES = license INTEL_MICROCODE_REDISTRIBUTE = NO define INTEL_MICROCODE_INSTALL_TARGET_CMDS - $(INSTALL) -D -m 0644 -t $(TARGET_DIR)/lib/firmware/intel-ucode \ + mkdir -p $(TARGET_DIR)/lib/firmware/intel-ucode + $(INSTALL) -m 0644 -t $(TARGET_DIR)/lib/firmware/intel-ucode \ $(@D)/intel-ucode/* endef
Signature · 1 line
2.19.2
PATCH 1/1 package/intel-microcode: don't use install -D -t
Quoted 48 lines
From: "Thomas Petazzoni" <[email protected]>
To: "buildroot" <[email protected]>
Cc: "Carlos Santos" <[email protected]>, "Thomas Petazzoni" <[email protected]>, "Maxime Hadjinlian" <[email protected]>
Sent: Ter?a-feira, 11 de dezembro de 2018 13:30:05
Subject: [PATCH] package/intel-microcode: don't use install -D -tCommit
1f0beaf9a8e2b8f0bb6e53694b38d70900b9128f("intel-microcode:
bump to version20180807a") introduced the use of "install -D -t" to the intel-microcode package. The intent is that install will create the full destination directory, including all components leading to it, before copying the files.Unfortunately, "install -D -t" is only supported since coreutils since v8.23. Several of the build systems we support have older coreutils versions, such as Debian 7, which uses coreutils 8.13. Ubuntu 14.04 also doesn't have a recent enough coreutils.
So let's create the directory explicitly first, and then use a more regular "install -t".
Fixes:
http://autobuild.buildroot.net/results/aa44f9ff90f296f886be6309b3355ed075494fb2/
Note: the "gzip: stdout: Broken pipe" messages in those failures seem unrelated. We have been able to reproduce the installation failure without those "Broken pipe" issues, and we have not been able to reproduce those "Broken pipe" problems.
Signed-off-by Thomas Petazzoni <[email protected]>---
package/intel-microcode/intel-microcode.mk| 3 ++-1 file changed, 2 insertions(+), 1 deletion(-)package/intel-microcode/intel-microcode.mk +0
-0@@ -13,7 +13,8 @@ INTEL_MICROCODE_LICENSE_FILES = license
INTEL_MICROCODE_REDISTRIBUTE= NOdefine
INTEL_MICROCODE_INSTALL_TARGET_CMDSpackage/intel-microcode/intel-microcode.mk +2
-1- $(INSTALL) -D -m 0644 -t $(TARGET_DIR)/lib/firmware/intel-ucode \ + mkdir -p $(TARGET_DIR)/lib/firmware/intel-ucode + $(INSTALL) -m 0644 -t $(TARGET_DIR)/lib/firmware/intel-ucode \$(@D)/intel-ucode/*
Quoted 4 lines
endef
--
2.19.2
Tested on a DATACOM device with Intel C3000 processor.
Signature · 1 line
Carlos Santos (Casantos) - DATACOM, P&D
Arnout Vandecappelle
AppliedPATCH 1/1 package/intel-microcode: don't use install -D -t
In reply to Thomas PetazzoniQuoted 16 lines · Thomas Petazzoni
Commit
1f0beaf9a8e2b8f0bb6e53694b38d70900b9128f("intel-microcode:
bump to version20180807a") introduced the use of "install -D -t" to the intel-microcode package. The intent is that install will create the full destination directory, including all components leading to it, before copying the files.Unfortunately, "install -D -t" is only supported since coreutils since v8.23. Several of the build systems we support have older coreutils versions, such as Debian 7, which uses coreutils 8.13. Ubuntu 14.04 also doesn't have a recent enough coreutils.
So let's create the directory explicitly first, and then use a more regular "install -t".
Fixes:
Quoted 8 lines
http://autobuild.buildroot.net/results/aa44f9ff90f296f886be6309b3355ed075494fb2/
Note: the "gzip: stdout: Broken pipe" messages in those failures seem unrelated. We have been able to reproduce the installation failure without those "Broken pipe" issues, and we have not been able to reproduce those "Broken pipe" problems.
Signed-off-by Thomas Petazzoni <[email protected]>
Applied to master, thanks.
Regards,
Arnout
Quoted 19 lines
--- package/intel-microcode/intel-microcode.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)package/intel-microcode/intel-microcode.mk +2
-1@@ -13,7 +13,8 @@ INTEL_MICROCODE_LICENSE_FILES = license INTEL_MICROCODE_REDISTRIBUTE = NO define INTEL_MICROCODE_INSTALL_TARGET_CMDS - $(INSTALL) -D -m 0644 -t $(TARGET_DIR)/lib/firmware/intel-ucode \ + mkdir -p $(TARGET_DIR)/lib/firmware/intel-ucode + $(INSTALL) -m 0644 -t $(TARGET_DIR)/lib/firmware/intel-ucode \ $(@D)/intel-ucode/* endef