Skip to contentSkip to conversation

arm: ti: boot: Increase system partition size

PATCH In review Sam Protsenko 4 participants 8 messages Dec 11, 2018 – Jul 16, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: ti: boot: Increase system partition size

Android code base is growing, so since Android "Pie" the size of system.img grew up to be about 740 MiB. Let's increase system.img to 1 GiB to accommodate for those changes and leave some margin for future changes. We don't want to make it more than 1 GiB, because we should keep userdata partition big enough (for user files, like media etc.), and eMMC size on BeagleBoard-X15 is only 3.5 GiB.

---
 include/environment/ti/boot.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/environment/ti/boot.h +1 -1
index 5891009a5a..86ff6d3ea7 100644
@@ -41,7 +41,7 @@
 	"name=crypto,size=16K,uuid=${uuid_gpt_crypto};" \
 	"name=recovery,size=40M,uuid=${uuid_gpt_recovery};" \
 	"name=boot,size=10M,uuid=${uuid_gpt_boot};" \
-	"name=system,size=768M,uuid=${uuid_gpt_system};" \
+	"name=system,size=1024M,uuid=${uuid_gpt_system};" \
 	"name=vendor,size=256M,uuid=${uuid_gpt_vendor};" \
 	"name=cache,size=256M,uuid=${uuid_gpt_cache};" \
 	"name=ipu1,size=1M,uuid=${uuid_gpt_ipu1};" \
Signature · 1 line
2.19.1
#1 lore raw

PATCH 1/1 arm: ti: boot: Increase system partition size

Quoted 8 lines · Sam Protsenko

Android code base is growing, so since Android "Pie" the size of system.img grew up to be about 740 MiB. Let's increase system.img to 1 GiB to accommodate for those changes and leave some margin for future changes. We don't want to make it more than 1 GiB, because we should keep userdata partition big enough (for user files, like media etc.), and eMMC size on BeagleBoard-X15 is only 3.5 GiB.

Quoted 17 lines
---
  include/environment/ti/boot.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
include/environment/ti/boot.h +1 -1
index 5891009a5a..86ff6d3ea7 100644
@@ -41,7 +41,7 @@
  	"name=crypto,size=16K,uuid=${uuid_gpt_crypto};" \
  	"name=recovery,size=40M,uuid=${uuid_gpt_recovery};" \
  	"name=boot,size=10M,uuid=${uuid_gpt_boot};" \
-	"name=system,size=768M,uuid=${uuid_gpt_system};" \
+	"name=system,size=1024M,uuid=${uuid_gpt_system};" \
  	"name=vendor,size=256M,uuid=${uuid_gpt_vendor};" \
  	"name=cache,size=256M,uuid=${uuid_gpt_cache};" \
  	"name=ipu1,size=1M,uuid=${uuid_gpt_ipu1};" \
#2 lore raw

PATCH 1/1 arm: ti: boot: Increase system partition size

Sam,

Quoted 15 lines · Praneeth
Quoted 8 lines · Sam Protsenko

Android code base is growing, so since Android "Pie" the size of system.img grew up to be about 740 MiB. Let's increase system.img to 1 GiB to accommodate for those changes and leave some margin for future changes. We don't want to make it more than 1 GiB, because we should keep userdata partition big enough (for user files, like media etc.), and eMMC size on BeagleBoard-X15 is only 3.5 GiB.

Quoted 4 lines

---
  include/environment/ti/boot.h | 2 +-

  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 11 lines

include/environment/ti/boot.h line 44

Quoted 11 lines
include/environment/ti/boot.h +1 -1
index 5891009a5a..86ff6d3ea7 100644
@@ -41,7 +41,7 @@
       "name=crypto,size=16K,uuid=${uuid_gpt_crypto};" \
       "name=recovery,size=40M,uuid=${uuid_gpt_recovery};" \
       "name=boot,size=10M,uuid=${uuid_gpt_boot};" \
-    "name=system,size=768M,uuid=${uuid_gpt_system};" \
+    "name=system,size=1024M,uuid=${uuid_gpt_system};" \

while at it,

Can you remove the legacy partitions which are not applicable anymore for X15.

remove : reserved, efs,crypto,cache,ipu1,ipu2. This will give more storage for userdata

we can still use misc for reboot reason storage for the purpose of fastboot reboot to (bootloader or recovery)

Quoted 3 lines
Quoted 3 lines
include/environment/ti/boot.h +0 -0
 "name=vendor,size=256M,uuid=${uuid_gpt_vendor};" \
       "name=cache,size=256M,uuid=${uuid_gpt_cache};" \
       "name=ipu1,size=1M,uuid=${uuid_gpt_ipu1};" \
#3 lore raw

PATCH 1/1 arm: ti: boot: Increase system partition size

Hi Praneeth,

Quoted 33 lines · Praneeth

Sam,

Quoted 15 lines · Praneeth
Quoted 8 lines · Sam Protsenko

Android code base is growing, so since Android "Pie" the size of system.img grew up to be about 740 MiB. Let's increase system.img to 1 GiB to accommodate for those changes and leave some margin for future changes. We don't want to make it more than 1 GiB, because we should keep userdata partition big enough (for user files, like media etc.), and eMMC size on BeagleBoard-X15 is only 3.5 GiB.

Quoted 4 lines
---
  include/environment/ti/boot.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 11 lines

include/environment/ti/boot.h line 44

Quoted 11 lines
include/environment/ti/boot.h +1 -1
index 5891009a5a..86ff6d3ea7 100644
@@ -41,7 +41,7 @@
      "name=crypto,size=16K,uuid=${uuid_gpt_crypto};" \
      "name=recovery,size=40M,uuid=${uuid_gpt_recovery};" \
      "name=boot,size=10M,uuid=${uuid_gpt_boot};" \
-    "name=system,size=768M,uuid=${uuid_gpt_system};" \
+    "name=system,size=1024M,uuid=${uuid_gpt_system};" \

while at it,

Quoted 6 lines

Can you remove the legacy partitions which are not applicable anymore for X15.

remove : reserved, efs,crypto,cache,ipu1,ipu2. This will give more storage for userdata

Actually this file is also used for DRA7 and OMAP5 boards. Do you know if we need ipu* partitions on DRA7?

"reserved" is actually used to mark U-Boot environment, so I guess I will rename it rather them remove.

As for the other partitions, like cache, I think you're right. We shouldn't try and support old Androids in new U-Boot, we have older release tags for this. But I'd prefer to send that change in a separate patch, due to commit message and atomicity.

Thanks.

Quoted 6 lines

we can still use misc for reboot reason storage for the purpose of fastboot reboot to (bootloader or recovery)

Quoted 3 lines
Quoted 3 lines
include/environment/ti/boot.h +0 -0
 "name=vendor,size=256M,uuid=${uuid_gpt_vendor};" \
      "name=cache,size=256M,uuid=${uuid_gpt_cache};" \
      "name=ipu1,size=1M,uuid=${uuid_gpt_ipu1};" \
#4 lore raw

PATCH 1/1 arm: ti: boot: Increase system partition size

Quoted 33 lines · Sam Protsenko

Hi Praneeth,

Quoted 30 lines · Praneeth

Sam,

Quoted 14 lines · Praneeth
Quoted 8 lines · Sam Protsenko

Android code base is growing, so since Android "Pie" the size of system.img grew up to be about 740 MiB. Let's increase system.img to 1 GiB to accommodate for those changes and leave some margin for future changes. We don't want to make it more than 1 GiB, because we should keep userdata partition big enough (for user files, like media etc.), and eMMC size on BeagleBoard-X15 is only 3.5 GiB.

Quoted 4 lines
---
   include/environment/ti/boot.h | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 11 lines

include/environment/ti/boot.h line 44

Quoted 11 lines
include/environment/ti/boot.h +1 -1
index 5891009a5a..86ff6d3ea7 100644
@@ -41,7 +41,7 @@
       "name=crypto,size=16K,uuid=${uuid_gpt_crypto};" \
       "name=recovery,size=40M,uuid=${uuid_gpt_recovery};" \
       "name=boot,size=10M,uuid=${uuid_gpt_boot};" \
-    "name=system,size=768M,uuid=${uuid_gpt_system};" \
+    "name=system,size=1024M,uuid=${uuid_gpt_system};" \

while at it,

Quoted 8 lines
Quoted 6 lines

Can you remove the legacy partitions which are not applicable anymore for X15.

remove : reserved, efs,crypto,cache,ipu1,ipu2. This will give more storage for userdata

Actually this file is also used for DRA7 and OMAP5 boards. Do you know if we need ipu* partitions on DRA7?

Can be removed for DRA7.
IPU firmware is part of vendor image and doesnt reside as a separate partition

Quoted 8 lines

"reserved" is actually used to mark U-Boot environment, so I guess I will rename it rather them remove.

As for the other partitions, like cache, I think you're right. We shouldn't try and support old Androids in new U-Boot, we have older release tags for this. But I'd prefer to send that change in a separate patch, due to commit message and atomicity.

the current fix itself for increasing system image size  is fine. Ok on cleaning up legacy partitions with a patch on top

Quoted 9 lines

Thanks.

Quoted 6 lines

we can still use misc for reboot reason storage for the purpose of fastboot reboot to (bootloader or recovery)

Quoted 3 lines
Quoted 3 lines
include/environment/ti/boot.h +0 -0
 "name=vendor,size=256M,uuid=${uuid_gpt_vendor};" \
       "name=cache,size=256M,uuid=${uuid_gpt_cache};" \
       "name=ipu1,size=1M,uuid=${uuid_gpt_ipu1};" \
#5 lore raw

PATCH 1/1 arm: ti: boot: Increase system partition size

Hi Tom,

Could you please merge this as is? I'll do discussed legacy partitions cleaning in next patch.

Thanks.

Quoted 70 lines · Praneeth
Quoted 33 lines · Sam Protsenko

Hi Praneeth,

Quoted 30 lines · Praneeth

Sam,

Quoted 14 lines · Praneeth
Quoted 8 lines · Sam Protsenko

Android code base is growing, so since Android "Pie" the size of system.img grew up to be about 740 MiB. Let's increase system.img to 1 GiB to accommodate for those changes and leave some margin for future changes. We don't want to make it more than 1 GiB, because we should keep userdata partition big enough (for user files, like media etc.), and eMMC size on BeagleBoard-X15 is only 3.5 GiB.

Quoted 4 lines
---
   include/environment/ti/boot.h | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 11 lines

include/environment/ti/boot.h line 44

Quoted 11 lines
include/environment/ti/boot.h +1 -1
index 5891009a5a..86ff6d3ea7 100644
@@ -41,7 +41,7 @@
       "name=crypto,size=16K,uuid=${uuid_gpt_crypto};" \
       "name=recovery,size=40M,uuid=${uuid_gpt_recovery};" \
       "name=boot,size=10M,uuid=${uuid_gpt_boot};" \
-    "name=system,size=768M,uuid=${uuid_gpt_system};" \
+    "name=system,size=1024M,uuid=${uuid_gpt_system};" \

while at it,

Quoted 8 lines
Quoted 6 lines

Can you remove the legacy partitions which are not applicable anymore for X15.

remove : reserved, efs,crypto,cache,ipu1,ipu2. This will give more storage for userdata

Actually this file is also used for DRA7 and OMAP5 boards. Do you know if we need ipu* partitions on DRA7?

Can be removed for DRA7.
IPU firmware is part of vendor image and doesnt reside as a separate partition

Quoted 8 lines

"reserved" is actually used to mark U-Boot environment, so I guess I will rename it rather them remove.

As for the other partitions, like cache, I think you're right. We shouldn't try and support old Androids in new U-Boot, we have older release tags for this. But I'd prefer to send that change in a separate patch, due to commit message and atomicity.

the current fix itself for increasing system image size is fine. Ok on cleaning up legacy partitions with a patch on top

Quoted 9 lines

Thanks.

Quoted 6 lines

we can still use misc for reboot reason storage for the purpose of fastboot reboot to (bootloader or recovery)

Quoted 3 lines
Quoted 3 lines
include/environment/ti/boot.h +0 -0
 "name=vendor,size=256M,uuid=${uuid_gpt_vendor};" \
       "name=cache,size=256M,uuid=${uuid_gpt_cache};" \
       "name=ipu1,size=1M,uuid=${uuid_gpt_ipu1};" \
#6 lore raw
In reply to Sam Protsenko
Quoted 9 lines · Sam Protsenko

Android code base is growing, so since Android "Pie" the size of system.img grew up to be about 740 MiB. Let's increase system.img to 1 GiB to accommodate for those changes and leave some margin for future changes. We don't want to make it more than 1 GiB, because we should keep userdata partition big enough (for user files, like media etc.), and eMMC size on BeagleBoard-X15 is only 3.5 GiB.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181217/cbe2385f/attachment.sig>
#7 lore raw

PATCH 1/1 arm: ti: boot: Increase system partition size

In reply to Sam Protsenko
Quoted 8 lines · Sam Protsenko

Android code base is growing, so since Android "Pie" the size of system.img grew up to be about 740 MiB. Let's increase system.img to 1 GiB to accommodate for those changes and leave some margin for future changes. We don't want to make it more than 1 GiB, because we should keep userdata partition big enough (for user files, like media etc.), and eMMC size on BeagleBoard-X15 is only 3.5 GiB.

Thanks and regards,
Lokesh