Skip to contentSkip to conversation

x86: edison: move CONFIG_CMD_PCI from header file to defconfig

PATCH New Andy Shevchenko 2 participants 9 messages Dec 11, 2018 – Dec 31, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 x86: edison: move CONFIG_CMD_PCI from header file to defconfig

Use defconfig instead of header file for CONFIG_CMD_PCI.

---
 configs/edison_defconfig | 1 -
 include/configs/edison.h | 3 ---
 2 files changed, 4 deletions(-)
configs/edison_defconfig +0 -1
index b523fe92ce..e376c0cea6 100644
@@ -19,7 +19,6 @@ CONFIG_CMD_DFU=y
 CONFIG_CMD_GPT=y
 CONFIG_CMD_MMC=y
 CONFIG_CMD_PART=y
-# CONFIG_CMD_PCI is not set
 # CONFIG_CMD_NFS is not set
 CONFIG_CMD_TIMER=y
 CONFIG_CMD_HASH=y
include/configs/edison.h +0 -3
index 86c584d73d..8e312da2da 100644
@@ -43,9 +43,6 @@
 #define CONFIG_ENV_OFFSET_REDUND		(6 * 1024 * 1024)
 #define CONFIG_SUPPORT_EMMC_BOOT
 
-/* PCI */
-#define CONFIG_CMD_PCI
-
 /* RTC */
 #define CONFIG_SYS_ISA_IO_BASE_ADDRESS	0
 
Signature · 1 line
2.19.2
#1 lore raw

PATCH 2/3 x86: edison: move CONFIG_BOOTCOMMAND from header file to defconfig

Use defconfig instead of header file for CONFIG_BOOTCOMMAND.

---
 include/configs/edison.h | 3 ---
 1 file changed, 3 deletions(-)
include/configs/edison.h +0 -3
index 8e312da2da..7e2f9c129e 100644
@@ -10,9 +10,6 @@
 
 /* ACPI */
 
-/* Boot */
-#define CONFIG_BOOTCOMMAND "run bootcmd"
-
 /* DISK Partition support */
 
 /* Miscellaneous configurable options */
Signature · 1 line
2.19.2
#3 lore raw

PATCH 2/3 x86: edison: move CONFIG_BOOTCOMMAND from header file to defconfig

Quoted 6 lines · Bin Meng
Quoted 3 lines · Andy Shevchenko

Use defconfig instead of header file for CONFIG_BOOTCOMMAND.

Quoted 7 lines
Quoted 5 lines
---
 include/configs/edison.h | 3 ---
 1 file changed, 3 deletions(-)

applied to u-boot-x86, thanks!

#4 lore raw

PATCH 3/3 x86: edison: Remove staled comments from configuration header

In reply to Andy Shevchenko

Since some options had been moved to defconfig from header, the leftover comments are not needed anymore. Remove them.

---
 include/configs/edison.h | 4 ----
 1 file changed, 4 deletions(-)
include/configs/edison.h +0 -4
index 7e2f9c129e..a6155ba5a8 100644
@@ -8,10 +8,6 @@
 
 #include <asm/ibmpc.h>
 
-/* ACPI */
-
-/* DISK Partition support */
-
 /* Miscellaneous configurable options */
 
 #define CONFIG_SYS_CBSIZE	2048
Signature · 1 line
2.19.2
#5 lore raw

PATCH 3/3 x86: edison: Remove staled comments from configuration header

Quoted 9 lines · Andy Shevchenko

Since some options had been moved to defconfig from header, the leftover comments are not needed anymore. Remove them.

---
 include/configs/edison.h | 4 ----
 1 file changed, 4 deletions(-)
#6 lore raw

PATCH 3/3 x86: edison: Remove staled comments from configuration header

Quoted 7 lines · Bin Meng
Quoted 4 lines · Andy Shevchenko

Since some options had been moved to defconfig from header, the leftover comments are not needed anymore. Remove them.

Quoted 7 lines
Quoted 5 lines
---
 include/configs/edison.h | 4 ----
 1 file changed, 4 deletions(-)

applied to u-boot-x86, thanks!

#8 lore raw

PATCH 1/3 x86: edison: move CONFIG_CMD_PCI from header file to defconfig

Quoted 6 lines · Bin Meng
Quoted 3 lines · Andy Shevchenko

Use defconfig instead of header file for CONFIG_CMD_PCI.

Quoted 8 lines
Quoted 6 lines
---
 configs/edison_defconfig | 1 -
 include/configs/edison.h | 3 ---
 2 files changed, 4 deletions(-)

applied to u-boot-x86, thanks!