Skip to contentSkip to conversation

nvme-ioctl: clear rae for discovery log pages

PATCH New Sagi Grimberg 3 participants 4 messages Dec 7, 2018 – Dec 13, 2018 NVMe

lore
Share & tools
lore

Sagi Grimberg

author maintainer
#0 lore raw

PATCH 1/1 nvme-ioctl: clear rae for discovery log pages

The discovery controller should now be able to send us discovery log change events so we need to clear the rae bit for that.

Signed-off-by Sagi Grimberg <sagi at grimberg.me>
---
 nvme-ioctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
nvme-ioctl.c +1 -1
index be0823dfbcc2..70a16ced925a 100644
@@ -504,7 +504,7 @@ int nvme_effects_log(int fd, struct nvme_effects_log_page *effects_log)
 
 int nvme_discovery_log(int fd, struct nvmf_disc_rsp_page_hdr *log, __u32 size)
 {
-	return nvme_get_log(fd, 0, NVME_LOG_DISC, true, size, log);
+	return nvme_get_log(fd, 0, NVME_LOG_DISC, false, size, log);
 }
 
 int nvme_sanitize_log(int fd, struct nvme_sanitize_log_page *sanitize_log)
Signature · 1 line
2.17.1
Applied
#1 lore raw

PATCH 1/1 nvme-ioctl: clear rae for discovery log pages

Quoted 5 lines · Sagi Grimberg

The discovery controller should now be able to send us discovery log change events so we need to clear the rae bit for that.

Signed-off-by Sagi Grimberg <sagi at grimberg.me>

Applied, thanks.

maintainer
#2 lore raw

PATCH 1/1 nvme-ioctl: clear rae for discovery log pages

In reply to Sagi Grimberg
Quoted 3 lines · Sagi Grimberg

The discovery controller should now be able to send us discovery log change events so we need to clear the rae bit for that.

Btw, I really think we need to clear the RAE bit in the kernel with a small whitelist for those AENs that we pass on to userspace so that we don't accidentally get the bit cleared. What do you think?

author maintainer
#3 lore raw

PATCH 1/1 nvme-ioctl: clear rae for discovery log pages

Quoted 8 lines
Quoted 4 lines

The discovery controller should now be able to send us discovery log change events so we need to clear the rae bit for that.

Btw, I really think we need to clear the RAE bit in the kernel with a small whitelist for those AENs that we pass on to userspace so that we don't accidentally get the bit cleared. What do you think?

Makes sense...