Skip to contentSkip to conversation

package/sdl2_net: add missing host-pkgconf dependency

PATCH New Thomas Petazzoni 2 participants 3 messages Dec 12, 2018 – Dec 16, 2018

lore
Share & tools
lore

Thomas Petazzoni

author
#0 lore raw

PATCH 1/1 package/sdl2_net: add missing host-pkgconf dependency

The sdl2_net configure script uses pkg-config to finx sdl2. If it doesn't find pkg-config, it tries to locate sdl2-config, and defaults to /usr/bin/sdl2-config, which causes the build to fail with:

arm-linux-gcc: ERROR: unsafe header/library path used in cross-compilation: '-I/usr/include/SDL2'

Fix this by adding host-pkgconf to the dependencies of sdl2_net. We could have added the right autoconf cache variable to tell the configure script where sdl2-config is located, but since pkg-config is tried first, let's use that.

Signed-off-by Thomas Petazzoni <[email protected]>
---
 package/sdl2_net/sdl2_net.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/sdl2_net/sdl2_net.mk +1 -1
index 2fa4a8c2e0..93bf3a2eb3 100644
@@ -10,6 +10,6 @@ SDL2_NET_SITE = http://www.libsdl.org/projects/SDL_net/release
 SDL2_NET_LICENSE = Zlib
 SDL2_NET_LICENSE_FILES = COPYING.txt
 SDL2_NET_INSTALL_STAGING = YES
-SDL2_NET_DEPENDENCIES = sdl2
+SDL2_NET_DEPENDENCIES = sdl2 host-pkgconf
 
 $(eval $(autotools-package))
Signature · 1 line
2.19.2
author Applied
#1 lore raw

PATCH 1/1 package/sdl2_net: add missing host-pkgconf dependency

Hello,

Quoted 11 lines · Thomas Petazzoni

The sdl2_net configure script uses pkg-config to finx sdl2. If it doesn't find pkg-config, it tries to locate sdl2-config, and defaults to /usr/bin/sdl2-config, which causes the build to fail with:

arm-linux-gcc: ERROR: unsafe header/library path used in cross-compilation: '-I/usr/include/SDL2'

Fix this by adding host-pkgconf to the dependencies of sdl2_net. We could have added the right autoconf cache variable to tell the configure script where sdl2-config is located, but since pkg-config is tried first, let's use that.

Quoted 4 lines
Signed-off-by Thomas Petazzoni <[email protected]>
---
 package/sdl2_net/sdl2_net.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/sdl2_net: add missing host-pkgconf dependency

In reply to Thomas Petazzoni
Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

The sdl2_net configure script uses pkg-config to finx sdl2. If it doesn't find pkg-config, it tries to locate sdl2-config, and defaults to /usr/bin/sdl2-config, which causes the build to fail with:

Quoted 8 lines

arm-linux-gcc: ERROR: unsafe header/library path used in cross-compilation: '-I/usr/include/SDL2'

Fix this by adding host-pkgconf to the dependencies of sdl2_net. We could have added the right autoconf cache variable to tell the configure script where sdl2-config is located, but since pkg-config is tried first, let's use that.

Signed-off-by Thomas Petazzoni <[email protected]>

Committed to 2018.02.x, 2018.08.x and 2018.11.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard