Skip to contentSkip to conversation

pci: pci_ids: Add Synopsys device id 0xedda

RFC New Bjorn Helgaas 1 participant 1 message Dec 12, 2018

Subsystems (2)
PCI dmaengine
lore
Share & tools
lore

Bjorn Helgaas

author
#0 lore raw

RFC 6/6 pci: pci_ids: Add Synopsys device id 0xedda

Quoted 3 lines · Gustavo Pimentel

Create and add Synopsys device id (0xedda) to pci id list, since this id is now being use on two different drivers (pci_endpoint_test.ko and dw-edma-pcie.ko).

Please run "git log --oneline include/linux/pci_ids.h" and make your subject line match, i.e.,

PCI: Add Synopsys endpoint EDDA Device ID

Also, if you want, you can reorder this to add the ID first and use it in drivers/misc/pci_endpoint_test.c, and then just use it from the first appearance of drivers/dma/dw-edma/dw-edma-pcie.c. Either way is fine.

For the include/linux/pci_ids.h change,

Acked-by Bjorn Helgaas <[email protected]>
Quoted 52 lines
Signed-off-by Gustavo Pimentel <[email protected]>
Cc Kishon Vijay Abraham I <[email protected]>
Cc Bjorn Helgaas <[email protected]>
Cc Lorenzo Pieralisi <[email protected]>
Cc Joao Pinto <[email protected]>
---
 drivers/dma/dw-edma/dw-edma-pcie.c | 2 +-
 drivers/misc/pci_endpoint_test.c   | 2 +-
 include/linux/pci_ids.h            | 1 +
 3 files changed, 3 insertions(+), 2 deletions(-)
drivers/dma/dw-edma/dw-edma-pcie.c +1 -1
index f29a861..50e0db4 100644
@@ -280,7 +280,7 @@ static const struct dev_pm_ops dw_edma_pcie_dev_pm_ops = {
 };
 
 static const struct pci_device_id dw_edma_pcie_id_table[] = {
-	{ PCI_DEVICE_DATA(SYNOPSYS, 0xedda, &snps_edda_data) },
+	{ PCI_DEVICE_DATA(SYNOPSYS, EDDA, &snps_edda_data) },
 	{ }
 };
 MODULE_DEVICE_TABLE(pci, dw_edma_pcie_id_table);
drivers/misc/pci_endpoint_test.c +1 -1
index 896e2df..d27efe838 100644
@@ -788,7 +788,7 @@ static void pci_endpoint_test_remove(struct pci_dev *pdev)
 static const struct pci_device_id pci_endpoint_test_tbl[] = {
 	{ PCI_DEVICE(PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_DRA74x) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_DRA72x) },
-	{ PCI_DEVICE(PCI_VENDOR_ID_SYNOPSYS, 0xedda) },
+	{ PCI_DEVICE_DATA(SYNOPSYS, EDDA, NULL) },
 	{ }
 };
 MODULE_DEVICE_TABLE(pci, pci_endpoint_test_tbl);
include/linux/pci_ids.h +1 -0
index 69f0abe..57f17dd 100644
@@ -2358,6 +2358,7 @@
 #define PCI_DEVICE_ID_CENATEK_IDE	0x0001
 
 #define PCI_VENDOR_ID_SYNOPSYS		0x16c3
+#define PCI_DEVICE_ID_SYNOPSYS_EDDA	0xedda
 
 #define PCI_VENDOR_ID_VITESSE		0x1725
 #define PCI_DEVICE_ID_VITESSE_VSC7174	0x7174
Signature · 1 line
2.7.4