Skip to contentSkip to conversation

spi: i.MX: Fix wrong bus nubering with devicetree

PATCH Applied Alexander Shiyan 2 participants 3 messages Dec 13, 2018 – Dec 14, 2018

Subsystems (4)
Arm (32-bit) Arm sub-architectures Arm i.MX and Layerscape SPI
lore
Share & tools
lore

Alexander Shiyan

author
#0 lore raw

PATCH 1/1 spi: i.MX: Fix wrong bus nubering with devicetree

Signed-off-by Alexander Shiyan <[email protected]>
drivers/spi/imx_spi.c +7 -4
index 10621d00c..46e8955ab 100644
@@ -605,17 +605,20 @@ static int imx_spi_probe(struct device_d *dev)
 
 	master = &imx->master;
 	master->dev = dev;
-	master->bus_num = dev->id;
 
 	master->setup = imx_spi_setup;
 	master->transfer = imx_spi_transfer;
 
 	if (pdata) {
+		master->bus_num = dev->id;
 		master->num_chipselect = pdata->num_chipselect;
 		imx->cs_array = pdata->chipselect;
-	} else {
-		if (IS_ENABLED(CONFIG_OFDEVICE))
-			imx_spi_dt_probe(imx);
+	} else if (IS_ENABLED(CONFIG_OFDEVICE)) {
+		ret = of_alias_get_id(dev->device_node, "spi");
+		if (ret < 0)
+			goto err_free;
+		master->bus_num = ret;
+		imx_spi_dt_probe(imx);
 	}
 
 	imx->clk = clk_get(dev, NULL);
Signature · 7 lines
2.13.0


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
author
#1 lore raw

PATCH 1/1 ARM: clps711x: Increase boot space

Signed-off-by Alexander Shiyan <[email protected]>
arch/arm/boards/clep7212/clep7212.c +1 -1
index 584ecdcab..641fa1502 100644
@@ -37,7 +37,7 @@ static int clps711x_devices_init(void)
 	add_cfi_flash_device(DEVICE_ID_DYNAMIC, (unsigned long)cfi_io, SZ_32M,
 			     IORESOURCE_MEM);
 
-	devfs_add_partition("nor0", 0x00000, SZ_256K, DEVFS_PARTITION_FIXED,
+	devfs_add_partition("nor0", 0x00000, SZ_512K, DEVFS_PARTITION_FIXED,
 			    "self0");
 	devfs_add_partition("nor0", SZ_256K, SZ_256K, DEVFS_PARTITION_FIXED,
 			    "env0");
arch/arm/boards/clep7212/defaultenv-clep7212/init/mtdparts-nor +1 -1
index 39777f95f..e2e518ca6 100644
@@ -1,6 +1,6 @@
 #!/bin/sh
 
-mtdparts="256k(boot),256k(env),3584k(kernel),-(root)"
+mtdparts="512k(boot),256k(env),3584k(kernel),-(root)"
 kernelname="physmap-flash.0"
 
 mtdparts-add -d nor0 -k ${kernelname} -p ${mtdparts}
arch/arm/mach-clps711x/Kconfig +1 -1
index 0853ce2e6..c00514e86 100644
@@ -24,7 +24,7 @@ endmenu
 
 config ARCH_TEXT_BASE
 	hex
-	default 0xc0780000 if MACH_CLEP7212
+	default 0xc0740000 if MACH_CLEP7212
 
 config BAREBOX_MAX_IMAGE_SIZE
 	hex
Signature · 7 lines
2.13.0


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
maintainer Applied
#2 lore raw
In reply to Alexander Shiyan
Quoted 2 lines · Alexander Shiyan
Signed-off-by Alexander Shiyan <[email protected]>

Applied, thanks

Sascha

Quoted 38 lines
drivers/spi/imx_spi.c +7 -4
index 10621d00c..46e8955ab 100644
@@ -605,17 +605,20 @@ static int imx_spi_probe(struct device_d *dev)
 
 	master = &imx->master;
 	master->dev = dev;
-	master->bus_num = dev->id;
 
 	master->setup = imx_spi_setup;
 	master->transfer = imx_spi_transfer;
 
 	if (pdata) {
+		master->bus_num = dev->id;
 		master->num_chipselect = pdata->num_chipselect;
 		imx->cs_array = pdata->chipselect;
-	} else {
-		if (IS_ENABLED(CONFIG_OFDEVICE))
-			imx_spi_dt_probe(imx);
+	} else if (IS_ENABLED(CONFIG_OFDEVICE)) {
+		ret = of_alias_get_id(dev->device_node, "spi");
+		if (ret < 0)
+			goto err_free;
+		master->bus_num = ret;
+		imx_spi_dt_probe(imx);
 	}
 
 	imx->clk = clk_get(dev, NULL);
Signature · 7 lines
2.13.0


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
Signature · 9 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox