cdc-acm: fix abnormal DATA RX issue for Mediatek Preloader.
Quoted 12 lines · Oliver Neukum
Quoted 10 lines · Johan Hovold
Review
Quoted 5 lines · On Thu, Dec 13, 2018 at 11:27:56AM +0800, [email protected] wrote:
From: Macpaul Lin <[email protected]>
(quoted diff) +3
-0+ /* handle active handshake triggered by device */ + if (quirks == DISABLE_ECHO) + acm_tty_driver->init_termios.c_lflag &= ~(ECHO);You cannot change the driver
init_termioslike this as that will affect all cdc-acm devices that are probed later. If this is at all needed, this will have to be done at tty install time.
Quoted 1 line
Right. How do with decide on a sensible default anyway?
I think the current defaults are sensible. They are based on tty_std_termios, which has ECHO set, as for most (all?) tty drivers.
Johan