vhost: correct the related warning message

PATCH Applied wangyan 3 participants 8 messages Dec 13, 2018

Subsystems (6)

Networking Network drivers KVM virtio core +2 more subsystems

lore

Share & tools

lore

wangyan

author

2018-12-13 01:10 UTC #0 lore raw

PATCH 1/1 vhost: correct the related warning message

Fixes: 'commit d588cf8f618d ("target: Fix se_tpg_tfo->tf_subsys regression + remove tf_subsystem")'
'commit cbbd26b8b1a6 ("[iov_iter] new primitives - copy_from_iter_full() and friends")'

Signed-off-by Yan Wang <[email protected]>

Reviewed-by Jun Piao <[email protected]>

---
 drivers/vhost/scsi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/vhost/scsi.c +2 -2

index 50dffe8..b459b69 100644
@@ -889,7 +889,7 @@ static void vhost_scsi_submission_work(struct work_struct *work)
 
 	if (unlikely(!copy_from_iter_full(vc->req, vc->req_size,
 					  &vc->out_iter))) {
-		vq_err(vq, "Faulted on copy_from_iter\n");
+		vq_err(vq, "Faulted on copy_from_iter_full\n");
 	} else if (unlikely(*vc->lunp != 1)) {
 		/* virtio-scsi spec requires byte 0 of the lun to be 1 */
 		vq_err(vq, "Illegal virtio-scsi lun: %u\n", *vc->lunp);

@@ -1441,7 +1441,7 @@ static void vhost_scsi_flush(struct vhost_scsi *vs)
 			se_tpg = &tpg->se_tpg;
 			ret = target_depend_item(&se_tpg->tpg_group.cg_item);
 			if (ret) {
-				pr_warn("configfs_depend_item() failed: %d\n", ret);
+				pr_warn("target_depend_item() failed: %d\n", ret);
 				kfree(vs_tpg);
 				mutex_unlock(&tpg->tv_tpg_mutex);
 				goto out;

Signature · 1 line

1.8.3.1

Michael S. Tsirkin

maintainer Applied

2018-12-13 02:03 UTC #1 lore raw

Quoted 5 lines · wangyan

Fixes: 'commit d588cf8f618d ("target: Fix se_tpg_tfo->tf_subsys regression + remove tf_subsystem")'
'commit cbbd26b8b1a6 ("[iov_iter] new primitives - copy_from_iter_full() and friends")'
Signed-off-by Yan Wang <[email protected]>
Reviewed-by Jun Piao <[email protected]>

Applied, thanks!

Quoted 29 lines

---
 drivers/vhost/scsi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/vhost/scsi.c +2 -2

index 50dffe8..b459b69 100644
@@ -889,7 +889,7 @@ static void vhost_scsi_submission_work(struct work_struct *work)
 
 	if (unlikely(!copy_from_iter_full(vc->req, vc->req_size,
 					  &vc->out_iter))) {
-		vq_err(vq, "Faulted on copy_from_iter\n");
+		vq_err(vq, "Faulted on copy_from_iter_full\n");
 	} else if (unlikely(*vc->lunp != 1)) {
 		/* virtio-scsi spec requires byte 0 of the lun to be 1 */
 		vq_err(vq, "Illegal virtio-scsi lun: %u\n", *vc->lunp);

@@ -1441,7 +1441,7 @@ static void vhost_scsi_flush(struct vhost_scsi *vs)
 			se_tpg = &tpg->se_tpg;
 			ret = target_depend_item(&se_tpg->tpg_group.cg_item);
 			if (ret) {
-				pr_warn("configfs_depend_item() failed: %d\n", ret);
+				pr_warn("target_depend_item() failed: %d\n", ret);
 				kfree(vs_tpg);
 				mutex_unlock(&tpg->tv_tpg_mutex);
 				goto out;

Signature · 1 line

1.8.3.1

Michael S. Tsirkin

maintainer Applied

2018-12-13 02:03 UTC #2 lore raw

In reply to wangyan

Quoted 5 lines · wangyan

Fixes: 'commit d588cf8f618d ("target: Fix se_tpg_tfo->tf_subsys regression + remove tf_subsystem")'
'commit cbbd26b8b1a6 ("[iov_iter] new primitives - copy_from_iter_full() and friends")'
Signed-off-by Yan Wang <[email protected]>
Reviewed-by Jun Piao <[email protected]>

Applied, thanks!

Quoted 29 lines

---
 drivers/vhost/scsi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/vhost/scsi.c +2 -2

index 50dffe8..b459b69 100644
@@ -889,7 +889,7 @@ static void vhost_scsi_submission_work(struct work_struct *work)
 
 	if (unlikely(!copy_from_iter_full(vc->req, vc->req_size,
 					  &vc->out_iter))) {
-		vq_err(vq, "Faulted on copy_from_iter\n");
+		vq_err(vq, "Faulted on copy_from_iter_full\n");
 	} else if (unlikely(*vc->lunp != 1)) {
 		/* virtio-scsi spec requires byte 0 of the lun to be 1 */
 		vq_err(vq, "Illegal virtio-scsi lun: %u\n", *vc->lunp);

@@ -1441,7 +1441,7 @@ static void vhost_scsi_flush(struct vhost_scsi *vs)
 			se_tpg = &tpg->se_tpg;
 			ret = target_depend_item(&se_tpg->tpg_group.cg_item);
 			if (ret) {
-				pr_warn("configfs_depend_item() failed: %d\n", ret);
+				pr_warn("target_depend_item() failed: %d\n", ret);
 				kfree(vs_tpg);
 				mutex_unlock(&tpg->tv_tpg_mutex);
 				goto out;

Signature · 1 line

1.8.3.1

Sergei Shtylyov

2018-12-13 09:05 UTC #3 lore raw

In reply to wangyan

Quoted 2 lines · wangyan

Fixes: 'commit d588cf8f618d ("target: Fix se_tpg_tfo->tf_subsys regression + remove tf_subsystem")'
'commit cbbd26b8b1a6 ("[iov_iter] new primitives - copy_from_iter_full() and friends")'

Fixes d588cf8f618d ("target: Fix se_tpg_tfo->tf_subsys regression + remove tf_subsystem")

Fixes cbbd26b8b1a6 ("[iov_iter] new primitives - copy_from_iter_full() and friends")

But no line wrapping allowed (can't find how to turn it off in my mailer).

Quoted 2 lines

Signed-off-by Yan Wang <[email protected]>
Reviewed-by Jun Piao <[email protected]>

[...]

MBR, Sergei

Michael S. Tsirkin

maintainer

2018-12-13 15:21 UTC #4 lore raw

Quoted 11 lines · Sergei Shtylyov

Quoted 2 lines · wangyan
Fixes: 'commit d588cf8f618d ("target: Fix se_tpg_tfo->tf_subsys regression + remove tf_subsystem")'
'commit cbbd26b8b1a6 ("[iov_iter] new primitives - copy_from_iter_full() and friends")'
Fixes d588cf8f618d ("target: Fix se_tpg_tfo->tf_subsys regression + remove
tf_subsystem")
Fixes cbbd26b8b1a6 ("[iov_iter] new primitives - copy_from_iter_full() and
friends")
But no line wrapping allowed (can't find how to turn it off in my mailer).

Well is the standard really sane if people can't find a way to follow it without being forced to use a specific mailer?

Quoted 5 lines

Quoted 2 lines
Signed-off-by Yan Wang <[email protected]>
Reviewed-by Jun Piao <[email protected]>
[...]
MBR, Sergei

Sergei Shtylyov

2018-12-13 20:06 UTC #5 lore raw

Quoted 8 lines · Michael S. Tsirkin

Quoted 8 lines
Quoted 2 lines
Fixes: 'commit d588cf8f618d ("target: Fix se_tpg_tfo->tf_subsys regression + remove tf_subsystem")'
'commit cbbd26b8b1a6 ("[iov_iter] new primitives - copy_from_iter_full() and friends")'
Fixes d588cf8f618d ("target: Fix se_tpg_tfo->tf_subsys regression + remove
tf_subsystem")
Fixes cbbd26b8b1a6 ("[iov_iter] new primitives - copy_from_iter_full() and
friends")

Quoted 4 lines

Quoted 1 line
But no line wrapping allowed (can't find how to turn it off in my mailer).
Well is the standard really sane if people can't find a way to follow it without being forced to use a specific mailer?

Hum, my mail looked correct, although I wasn't able to get the editor to NOT
wrap my lines. Go figure... :-)

Quoted 3 lines

Quoted 3 lines
Quoted 2 lines
Signed-off-by Yan Wang <[email protected]>
Reviewed-by Jun Piao <[email protected]>
[...]

MBR, Sergei

Sergei Shtylyov

2018-12-13 20:06 UTC #6 lore raw

In reply to Michael S. Tsirkin

Quoted 8 lines · Michael S. Tsirkin

Quoted 8 lines
Quoted 2 lines
Fixes: 'commit d588cf8f618d ("target: Fix se_tpg_tfo->tf_subsys regression + remove tf_subsystem")'
'commit cbbd26b8b1a6 ("[iov_iter] new primitives - copy_from_iter_full() and friends")'
Fixes d588cf8f618d ("target: Fix se_tpg_tfo->tf_subsys regression + remove
tf_subsystem")
Fixes cbbd26b8b1a6 ("[iov_iter] new primitives - copy_from_iter_full() and
friends")

Quoted 4 lines

Quoted 1 line
But no line wrapping allowed (can't find how to turn it off in my mailer).
Well is the standard really sane if people can't find a way to follow it without being forced to use a specific mailer?

Hum, my mail looked correct, although I wasn't able to get the editor to NOT
wrap my lines. Go figure... :-)

Quoted 3 lines

Quoted 3 lines
Quoted 2 lines
Signed-off-by Yan Wang <[email protected]>
Reviewed-by Jun Piao <[email protected]>
[...]

MBR, Sergei

Michael S. Tsirkin

maintainer

2018-12-13 15:21 UTC #7 lore raw

In reply to Sergei Shtylyov

Quoted 11 lines · Sergei Shtylyov

Quoted 2 lines · wangyan
Fixes: 'commit d588cf8f618d ("target: Fix se_tpg_tfo->tf_subsys regression + remove tf_subsystem")'
'commit cbbd26b8b1a6 ("[iov_iter] new primitives - copy_from_iter_full() and friends")'
Fixes d588cf8f618d ("target: Fix se_tpg_tfo->tf_subsys regression + remove
tf_subsystem")
Fixes cbbd26b8b1a6 ("[iov_iter] new primitives - copy_from_iter_full() and
friends")
But no line wrapping allowed (can't find how to turn it off in my mailer).

Well is the standard really sane if people can't find a way to follow it without being forced to use a specific mailer?

Quoted 5 lines

Quoted 2 lines
Signed-off-by Yan Wang <[email protected]>
Reviewed-by Jun Piao <[email protected]>
[...]
MBR, Sergei