Skip to contentSkip to conversation

buildman and "echo" output?

U-Boot Tom Rini 3 participants 4 messages Dec 13, 2018 – Dec 14, 2018 Kbuild

lore
Share & tools
lore

Tom Rini

author
#0 lore raw

Hey Simon,

How hard would it be to have buildman notice and print out the echo'd warnings we have in the toplevel Makefile? By which I mean if you use buildman to build omap3_beagle you see just the DT warnings but if you run make by hand you also get:
==================== WARNING ======================
This board does not use CONFIG_DM_MMC. Please update
the board to use CONFIG_DM_MMC before the v2019.04 release. Failure to update by the deadline may result in board removal. See doc/driver-model/MIGRATION.txt for more info.
====================================================
===================== WARNING ======================
This board does not use CONFIG_DM_USB. Please update
the board to use CONFIG_DM_USB before the v2019.07 release. Failure to update by the deadline may result in board removal. See doc/driver-model/MIGRATION.txt for more info.
====================================================

and as we want to get these things migrated we should make sure buildman shows them I think. Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181213/52c74a46/attachment.sig>
#1 lore raw

Hi Tom, Simon,

Quoted 20 lines · Tom Rini

Hey Simon,

How hard would it be to have buildman notice and print out the echo'd warnings we have in the toplevel Makefile? By which I mean if you use buildman to build omap3_beagle you see just the DT warnings but if you run make by hand you also get:
==================== WARNING ======================
This board does not use CONFIG_DM_MMC. Please update
the board to use CONFIG_DM_MMC before the v2019.04 release. Failure to update by the deadline may result in board removal. See doc/driver-model/MIGRATION.txt for more info.
====================================================
===================== WARNING ======================
This board does not use CONFIG_DM_USB. Please update
the board to use CONFIG_DM_USB before the v2019.07 release. Failure to update by the deadline may result in board removal. See doc/driver-model/MIGRATION.txt for more info.
====================================================

Quoted 3 lines

and as we want to get these things migrated we should make sure buildman shows them I think. Thanks!

If these appear on stderr buildman seems to output them. I could turn the following into a proper patch if you want.

Quoted 1 line

--diff --git a/Makefile b/Makefile

index 5683714947f2..3666396a034c 100644

Makefile +9 -11
@@ -913,47 +913,47 @@ cmd_cfgcheck = $(srctree)/scripts/check-config.sh $2 \
 
 all:           $(ALL-y) cfg
 ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y)
-       @echo "===================== WARNING ======================"
-       @echo "This board uses CONFIG_DM_I2C_COMPAT. Please remove"
-       @echo "(possibly in a subsequent patch in your series)"
-       @echo "before sending patches to the mailing list."
-       @echo "===================================================="
+       @echo "===================== WARNING ======================" >&2
+       @echo "This board uses CONFIG_DM_I2C_COMPAT. Please remove"  >&2
+       @echo "(possibly in a subsequent patch in your series)"      >&2
+       @echo "before sending patches to the mailing list."          >&2
+       @echo "====================================================" >&2
 endif
 ifeq ($(CONFIG_MMC),y)
 ifneq ($(CONFIG_DM_MMC)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy)
-       @echo "===================== WARNING ======================"
-       @echo "This board does not use CONFIG_DM_MMC. Please update"
-       @echo "the board to use CONFIG_DM_MMC before the v2019.04 release."
-       @echo "Failure to update by the deadline may result in board removal."
-       @echo "See doc/driver-model/MIGRATION.txt for more info."
-       @echo "===================================================="
+       @echo "===================== WARNING ======================" >&2
+       @echo "This board does not use CONFIG_DM_MMC. Please update" >&2
+       @echo "the board to use CONFIG_DM_MMC before the v2019.04 release." >&2
+       @echo "Failure to update by the deadline may result in board

removal." >&2
+ @echo "See doc/driver-model/MIGRATION.txt for more info." >&2
+ @echo "====================================================" >&2
endif
endif
ifeq ($(CONFIG_USB),y)
ifneq ($(CONFIG_DM_USB)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy)

-       @echo "===================== WARNING ======================"
-       @echo "This board does not use CONFIG_DM_USB. Please update"
-       @echo "the board to use CONFIG_DM_USB before the v2019.07 release."
-       @echo "Failure to update by the deadline may result in board removal."
-       @echo "See doc/driver-model/MIGRATION.txt for more info."
-       @echo "===================================================="
+       @echo "===================== WARNING ======================" >&2
+       @echo "This board does not use CONFIG_DM_USB. Please update" >&2
+       @echo "the board to use CONFIG_DM_USB before the v2019.07 release." >&2
+       @echo "Failure to update by the deadline may result in board

removal." >&2
+ @echo "See doc/driver-model/MIGRATION.txt for more info." >&2
+ @echo "====================================================" >&2
endif
endif
ifeq ($(CONFIG_LIBATA)$(CONFIG_DM_SCSI)$(CONFIG_MVSATA_IDE),y)

-       @echo "===================== WARNING ======================"
-       @echo "This board does not use CONFIG_DM_SCSI. Please update"
-       @echo "the storage controller to use CONFIG_DM_SCSI before the
v2019.07 release."
-       @echo "Failure to update by the deadline may result in board removal."
-       @echo "See doc/driver-model/MIGRATION.txt for more info."
-       @echo "===================================================="
+       @echo "===================== WARNING ======================" >&2
+       @echo "This board does not use CONFIG_DM_SCSI. Please update" >&2
+       @echo "the storage controller to use CONFIG_DM_SCSI before the

v2019.07 release." >&2
+ @echo "Failure to update by the deadline may result in board
removal." >&2
+ @echo "See doc/driver-model/MIGRATION.txt for more info." >&2
+ @echo "====================================================" >&2
endif
ifeq ($(CONFIG_OF_EMBED),y)

-       @echo "===================== WARNING ======================"
-       @echo "CONFIG_OF_EMBED is enabled. This option should only"
-       @echo "be used for debugging purposes. Please use"
-       @echo "CONFIG_OF_SEPARATE for boards in mainline."
-       @echo "See doc/README.fdt-control for more info."
-       @echo "===================================================="
+       @echo "===================== WARNING ======================" >&2
+       @echo "CONFIG_OF_EMBED is enabled. This option should only"  >&2
+       @echo "be used for debugging purposes. Please use"           >&2
+       @echo "CONFIG_OF_SEPARATE for boards in mainline."           >&2
+       @echo "See doc/README.fdt-control for more info."            >&2
+       @echo "====================================================" >&2

endif
@# Check that this build does not use CONFIG options that we do not @# know about unless they are in Kconfig. All the existing CONFIG

author
#2 lore raw
Quoted 23 lines · Chris Packham

Hi Tom, Simon,

Quoted 20 lines · Tom Rini

Hey Simon,

How hard would it be to have buildman notice and print out the echo'd warnings we have in the toplevel Makefile? By which I mean if you use buildman to build omap3_beagle you see just the DT warnings but if you run make by hand you also get:
==================== WARNING ======================
This board does not use CONFIG_DM_MMC. Please update
the board to use CONFIG_DM_MMC before the v2019.04 release. Failure to update by the deadline may result in board removal. See doc/driver-model/MIGRATION.txt for more info.
====================================================
===================== WARNING ======================
This board does not use CONFIG_DM_USB. Please update
the board to use CONFIG_DM_USB before the v2019.07 release. Failure to update by the deadline may result in board removal. See doc/driver-model/MIGRATION.txt for more info.
====================================================

Quoted 6 lines
Quoted 3 lines

and as we want to get these things migrated we should make sure buildman shows them I think. Thanks!

If these appear on stderr buildman seems to output them. I could turn the following into a proper patch if you want.

Seems like the most reasonable way to fix this, yes please, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181214/2ae0756f/attachment.sig>
#3 lore raw

Hi,

Quoted 25 lines · Tom Rini
Quoted 23 lines · Chris Packham

Hi Tom, Simon,

Quoted 20 lines · Tom Rini

Hey Simon,

How hard would it be to have buildman notice and print out the echo'd warnings we have in the toplevel Makefile? By which I mean if you use buildman to build omap3_beagle you see just the DT warnings but if you run make by hand you also get:
==================== WARNING ======================
This board does not use CONFIG_DM_MMC. Please update
the board to use CONFIG_DM_MMC before the v2019.04 release. Failure to update by the deadline may result in board removal. See doc/driver-model/MIGRATION.txt for more info.
====================================================
===================== WARNING ======================
This board does not use CONFIG_DM_USB. Please update
the board to use CONFIG_DM_USB before the v2019.07 release. Failure to update by the deadline may result in board removal. See doc/driver-model/MIGRATION.txt for more info.
====================================================

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

and as we want to get these things migrated we should make sure buildman shows them I think. Thanks!

If these appear on stderr buildman seems to output them. I could turn the following into a proper patch if you want.

Seems like the most reasonable way to fix this, yes please, thanks!

Yes that makes sense, and these will also show up as warnings in buildman.

Regards,
Simon